https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-15728 Lustre <p><tt>relatime</tt> behavior is properly managed by VFS, however Lustre also stores <tt>acmtime</tt> on OST objects and <tt>atime</tt> updates for OST objects should honor <tt>relatime</tt> behavior.</p> <p><tt>ci_noatime</tt> feature was introduced by <a href="https://jira.whamcloud.com/browse/LU-3832" title="osc_io_read_start() ignores O_NOATIME, updates i_atime" class="issue-link" data-issue-key="LU-3832"><del>LU-3832</del></a> to properly honor <tt>noatime</tt> option for OST objects. However, the relatime management was not added at the same time, even if it uses the same function.</p> <p><tt>relatime</tt> could be fixed adding the missing parts from touch_atime() to also support relatime.</p> LU-15728

'relatime' is not working properly

Bug Minor Resolved Fixed Aurelien Degremont Aurelien Degremont Fri, 8 Apr 2022 13:16:30 +0000 Mon, 21 Aug 2023 08:47:20 +0000 Thu, 23 Feb 2023 14:04:46 +0000 Lustre 2.12.7 Lustre 2.15.0 Lustre 2.16.0 1 7 <p>"Aurelien Degremont &lt;degremoa@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/47017" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/47017</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15728" title="&#39;relatime&#39; is not working properly" class="issue-link" data-issue-key="LU-15728"><del>LU-15728</del></a> llite: fix relatime support<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 88c75bdb30025744ca1cb90a94677015ab7adcdd</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/47017/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/47017/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15728" title="&#39;relatime&#39; is not working properly" class="issue-link" data-issue-key="LU-15728"><del>LU-15728</del></a> llite: fix relatime support<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: c10c6eeb37dd553166367b96369dca25183ace3b</p> <p>Landed for 2.16</p> <p>with this patch landed sanity/56oc started to fail sometimes:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 54eb6da1f8 1 0 1 BAD LU-16477 ldiskfs: Add ext4-enc-flag patch <span class="code-keyword">for</span> RHEL9 c10c6eeb37 6 5 1 BAD LU-15728 llite: fix relatime support 0c05dc21ab 6 6 0 GOOD LU-6142 ldlm: minor list_entry improvements in ldlm_request.c 685fb4b17f 6 6 0 GOOD LU-6142 ldlm: use list_for_each_entry in ldlm_lock.c 93230059ab 6 6 0 GOOD LU-12275 tests: skip <span class="code-keyword">new</span> nodemap params on old MGS 2f8f38effa 6 6 0 GOOD LU-16412 llite: check read page past requested 4b47c233b3 6 6 0 GOOD LU-16457 tests: wait <span class="code-keyword">for</span> remote sleep in sanity-pcc/101a 5a5bd5b4da 6 6 0 GOOD LU-16159 osp: destroy should not overtake writes </pre> </div></div> <p>I'll look at it</p> <p>Any tips to find all failing occurences in Maloo with some query? I'm failing to do it.</p> <p>subtest search in Maloo for sanity/test_56oc ?</p> <p>I think i found the reason.</p> <p> </p> <blockquote><p> It also forces atime to disk on MDD if ondisk atime is older than ondisk mtime/ctime to match relatime (even if relatime is not enabled)</p></blockquote> <p>This code change shows the culprit: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/47017/1/lustre/tests/sanity.sh#5123" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/47017/1/lustre/tests/sanity.sh#5123</a></p> <p>That's a change that Andreas asked for in <a href="https://review.whamcloud.com/c/fs/lustre-release/+/47017/1/lustre/tests/sanity.sh#5123" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/47017/1/lustre/tests/sanity.sh#5123</a></p> <p> </p> <p>I reproduced the failure and did not without that change in that Gerrit patch (<a href="https://review.whamcloud.com/c/fs/lustre-release/+/50009/2" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50009/2</a>)</p> <p> </p> <p>I need to think about it</p> <p> </p> <blockquote> <p>Any tips to find all failing occurences in Maloo with some query? I'm failing to do it.</p></blockquote> <p>Two easy ways to find similar failures. For any subtest failure report in Maloo, you can click on the failed subtest number and it will generate a search for failures of that subtest in the past week. You can then modify the query for specific date ranges, or limit it to specific branches, etc. There is a "<tt>link to this page</tt>" at the bottom to save the URL for future reference, like the following which searches from 2023-01-15 to 2023-02-15 and shows that the problem was hit once by the patch before landing on 2023-02-01, and then by other patches starting on 2023-02-07 after the patch landed:</p> <p><a href="https://testing.whamcloud.com/search?client_branch_type_id=24a6947e-04a9-11e1-bb5f-52540025f9af&amp;server_branch_type_id=24a6947e-04a9-11e1-bb5f-52540025f9af&amp;status%5B%5D=FAIL&amp;test_set_script_id=f9516376-32bc-11e0-aaee-52540025f9ae&amp;sub_test_script_id=cb9003f2-f26b-11e9-b62b-52540065bddc&amp;start_date=2023-01-15&amp;end_date=2023-02-15&amp;source=sub_tests#redirect" class="external-link" target="_blank" rel="nofollow noopener">https://testing.whamcloud.com/search?client_branch_type_id=24a6947e-04a9-11e1-bb5f-52540025f9af&amp;server_branch_type_id=24a6947e-04a9-11e1-bb5f-52540025f9af&amp;status%5B%5D=FAIL&amp;test_set_script_id=f9516376-32bc-11e0-aaee-52540025f9ae&amp;sub_test_script_id=cb9003f2-f26b-11e9-b62b-52540065bddc&amp;start_date=2023-01-15&amp;end_date=2023-02-15&amp;source=sub_tests#redirect</a></p> <p>Alternately, you can get to this search page from the "<tt>Results-&gt;Search</tt>" <a href="https://testing.whamcloud.com/search" class="external-link" target="_blank" rel="nofollow noopener">link at the top of any Maloo page</a>, and then select "<tt>Sub tests</tt>" to limit the query to specific subtest failures, as opposed to whole "<tt>Test sets</tt>" failures.</p> <p>Reopen to track sanity test_56oc failure triggered by this patch.</p> <p>Patch to fix the regression: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50009/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50009/</a></p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50009/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50009/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15728" title="&#39;relatime&#39; is not working properly" class="issue-link" data-issue-key="LU-15728"><del>LU-15728</del></a> mdd: fix sanity-56oc failure<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 8beeec77c3b426a01e1f10ca51149c7ca7e01b7e</p> <p>Landed for 2.16</p> Related LU-1783 Development Rank 1|i02mov: Rank (Obsolete) 9223372036854775807 Severity