https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-1579 Lustre <p>In the osd_declare_xattr_set() for ldiskfs:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">if</span> (strcmp(name, XATTR_NAME_VERSION) == 0) { <span class="code-comment">/* no credits <span class="code-keyword">for</span> version */</span> <span class="code-keyword">return</span> 0; } </pre> </div></div> <p>So if a caller calls only dt_version_set() to set inode version, the reserved credits for this transaction will be zero. I think we'd reserve 1 block for version set.</p> LU-1579

osd_declare_xattr_set() doesn't reserve credits for version set

Bug Minor Resolved Fixed Niu Yawei Niu Yawei Thu, 28 Jun 2012 07:49:54 +0000 Thu, 18 Apr 2013 18:50:56 +0000 Thu, 13 Sep 2012 01:38:38 +0000 Lustre 2.3.0 Lustre 2.4.0 0 0 <p>As I remember there is always inode update when version is changed. So this inode block is reserved and we don't need to reserve one more. Do you have in mind any case when it is not so?</p> <p>I'm not sure if there is any use cases for now, but in orion_quota, we'll use the version as quota index file version, and sometimes, we need to bump version only.</p> <p>to be honest, I wouldn't worry about quota index files, because related transactions will be rather small...</p> <p>The problem is that if we don't reserve anything for set version, we may end up with an 0 credits journal handle (and trigger LBUG in jbd) for the caller who calls declare_version_set() -&gt; dt_version_set() only. </p> <p>An alternative is that we can call some other declare functions before dt_version_set(), but which looks not clean.</p> <p><a href="http://review.whamcloud.com/3242" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/3242</a></p> <p>patch landed.</p> Development Rank 1|hzv5sf: Rank (Obsolete) 4472 Severity