Whamcloud Community JIRA

Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us

9.4.14

940014

05-12-2023

[LU-15798] RHEL9 / gcc-11 adds -Wstringop-overread false warnings https://jira.whamcloud.com/browse/LU-15798 Lustre <p>gcc-11 stringop-overread reports a false positive on<br/> changelog record name.</p> <p>Use _Pragma to exclude the diagnostic for this case.</p> LU-15798

RHEL9 / gcc-11 adds -Wstringop-overread false warnings

Improvement Minor Open Unresolved Shaun Tancheff Shaun Tancheff Thu, 28 Apr 2022 03:36:25 +0000 Tue, 16 Jan 2024 10:34:01 +0000 0 5 <p>"Shaun Tancheff <shaun.tancheff@hpe.com>" uploaded a new patch: <a href="https://review.whamcloud.com/47167" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/47167</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15798" title="RHEL9 / gcc-11 adds -Wstringop-overread false warnings" class="issue-link" data-issue-key="LU-15798">LU-15798</a> build: gcc-11 -Wstringop-overread false warnings<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 35fefe81451287ab6431849d1f9ce9b8cb78c967</p> <p>Patch <a href="https://review.whamcloud.com/c/46319" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/46319</a> resolves this in a clear way,</p> <p>This issue still exists on rhel9.2:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> /tmp/rpmbuild-lustre-jenkins-SCTCWlBO/BUILD/lustre-2.15.58_59_g2ddb1d3_dirty/lustre/include/uapi/linux/lustre/lustre_user.h:2095:16: error: <span class="code-quote">'strlen'</span> reading 1 or more bytes from a region of size 0 [-Werror=stringop-overread] 2095 | <span class="code-keyword">return</span> strlen(changelog_rec_sname(rec)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ </pre> </div></div> <p>Strange that I do not see this on x86_64 ... it this aarch64?</p> <p>Yes, it is aarch64.</p> <p>@<a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=stancheff" class="user-hover" rel="stancheff">stancheff</a> have tried make rpms? Just make no compile error.</p> <p>Yes, make and make rpms both work.</p> <p>With gcc-12 I do see a few issues with configure and with compiling:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>In function ‘strnlen’, inlined from ‘lov_iocontrol’ at /home/shaun/lustre-release/lustre/lov/lov_obd.c:1079:4: include/linux/fortify-string.h:23:34: error: array subscript 112 is outside array bounds of ‘void[112]’ [-Werror=array-bounds] 23 | __builtin_constant_p(*__p)) { \ | ^~~~ include/linux/fortify-string.h:141:24: note: in expansion of macro ‘__compiletime_strlen’ 141 | size_t p_len = __compiletime_strlen(p); | ^~~~~~~~~~~~~~~~~~~~ In file included from include/linux/fs.h:44, from /home/shaun/lustre-release/libcfs/include/libcfs/linux/linux-misc.h:35, from /home/shaun/lustre-release/libcfs/include/libcfs/libcfs.h:43: In function ‘kmalloc’, inlined from ‘lov_iocontrol’ at /home/shaun/lustre-release/lustre/lov/lov_obd.c:1072:3: include/linux/slab.h:611:24: note: at offset 112 into object of size 112 allocated by ‘kmem_cache_alloc_trace’ 611 | return kmem_cache_alloc_trace( | ^~~~~~~~~~~~~~~~~~~~~~~ 612 | kmalloc_caches[kmalloc_type(flags)][index], | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 613 | flags, size); | ~~~~~~~~~~~~ cc1: all warnings being treated as errors </pre> </div></div> <p>Thanks, <a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=stancheff" class="user-hover" rel="stancheff">stancheff</a> for the info, it seems an Aarch64 specific issue.</p> <p>Find that the below commit breaks the compiling on rhel9.2.</p> <p>efc5c8d4de60 <a href="https://jira.whamcloud.com/browse/LU-16335" title=""lfs rm_entry" failed to remove broken directories" class="issue-link" data-issue-key="LU-16335"><del>LU-16335</del></a> build: remove _GNU_SOURCE dependency in lustre_user.h</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> ~/work/lustre/lustre-release$ git log -p efc5c8d4de60 -- lustre<span class="code-comment">//include/uapi/linux/lustre/lustre_user.h </span>Author: Lai Siyao <lai.siyao@whamcloud.com> Date: Thu Dec 1 03:17:00 2022 -0500 LU-16335 build: remove _GNU_SOURCE dependency in lustre_user.h The lustre_user.h header uses the non-standard strchrnul() function in userspace. This will always leads to LC_IOC_REMOVE_ENTRY configure check to fail, and in the end <span class="code-quote">"lfs rm_entry"</span> always returns -ENOTSUP. Implement an alternative approach to avoid external dependencies on the lustre_user.h header. Also, LC_IOC_REMOVE_ENTRY is itself unnecessary, the code can check <span class="code-keyword">for</span> LL_IOC_REMOVE_ENTRY directly. Replace the NFS-specific -ENOTSUP error <span class="code-keyword">return</span> code with -EOPNOTSUPP. Fix the compile test_400[ab] checks to not use <span class="code-quote">"-std=c99"</span> to verify that the uapi headers are usable without <span class="code-keyword">this</span> dependency. ... diff --git a/lustre/include/uapi/linux/lustre/lustre_user.h b/lustre/include/uapi/linux/lustre/lustre_user.h index 1b1e60acf805..36e1e70b9224 100644 --- a/lustre/include/uapi/linux/lustre/lustre_user.h +++ b/lustre/include/uapi/linux/lustre/lustre_user.h @@ -2033,7 +2033,11 @@ <span class="code-keyword">static</span> inline <span class="code-object">char</span> *changelog_rec_name(<span class="code-keyword">const</span> struct changelog_rec *rec) <span class="code-keyword">static</span> inline <span class="code-object">char</span> *changelog_rec_sname(<span class="code-keyword">const</span> struct changelog_rec *rec) { - <span class="code-keyword">return</span> strchrnul(changelog_rec_name(rec), <span class="code-quote">'\0'</span>) + 1; + <span class="code-object">char</span> *str = changelog_rec_name(rec); + + <span class="code-keyword">while</span> (*str != <span class="code-quote">'\0'</span>) + str++; + <span class="code-keyword">return</span> str + 1; } </pre> </div></div> <p>"xinliang <xinliang.liu@linaro.org>" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/53685" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/53685</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15798" title="RHEL9 / gcc-11 adds -Wstringop-overread false warnings" class="issue-link" data-issue-key="LU-15798">LU-15798</a> build: fix gcc-11 -Wstringop-overread warnings<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: d14dc3ce31e06bacdb79e2c2457b65669c554358</p> <p>This issue can be fixed by patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/53624" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/53624</a></p> Related LU-17400 LU-15420 Development Rank 1|i02ofb: Rank (Obsolete) 9223372036854775807