Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 [LU-15860] ksocknal_add_peer() race results in extra ksock_conn_cb https://jira.whamcloud.com/browse/LU-15860 Lustre <p>Seems there is a race where two ksock_conn_cb can be created:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Bad conn_cb 00000800:00000010:19.0:1652717291.344361:0:4361:0:(socklnd.c:170:ksocknal_create_peer()) alloc '(peer_ni)': 240 at ffff9215aa86b700 (tot 41715364). 00000800:00000010:19.0:1652717291.344362:0:4361:0:(socklnd.c:119:ksocknal_create_conn_cb()) alloc '(conn_cb)': 200 at ffff9215aa86b600 (tot 41715564). 00000800:00000200:19.1:1652717291.344363:0:4361:0:(socklnd.c:556:ksocknal_add_conn_cb_locked()) pre ffff9215aa86b700 1 00000800:00000200:19.1:1652717291.344364:0:4361:0:(socklnd.c:556:ksocknal_add_conn_cb_locked()) post ffff9215aa86b700 2 00000800:00000200:19.0:1652717291.344365:0:4361:0:(socklnd.c:239:ksocknal_find_peer_locked()) got peer_ni [ffff9215aa86b700] -&gt; 12345-172.18.2.8@tcp (2) 00000800:00000200:19.1:1652717291.344366:0:4361:0:(socklnd.c:239:ksocknal_find_peer_locked()) got peer_ni [ffff9215aa86b700] -&gt; 12345-172.18.2.8@tcp (2) 00000800:00000200:19.1:1652717291.344367:0:4361:0:(socklnd_cb.c:645:ksocknal_launch_connection_locked()) pre ffff9215aa86b600 1 00000800:00000200:19.1:1652717291.344368:0:4361:0:(socklnd_cb.c:645:ksocknal_launch_connection_locked()) post ffff9215aa86b600 2 Good conn_cb 00000800:00000010:16.0:1652717291.344365:0:4360:0:(socklnd.c:119:ksocknal_create_conn_cb()) alloc '(conn_cb)': 200 at ffff9215aca22600 (tot 41715508). ... 00000800:00000200:16.1:1652717291.344371:0:4360:0:(socklnd.c:239:ksocknal_find_peer_locked()) got peer_ni [ffff9215aa86b700] -&gt; 12345-172.18.2.8@tcp (2) 00000800:00000200:16.1:1652717291.344375:0:4360:0:(socklnd.c:556:ksocknal_add_conn_cb_locked()) pre ffff9215aa86b700 2 00000800:00000200:16.1:1652717291.344375:0:4360:0:(socklnd.c:556:ksocknal_add_conn_cb_locked()) post ffff9215aa86b700 3 00000800:00000200:16.0:1652717291.344377:0:4360:0:(socklnd.c:239:ksocknal_find_peer_locked()) got peer_ni [ffff9215aa86b700] -&gt; 12345-172.18.2.8@tcp (3) 00000800:00000200:16.1:1652717291.344378:0:4360:0:(socklnd.c:239:ksocknal_find_peer_locked()) got peer_ni [ffff9215aa86b700] -&gt; 12345-172.18.2.8@tcp (3) 00000800:00000200:16.1:1652717291.344378:0:4360:0:(socklnd_cb.c:645:ksocknal_launch_connection_locked()) pre ffff9215aca22600 1 00000800:00000200:16.1:1652717291.344379:0:4360:0:(socklnd_cb.c:645:ksocknal_launch_connection_locked()) post ffff9215aca22600 2 </pre> </div></div> <p>The second one overwrites the first in ksocknal_add_peer()-&gt;ksocknal_add_conn_cb_locked(). The first one gets stuck and is never freed on shutdown.</p> LU-15860 ksocknal_add_peer() race results in extra ksock_conn_cb Bug Minor Resolved Fixed Chris Horn Chris Horn Mon, 16 May 2022 20:07:17 +0000 Tue, 11 Apr 2023 02:03:57 +0000 Mon, 27 Jun 2022 16:02:48 +0000 Lustre 2.16.0 Lustre 2.15.3 0 2 <p>"Chris Horn &lt;chris.horn@hpe.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/47361" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/47361</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15860" title="ksocknal_add_peer() race results in extra ksock_conn_cb" class="issue-link" data-issue-key="LU-15860"><del>LU-15860</del></a> socklnd: Duplicate ksock_conn_cb<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1feb1708ac65b2aa89d20a06988734d2ff807ec7</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/47361/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/47361/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15860" title="ksocknal_add_peer() race results in extra ksock_conn_cb" class="issue-link" data-issue-key="LU-15860"><del>LU-15860</del></a> socklnd: Duplicate ksock_conn_cb<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 0c91d49a44e1214b5c65d4a557f6969b3d217881</p> <p>Landed for 2.16</p> <p>"James Simmons &lt;jsimmons@infradead.org&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/48911" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/48911</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15860" title="ksocknal_add_peer() race results in extra ksock_conn_cb" class="issue-link" data-issue-key="LU-15860"><del>LU-15860</del></a> socklnd: Duplicate ksock_conn_cb<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: 1<br/> Commit: 04d225733104ad973fc4da82e9e4c8eed4677d8a</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/48911/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/48911/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15860" title="ksocknal_add_peer() race results in extra ksock_conn_cb" class="issue-link" data-issue-key="LU-15860"><del>LU-15860</del></a> socklnd: Duplicate ksock_conn_cb<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: <br/> Commit: ea34ee7b40271ec23b6d9ed916a43971dd73fad5</p> Development Rank 1|i02q4f: Rank (Obsolete) 9223372036854775807 Severity