https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-15928 Lustre <p>With fscrypt passing binary names to the underlying ldiskfs storage, the lookup API should be passing the length of the key through the DT index API instead of calling <tt>strlen()</tt> on the string, otherwise this may incorrectly process keys with embedded NUL bytes.</p> LU-15928

pass key length as part of index API

Bug Minor Open Unresolved Sebastien Buisson Andreas Dilger Fri, 10 Jun 2022 19:36:54 +0000 Tue, 14 Jun 2022 06:47:33 +0000 Lustre 2.15.0 0 3 <p>"Andreas Dilger &lt;adilger@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/47624" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/47624</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15928" title="pass key length as part of index API" class="issue-link" data-issue-key="LU-15928">LU-15928</a> osd: pass keylen for dt index operations<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: f88b3fb915f3f0a56da562885db38a8f515260a3</p> <p>Sebastien, I started on this patch but haven't had time to finish it off. I think this is needed to handle binary names properly.</p> <p>Actually, in order to avoid this large change in the DT index API as part of the <a href="https://jira.whamcloud.com/browse/LU-13717" title="Client-side encryption - support file name encryption" class="issue-link" data-issue-key="LU-13717"><del>LU-13717</del></a> series, I had decided to critical encode the names of encrypted files passed from client to server. This escapes NULL, LF, CR, /, DEL and = characters, so that using <tt>strlen</tt> is safe.</p> <p>So the code is sane as it is today. But passing the length of the key through the DT index API instead of calling <tt>strlen</tt> on the string seems to be a better longer term option. And that would avoid the need to critical encode names on client side before the request is sent, just to critical decode those names on server side upon request receive. Unless the ptlrpc layer requires buffers put in the requests to be nul terminated?</p> Related LU-13717 Development Rank 1|i02rvj: Rank (Obsolete) 9223372036854775807 Severity