https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-15986 Lustre <p>Two execution paths about req-&gt;rq_repmsg:</p> <p>Path 1 happens when server receives a resent request:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> ptlrpc_main()-&gt; ptlrpc_server_handle_req_in()-&gt;ptlrpc_server_request_add()-&gt;ptlrpc_server_check_resend_in_progress()-&gt;_debug_req(tmp)</pre> </div></div> <p>Path 2 happens when server sends reply and drop the rs:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> ptlrpc_server_finish_request()-&gt;ptlrpc_server_drop_request()-&gt;ptlrpc_server_free_request()-&gt;ptlrpc_req_drop_rs()</pre> </div></div> <p> req-&gt;rq_repmsg is not protected well in <tt>ptlrpc_req_drop_rs()</tt></p> LU-15986

Race condition between _debug_req() and ptlrpc_req_drop_rs()

Bug Critical Resolved Fixed Feng Lei Feng Lei Thu, 30 Jun 2022 01:30:31 +0000 Tue, 22 Nov 2022 13:47:35 +0000 Sat, 24 Sep 2022 23:33:14 +0000 Lustre 2.16.0 Lustre 2.15.2 0 7 <p>"Feng, Lei &lt;flei@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/47839" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/47839</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15986" title="Race condition between _debug_req() and ptlrpc_req_drop_rs()" class="issue-link" data-issue-key="LU-15986"><del>LU-15986</del></a> ptlrpc: protect rq_repmsg in ptlrpc_req_drop_rs()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 05f38bf79b585f8c13d741d30f487437b413ad3b</p> <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=flei" class="user-hover" rel="flei">flei</a> are the test failures on the master patch due to the patch itself?</p> <p>I don't think so. <a href="https://jira.whamcloud.com/browse/LU-16100" title="sanity test_51d: 0 dirstripes" class="issue-link" data-issue-key="LU-16100"><del>LU-16100</del></a> to track it.</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/47839/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/47839/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15986" title="Race condition between _debug_req() and ptlrpc_req_drop_rs()" class="issue-link" data-issue-key="LU-15986"><del>LU-15986</del></a> ptlrpc: protect rq_repmsg in ptlrpc_req_drop_rs()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: aaef545cff2dd958418ec9fb364d4bbe1408edb9</p> <p>Landed for 2.16</p> <p>"Xing Huang &lt;hxing@ddn.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49157" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49157</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15986" title="Race condition between _debug_req() and ptlrpc_req_drop_rs()" class="issue-link" data-issue-key="LU-15986"><del>LU-15986</del></a> ptlrpc: protect rq_repmsg in ptlrpc_req_drop_rs()<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: 1<br/> Commit: 9aecd005de286162dc4ff9d3a5bc12b6076582f1</p> <p>"Xing Huang &lt;hxing@ddn.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49158" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49158</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15986" title="Race condition between _debug_req() and ptlrpc_req_drop_rs()" class="issue-link" data-issue-key="LU-15986"><del>LU-15986</del></a> ptlrpc: protect rq_repmsg in ptlrpc_req_drop_rs()<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: 74ef48e7c6e86f2d4a3c5dcce5c8387f3f89e6e8</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49157/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49157/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15986" title="Race condition between _debug_req() and ptlrpc_req_drop_rs()" class="issue-link" data-issue-key="LU-15986"><del>LU-15986</del></a> ptlrpc: protect rq_repmsg in ptlrpc_req_drop_rs()<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: <br/> Commit: b9df7a08de6d119302be7bbe6b53061caa3ad758</p> Duplicate Related Development Rank 1|i02thj: Rank (Obsolete) 9223372036854775807 Severity