https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-16060 Lustre <p>e2fsck errors seen after racer test:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Symlink /REMOTE_PARENT_DIR/0x20000a73a:0xb116:0x0/CL_racer_long_01/13 (inode #275636774) is invalid. Clear? no Inode 275636774 is badly corrupt (badness value = 32767). Clear? no Symlink /REMOTE_PARENT_DIR/0x20000a73a:0xb116:0x0/CL_racer_long_01/3 (inode #275636742) is invalid. Clear? no Inode 275636742 is badly corrupt (badness value = 32767). Clear? no Symlink /REMOTE_PARENT_DIR/0x20000a73a:0xb116:0x0/CL_racer_long_01/5 (inode #275636773) is invalid. Clear? no Inode 275636773 is badly corrupt (badness value = 32767). Clear? no Symlink /REMOTE_PARENT_DIR/0x20000a73a:0xb116:0x0/CL_racer_long_01/7 (inode #275636821) is invalid. Clear? no Inode 275636821 is badly corrupt (badness value = 32767). Clear? no </pre> </div></div> <p>Also</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Inode 275636742 symlink missing NUL terminator. Fix? no Inode 275636743 symlink missing NUL terminator. Fix? no Inode 275636772 symlink missing NUL terminator. Fix? no Inode 275636773 symlink missing NUL terminator. Fix? no Inode 275636774 symlink missing NUL terminator. Fix? no Inode 275636793 symlink missing NUL terminator. Fix? no Inode 275636813 symlink missing NUL terminator. Fix? no Inode 275636821 symlink missing NUL terminator. Fix? no Inode 275636826 symlink missing NUL terminator. Fix? no Inode 275636827 symlink missing NUL terminator. Fix? no </pre> </div></div> LU-16060

e2fsck reported "symlink missing NUL terminator" errors

Bug Major Resolved Fixed Alexander Zarochentsev Alexander Zarochentsev Sat, 30 Jul 2022 16:12:04 +0000 Thu, 19 Oct 2023 14:58:06 +0000 Fri, 19 Aug 2022 15:56:26 +0000 Lustre 2.16.0 Lustre 2.15.4 0 3 <p>"Alexander Zarochentsev &lt;alexander.zarochentsev@hpe.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/48092" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/48092</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16060" title="e2fsck reported &quot;symlink missing NUL terminator&quot; errors" class="issue-link" data-issue-key="LU-16060"><del>LU-16060</del></a> osd-ldiskfs: copy nul byte terminator in writelink<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 36b0e0f38c0ad50d8c1cae2089ab83728c2665d3</p> <p>This doesn't seem like a new bug. I'm pretty certain that there was a patch for e2fsck to fix this problem many years ago, and it was supposed to be phased out once osd-ldiskfs worked the same way that ext4 did. It looks like that is <a href="https://review.whamcloud.com/3560" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/3560</a> "<tt><a href="https://jira.whamcloud.com/browse/LU-1540" title="e2fsck remove too many symlinks" class="issue-link" data-issue-key="LU-1540"><del>LU-1540</del></a> osd: add NUL terminator for long symlink</tt>".</p> <p>What version of e2fsck is generating these errors? It should be handling this Is it possible that it is missing the above patch? I do recall thinking about removing this patch from the 1.46.5-wc1 rebase, but it looks like it is still in my patch series, and that rebase has not yet been landed.</p> <p>&gt; This doesn't seem like a new bug.</p> <p>Yes, it is. The new issue is about "fast" symlinks, <a href="https://jira.whamcloud.com/browse/LU-1540" title="e2fsck remove too many symlinks" class="issue-link" data-issue-key="LU-1540"><del>LU-1540</del></a> is for long symlinks. <br/> The issue is not seen till Lustre started to use extents for MDT partitions. W/o extents,<br/> i_data gets cleared by ext4_new_inode(). But, if extents are used, i_data gets initialized by an ext4 extent structure, so symlink target string needs to be explicitly terminated by NUL byte, for short symlinks overlapping the initial ext4 extent struct.</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/48092/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/48092/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16060" title="e2fsck reported &quot;symlink missing NUL terminator&quot; errors" class="issue-link" data-issue-key="LU-16060"><del>LU-16060</del></a> osd-ldiskfs: copy nul byte terminator in writelink<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 907dc0a2d333f2df2d654a968fc50f8cc05b779d</p> <p>Landed for 2.16</p> <p>"Etienne AUJAMES &lt;eaujames@ddn.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/48280" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/48280</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16060" title="e2fsck reported &quot;symlink missing NUL terminator&quot; errors" class="issue-link" data-issue-key="LU-16060"><del>LU-16060</del></a> osd-ldiskfs: copy nul byte terminator in writelink<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: 805ded51e0db8256f942e2105ad21abda608106d</p> <p>"Etienne AUJAMES &lt;eaujames@ddn.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51356" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51356</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16060" title="e2fsck reported &quot;symlink missing NUL terminator&quot; errors" class="issue-link" data-issue-key="LU-16060"><del>LU-16060</del></a> osd-ldiskfs: copy nul byte terminator in writelink<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: 1<br/> Commit: dca31aec8847d7b27f9c2fb2f0142db6f2a6a7b5</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51356/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51356/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16060" title="e2fsck reported &quot;symlink missing NUL terminator&quot; errors" class="issue-link" data-issue-key="LU-16060"><del>LU-16060</del></a> osd-ldiskfs: copy nul byte terminator in writelink<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: <br/> Commit: d1f0ef129d8e9af13c31dc821a00639de3349873</p> Related LU-1540 Development Rank 1|i02vun: Rank (Obsolete) 9223372036854775807 Severity