https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-16335 Lustre <p>In <a href="https://jira.whamcloud.com/browse/LU-16159" title="remove update logs after recovery abort" class="issue-link" data-issue-key="LU-16159">LU-16159</a>, update logs are canceled upon recovery abort, which may leave some directories broken, and can't be removed by "lfs rm_entry". This is because "lfs rm_entry" failed some sanity check, but it will leave end-user a broken filesystem without any way to fix.</p> LU-16335

"lfs rm_entry" failed to remove broken directories

Bug Minor Resolved Fixed Lai Siyao Lai Siyao Wed, 23 Nov 2022 07:04:28 +0000 Mon, 8 Jan 2024 03:33:17 +0000 Thu, 19 Jan 2023 20:48:25 +0000 Lustre 2.16.0 Lustre 2.15.3 0 8 <p>config.log show this:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>configure:39672: result: no configure:39682: checking if ioctl IOC_REMOVE_ENTRY' is supported configure:39696: gcc -c -g -O2 -Werror -I/home/laisiyao/lustre/lnet/include/uapi -I/home/laisiyao/lustre/lustre/include/uapi -I/home/laisiyao/lustre/libcfs/include -I/home/laisiyao/lustre/lnet/utils/ -I/home/laisiyao/lustre/lustre/include  conftest.c &gt;&amp;5 In file included from /home/laisiyao/lustre/lustre/include/uapi/linux/lustre/lustre_idl.h:74,                  from /home/laisiyao/lustre/lustre/include/uapi/linux/lustre/lustre_ioctl.h:34,                  from conftest.c:253: /home/laisiyao/lustre/lustre/include/uapi/linux/lustre/lustre_user.h: In function 'changelog_rec_sname': /home/laisiyao/lustre/lustre/include/uapi/linux/lustre/lustre_user.h:2012:9: error: implicit declaration of function 'strchrnul'; did you mean 'strchr'? [-Werror=implicit-function-declaration]   return strchrnul(changelog_rec_name(rec), '\0') + 1;          ^~~~~~~~~          strchr /home/laisiyao/lustre/lustre/include/uapi/linux/lustre/lustre_user.h:2012:50: error: returning 'int' from a function with return type 'char *' makes pointer from integer without a cast [-Werror=int-conversion]   return strchrnul(changelog_rec_name(rec), '\0') + 1;          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ cc1: all warnings being treated as errors configure:39696: $? = 1 configure: failed program was: </pre> </div></div> <p>This check is from <a href="https://review.whamcloud.com/39207" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39207</a>, and it causes "lfs rm_entry" always returns -ENOTSUP, which should be the cause of broken directory unlink fail.</p> <p>strchrnul() needs define _GNU_SOURCE, adding it in the check can solve the issue.</p> <p>"Lai Siyao &lt;lai.siyao@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49328" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49328</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16335" title="&quot;lfs rm_entry&quot; failed to remove broken directories" class="issue-link" data-issue-key="LU-16335"><del>LU-16335</del></a> build: strchrnul() needs define _GNU_SOURCE<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: f5f31fa51477c7091a5af7fbb95382cd87d97938</p> <p>"Lai Siyao &lt;lai.siyao@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49329" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49329</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16335" title="&quot;lfs rm_entry&quot; failed to remove broken directories" class="issue-link" data-issue-key="LU-16335"><del>LU-16335</del></a> mdt: skip child check for rm_entry<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 2cc5c2bfed10f2d63ee767cf90d77fb16e08e366</p> <p><del>"Lai Siyao &lt;lai.siyao@whamcloud.com&gt;" uploaded a new patch:</del> <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49334" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49334</a><br/> <del>Subject: <a href="https://jira.whamcloud.com/browse/LU-16335" title="&quot;lfs rm_entry&quot; failed to remove broken directories" class="issue-link" data-issue-key="LU-16335"><del>LU-16335</del></a> header: implement native strchrnul()</del><br/> <del>Project: fs/lustre-release</del><br/> <del>Branch: master</del><br/> <del>Current Patch Set: 1</del><br/> <del>Commit: bc03636059c5c2dc9a0f1030af83309aedc94ac0</del></p> <p>"Lai Siyao &lt;lai.siyao@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49335" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49335</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16335" title="&quot;lfs rm_entry&quot; failed to remove broken directories" class="issue-link" data-issue-key="LU-16335"><del>LU-16335</del></a> test: add fail_abort_cleanup()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 243ffa00d0a4353c78ee8b73bdce0e1c60bdc5da</p> <p>So we disable various test for the native client since lfs rm_dentry was removed upstream. Its considered a security risk. Does this mean lfsck can repair the file system?</p> <p>In theory lfsck should fix these inconsistencies, but it's not fully tested, and <a href="https://jira.whamcloud.com/browse/LU-16159" title="remove update logs after recovery abort" class="issue-link" data-issue-key="LU-16159">LU-16159</a> test result shows some are not fixed, and it will be addressed in <a href="https://jira.whamcloud.com/browse/LU-16336" title="LFSCK should fix inconsistencies caused by recovery abort" class="issue-link" data-issue-key="LU-16336">LU-16336</a>.</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49328/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49328/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16335" title="&quot;lfs rm_entry&quot; failed to remove broken directories" class="issue-link" data-issue-key="LU-16335"><del>LU-16335</del></a> build: remove _GNU_SOURCE dependency in lustre_user.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: efc5c8d4de60d394344506f7cfb188eaf04a4bac</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49335/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49335/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16335" title="&quot;lfs rm_entry&quot; failed to remove broken directories" class="issue-link" data-issue-key="LU-16335"><del>LU-16335</del></a> test: add fail_abort_cleanup()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: d5fe41a02a6ed57bcbfc4a4c695bb509c9c7c313</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49329/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49329/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16335" title="&quot;lfs rm_entry&quot; failed to remove broken directories" class="issue-link" data-issue-key="LU-16335"><del>LU-16335</del></a> mdt: skip target check for rm_entry<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: ae98c5fdaaf37daeb328b7110cbcf42754752c9d</p> <p>Landed for 2.16</p> <p>"Jian Yu &lt;yujian@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49776" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49776</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16335" title="&quot;lfs rm_entry&quot; failed to remove broken directories" class="issue-link" data-issue-key="LU-16335"><del>LU-16335</del></a> build: remove _GNU_SOURCE dependency in lustre_user.h<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: 1<br/> Commit: 11d59e1f9407f8545172b00a23a34385366b4fe6</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49776/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49776/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16335" title="&quot;lfs rm_entry&quot; failed to remove broken directories" class="issue-link" data-issue-key="LU-16335"><del>LU-16335</del></a> build: remove _GNU_SOURCE dependency in lustre_user.h<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: <br/> Commit: 8a8747d319aa3f91674b156c79d44cbc092ee175</p> <p>"Etienne AUJAMES &lt;eaujames@ddn.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51237" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51237</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16335" title="&quot;lfs rm_entry&quot; failed to remove broken directories" class="issue-link" data-issue-key="LU-16335"><del>LU-16335</del></a> test: add fail_abort_cleanup()<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: 1<br/> Commit: 2e35cdf5abe712084351d92f2b4feb99b98da08c</p> Blocker Related LU-16336 LU-16159 LU-16398 Development Rank 1|i036d3: Rank (Obsolete) 9223372036854775807 Severity