https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-16427 Lustre <p>The "<tt>lfs rmfid</tt>" does not print anything useful or exit with a non-zero error code when passed bad arguments:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># lfs rmfid --help # lfs rmfid foo # echo $? 0 </pre> </div></div> <p>It would make sense to handle "<tt>--help</tt>" to print the usage message, and should print an error and the usage message if a bad filesystem name/mountpoint argument is given or if a bad FID is passed (though it should continue to process all remaining FIDs on the command-line and exit with an error at the end).</p> LU-16427

'lfs rmfid' does not print anything on error

Bug Minor Resolved Fixed Arshad Hussain Andreas Dilger easy Thu, 22 Dec 2022 17:49:20 +0000 Mon, 1 May 2023 06:29:03 +0000 Mon, 1 May 2023 06:29:03 +0000 Lustre 2.16.0 0 4 <p>I have been looking into this and have found that `rmfid` also appears completely nonfunctional when used within the "lfs shell". Here's what I mean:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> $ lfs lfs &gt; rmfid /mnt/mylustre [0x200000407:0xcc:0x0] unrecognized FID: /mnt/mylustre lfs &gt; rmfid [0x200000407:0xcc:0x0] lfs rmfid: cannot remove FIDs: Bad file descriptor </pre> </div></div> <p>I'm guessing that lfs is not commonly used in this way, but is this shell considered supported and should be working? Should this be fixed as part of this bug? </p> <p> </p> <p>One challenge with printing out good error messages here is that I don't think the current API of <tt>llapi_rmfid()</tt> provides a good way to distinguish an error in opening the filesystem directory vs. an error with the <tt>ioctl()</tt>.</p> <p>A nonexistent filesystem path should result in <tt>llapi_rmfid()</tt> returning -<tt>ENOENT,</tt> I think (although currently it returns <tt>-EBAD</tt>F), and while the <tt>ioctl()</tt> won't return <tt>-ENOENT</tt> from what I can tell, I don't know that it will <b>never</b> return <tt>-ENOENT</tt>.</p> <p>One solution would be to create a function <tt>llapi_rmfid_at()</tt> that takes an FD open to the lustre mountpoint as the 1st argument so that the caller can validate the mountpoint, similar to <tt>lfs_fid2path()</tt> and <tt>llapi_fid2path_at()</tt>. (Or just modify <tt>llapi_rmfid()</tt>, although this would be a breaking API change.) This change would allow for clearer error messages from <tt>lfs rmfid</tt>, IMO. Do you have any thoughts on this idea?</p> <p>Andreas/Thomas,</p> <p>I am already working on rmfid issues. (See below) you want me to pick up this LU?</p> <p>Thanks</p> <p><a href="https://review.whamcloud.com/c/fs/lustre-release/+/50367" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50367</a></p> <p> </p> <p><a href="https://jira.whamcloud.com/browse/LU-16618" title="rmfid miscellaneous fixes" class="issue-link" data-issue-key="LU-16618">LU-16618</a> lfs: rmfid miscellaneous fixes</p> <p>This patch fixes:</p> <p>01. Fix rmfid silently accepting fid without fsname<br/> or lustre root mount point. Make it correctly<br/> fail if required arguments is not provided.</p> <p>After Patch:<br/> ~~~~~~~~~~~~<br/> $ lfs rmfid 0x200000402:0x1:0x0<br/> lfs rmfid: missing &lt;fsname|rootpath&gt; or &lt;fid&gt;<br/> Remove file(s) by FID(s)<br/> usage: rmfid &lt;fsname|rootpath&gt; &lt;fid&gt; ...</p> <p>Before Patch:<br/> ~~~~~~~~~~~~<br/> $ lfs rmfid 0x200000402:0x1:0x0<br/> ${noformat}</p> <p>"Arshad Hussain &lt;arshad.hussain@aeoncomputing.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50388" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50388</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16427" title="&#39;lfs rmfid&#39; does not print anything on error" class="issue-link" data-issue-key="LU-16427"><del>LU-16427</del></a> lfs: rmfid does not print anything on error<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 83add47417cfca6600336ae7d890125a513cee94</p> <p>@Arshad sorry, I did not realize you were already working on this one! I'll be happy to review your patch if desired.</p> <p>@Thomas, no worries and thanks for your review. Even I realized much later that this ticke was open much earlier by Andreas. It was missed by me. I started working on rmfid when I accidentally stumbled upon its error.</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50388/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50388/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16427" title="&#39;lfs rmfid&#39; does not print anything on error" class="issue-link" data-issue-key="LU-16427"><del>LU-16427</del></a> lfs: rmfid does not print anything on error<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 5d930252407cc11604c4b9de2984784c62c43a4c</p> <p>Landed for 2.16</p> Related LU-16618 LU-14469 Development Rank 1|i038kv: Rank (Obsolete) 9223372036854775807 Severity