https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-16463 Lustre <p>llapi_open_by_fid() uses open_by_handle_at() since <a href="https://review.whamcloud.com/36603" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36603</a> ("<a href="https://jira.whamcloud.com/browse/LU-8585" title="All Lustre test suites should pass with subdirectory mount" class="issue-link" data-issue-key="LU-8585">LU-8585</a> llapi: use open_by_handle_at in llapi_open_by_fid"). But handle are used by NFS and cache open in that case to limit the number of open-close (close are sent to MDT only on lock conflict or cache shrinks, <a href="http://review.whamcloud.com/20354" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/20354</a>).</p> <p>This breaks the llsom_sync util, because it used llapi_open_by_fid and "trusted.som" xattrs are synchronized on close requests:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[root@client client]# touch test [root@client client]# dd if=/dev/zero of=test bs=1M count=1 1+0 records in 1+0 records out 1048576 bytes (1.0 MB) copied, 0.00145669 s, 720 MB/s [root@client client]# lfs getsom test &amp;&amp; stat test file: test size: 1048576 blocks: 0 flags: 4 File: ‘test’ Size: 1048576 Blocks: 2048 IO Block: 4194304 regular file Device: 481510a2h/1209340066d Inode: 144115205507383305 Links: 1 Access: (0644/-rw-r--r--) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2023-01-12 11:22:03.000000000 +0100 Modify: 2023-01-12 11:22:07.000000000 +0100 Change: 2023-01-12 11:22:07.000000000 +0100 Birth: - [root@client client]# cat test [root@client client]# lfs getsom test &amp;&amp; stat test file: test size: 1048576 blocks: 2048 flags: 4 &lt;---- updated File: ‘test’ Size: 1048576 Blocks: 2048 IO Block: 4194304 regular file Device: 481510a2h/1209340066d Inode: 144115205507383305 Links: 1 Access: (0644/-rw-r--r--) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2023-01-12 11:22:27.000000000 +0100 Modify: 2023-01-12 11:22:07.000000000 +0100 Change: 2023-01-12 11:22:07.000000000 +0100 Birth: - [root@client client]# dd if=/dev/zero of=test bs=1M count=2 conv=notrunc 2+0 records in 2+0 records out 2097152 bytes (2.1 MB) copied, 0.00210231 s, 998 MB/s [root@client client]# lfs getsom test &amp;&amp; stat test file: test size: 2097152 blocks: 2048 flags: 4 File: ‘test’ Size: 2097152 Blocks: 4096 IO Block: 4194304 regular file Device: 481510a2h/1209340066d Inode: 144115205507383305 Links: 1 Access: (0644/-rw-r--r--) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2023-01-12 11:22:27.000000000 +0100 Modify: 2023-01-12 11:23:02.000000000 +0100 Change: 2023-01-12 11:23:02.000000000 +0100 Birth: - [root@client client]# llsom_sync -u cl11 -m lustrefs-MDT0000 /media/lustrefs/client Start to sync 1 records. [root@client client]# lfs getsom test &amp;&amp; stat test file: test size: 2097152 blocks: 2048 flags: 4 &lt;---- not updated File: ‘test’ Size: 2097152 Blocks: 4096 IO Block: 4194304 regular file Device: 481510a2h/1209340066d Inode: 144115205507383305 Links: 1 Access: (0644/-rw-r--r--) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2023-01-12 11:22:27.000000000 +0100 Modify: 2023-01-12 11:23:02.000000000 +0100 Change: 2023-01-12 11:23:02.000000000 +0100 Birth: - [root@client client]# cat test [root@client client]# lfs getsom test &amp;&amp; stat test file: test size: 2097152 blocks: 2048 flags: 4 &lt;---- not updated File: ‘test’ Size: 2097152 Blocks: 4096 IO Block: 4194304 regular file Device: 481510a2h/1209340066d Inode: 144115205507383305 Links: 1 Access: (0644/-rw-r--r--) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2023-01-12 11:24:29.000000000 +0100 Modify: 2023-01-12 11:23:02.000000000 +0100 Change: 2023-01-12 11:23:02.000000000 +0100 Birth: - </pre> </div></div> <p>This is not seen by "sanity test 807" because <a href="https://review.whamcloud.com/32158" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32158</a> "<a href="https://jira.whamcloud.com/browse/LU-10948" title="client cache open lock after N opens" class="issue-link" data-issue-key="LU-10948">LU-10948</a> llite: Introduce inode open heat counter" clears lock caches before calling "lfs getsom" (in check_lsom_data/check_lsom_size).</p> LU-16463

llapi_open_by_fid open should not be cached systematically

Bug Minor Resolved Fixed Etienne Aujames Etienne Aujames Thu, 12 Jan 2023 10:34:36 +0000 Mon, 3 Jul 2023 13:53:28 +0000 Thu, 23 Feb 2023 13:28:06 +0000 Lustre 2.16.0 0 4 <p>Can you try patch <a href="https://review.whamcloud.com/#/c/fs/lustre-release/+/49237" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/fs/lustre-release/+/49237</a></p> <blockquote> <p>Can you try patch <a href="https://review.whamcloud.com/#/c/fs/lustre-release/+/49237" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/fs/lustre-release/+/49237</a></p></blockquote> <p>I have read the patch, that should work.<br/> I was working on the following patch to avoid caching opens only for llapi_open_by_fid().</p> <p>"Etienne AUJAMES &lt;eaujames@ddn.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49616" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49616</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16463" title="llapi_open_by_fid open should not be cached systematically" class="issue-link" data-issue-key="LU-16463"><del>LU-16463</del></a> llite: fix the opencache for llapi_open_by_fid()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 49d440cd9132d799a98e3264494015e3faaa4fba</p> <p>Personally I like to see us move away from opencache since its rarely needed anymore. Let me update my patch. Now I don't like your idea of using a flag I could see passing in an open count limit. By default it would be zero but it would allow the user to cache the open if they wanted after a certain open count. That would be powerful.</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49237/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49237/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16463" title="llapi_open_by_fid open should not be cached systematically" class="issue-link" data-issue-key="LU-16463"><del>LU-16463</del></a> llite: replace lld_nfs_dentry flag with opencache handling<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: d7a85652f4fcb83192262cfc1a0211890f404c7c</p> <p>Landed for 2.16</p> <p>"Etienne AUJAMES &lt;eaujames@ddn.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51540" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51540</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16463" title="llapi_open_by_fid open should not be cached systematically" class="issue-link" data-issue-key="LU-16463"><del>LU-16463</del></a> llite: replace lld_nfs_dentry flag with opencache handling<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: 1<br/> Commit: 8851053466b545039d6719a39d9726066c651b82</p> Related LU-8585 LU-10948 Development Rank 1|i039q7: Rank (Obsolete) 9223372036854775807 Severity