https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-16517 Lustre <p>run 'make debs' to build debs for Ubuntu</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>root@u0:~/lustre-release# sh ./autogen.sh; ./configure --disable-lru-resize --with-o2ib=/usr/src/ofa_kernel/default ; make debs </pre> </div></div> <p>But, configure restarts and pick some options, but ignores user defined build options. e.g. '--disable-lru-resize ' above</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>touch configure-stamp Final value of EXTRAFLAGS: --disable-server --without-zfs --disable-ldiskfs --with-o2ib=/usr/src/ofa_kernel/5.4.0-137-generic --disable-gss checking build system type... x86_64-pc-linux-gnu checking host system type... x86_64-pc-linux-gnu checking target system type... x86_64-pc-linux-gnu checking for a BSD-compatible install... /usr/bin/install -c </pre> </div></div> <p>In the end, packages were built with missing build options.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>root@u0:~/lustre-release# cat config.log This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. It was created by Lustre configure 2.14.0_ddn74, which was generated by GNU Autoconf 2.69. Invocation command line was $ ./configure --disable-dependency-tracking --with-linux=/lib/modules/5.4.0-137-generic/build --with-linux-obj=/usr/src/linux-headers-5.4.0-1 37-generic --disable-snmp --enable-quota --disable-server --without-zfs --disable-ldiskfs --with-o2ib=/usr/src/ofa_kernel/5.4.0-137-generic --d isable-gss --with-o2ib=/usr/src/ofa_kernel/5.4.0-137-generic </pre> </div></div> LU-16517

'make debs' ignores extra build options

Bug Minor Resolved Fixed Jian Yu Shuichi Ihara Mon, 30 Jan 2023 23:08:47 +0000 Thu, 19 Oct 2023 15:14:29 +0000 Fri, 9 Jun 2023 12:27:27 +0000 Lustre 2.15.2 Lustre 2.16.0 Lustre 2.15.4 0 6 <p>In debian/rules, the configure command is defined as follows:</p> <div class="code panel" style="border-width: 1px;"><div class="codeHeader panelHeader" style="border-bottom-width: 1px;"><b>debian/rules</b></div><div class="codeContent panelContent"> <pre class="code-java"> $(SRCDIR)/configure --disable-dependency-tracking \ --with-linux=$${KERNEL_SRC} \ --with-linux-obj=$${KERNEL_OBJ} \ --disable-snmp \ --enable-quota \ $${EXTRAFLAGS} \ $(EXTRA_OPTIONS) \ </pre> </div></div> <p>The EXTRA_OPTIONS is defined with IB_OPTIONS, which is "--with-o2ib=xx".<br/> Other configure options are specified by EXTRAFLAGS, which is detected in debian/rules by checking DEB_BUILD_PROFILES as follows:</p> <div class="code panel" style="border-width: 1px;"><div class="codeHeader panelHeader" style="border-bottom-width: 1px;"><b>debian/rules</b></div><div class="codeContent panelContent"> <pre class="code-java"> echo <span class="code-quote">"Enabled Build Profiles: $${DEB_BUILD_PROFILES}"</span> <span class="code-keyword">if</span> echo <span class="code-quote">"$${DEB_BUILD_PROFILES}"</span> | grep -q <span class="code-quote">"server"</span>; then \ export EXTRAFLAGS=<span class="code-quote">"--enable-server"</span>; \ &lt;~snip~&gt; <span class="code-keyword">else</span> \ export EXTRAFLAGS=<span class="code-quote">"--disable-server"</span>; \ &lt;~snip~&gt; fi; \ <span class="code-keyword">if</span> echo <span class="code-quote">"$${DEB_BUILD_PROFILES}"</span> | grep -q <span class="code-quote">"zfs"</span>; then \ export EXTRAFLAGS=<span class="code-quote">"$${EXTRAFLAGS} --with-zfs=$${ZFS_SRC} --with-spl=$${SPL_SRC}"</span>; \ <span class="code-keyword">else</span> \ export EXTRAFLAGS=<span class="code-quote">"$${EXTRAFLAGS} --without-zfs"</span> ; \ fi; \ &lt;~snip~&gt; export EXTRAFLAGS=<span class="code-quote">"$${EXTRAFLAGS} --enable-ldiskfs --enable-quilt"</span>; \ &lt;~snip~&gt; export EXTRAFLAGS=<span class="code-quote">"$${EXTRAFLAGS} --disable-ldiskfs"</span>; \ &lt;~snip~&gt; export EXTRAFLAGS=<span class="code-quote">"$${EXTRAFLAGS} --with-o2ib=$${O2IB_SRC}"</span>; \ &lt;~snip~&gt; export EXTRAFLAGS=<span class="code-quote">"$${EXTRAFLAGS} --enable-gss"</span>; \ &lt;~snip~&gt; export EXTRAFLAGS=<span class="code-quote">"$${EXTRAFLAGS} --disable-gss"</span>; \ &lt;~snip~&gt; export EXTRAFLAGS=<span class="code-quote">"$${EXTRAFLAGS} --enable-crypto"</span>; \ &lt;~snip~&gt; export EXTRAFLAGS=<span class="code-quote">"$${EXTRAFLAGS} --disable-crypto"</span>; \ &lt;~snip~&gt; export EXTRAFLAGS=<span class="code-quote">"$${EXTRAFLAGS} --cache-file=$${TMP_CACHE_FILE}"</span>; \ </pre> </div></div> <p>DEB_BUILD_PROFILES is defined and exported in autoMakefile.am under debs target as follows:</p> <div class="code panel" style="border-width: 1px;"><div class="codeHeader panelHeader" style="border-bottom-width: 1px;"><b>autoMakefile.am</b></div><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">if</span> test <span class="code-quote">"x@ENABLE_SERVER@"</span> = <span class="code-quote">"xyes"</span>; then \ DEB_BUILD_PROFILES=<span class="code-quote">"server"</span>; \ <span class="code-keyword">else</span> \ DEB_BUILD_PROFILES=<span class="code-quote">"client"</span>; \ fi; \ <span class="code-keyword">if</span> test <span class="code-quote">"x@ENABLE_LDISKFS@"</span> = <span class="code-quote">"xyes"</span>; then \ export DEB_BUILD_PROFILES=<span class="code-quote">"$${DEB_BUILD_PROFILES} ldiskfs"</span>; \ fi; \ <span class="code-keyword">if</span> test <span class="code-quote">"x@ENABLE_ZFS@"</span> = <span class="code-quote">"xyes"</span>; then \ export DEB_BUILD_PROFILES=<span class="code-quote">"$${DEB_BUILD_PROFILES} zfs"</span>; \ &lt;~snip~&gt; fi; \ <span class="code-keyword">if</span> test <span class="code-quote">"x@ENABLEO2IB@"</span> != <span class="code-quote">"xno"</span>; then \ export DEB_BUILD_PROFILES=<span class="code-quote">"$${DEB_BUILD_PROFILES} o2ib"</span>; \ export O2IB_SRC=<span class="code-quote">"@O2IBPATH@"</span>; \ fi; \ <span class="code-keyword">if</span> test <span class="code-quote">"x@CONFIG_CACHE_FILE@"</span> != <span class="code-quote">"x"</span>; then \ export CONFIG_CACHE_FILE=<span class="code-quote">"@CONFIG_CACHE_FILE@"</span>; \ fi; \ <span class="code-keyword">if</span> test <span class="code-quote">"x@ENABLE_GSS@"</span> = <span class="code-quote">"xyes"</span>; then \ export DEB_BUILD_PROFILES=<span class="code-quote">"$${DEB_BUILD_PROFILES} gss"</span>; \ &lt;~snip~&gt; export DEB_BUILD_PROFILES=<span class="code-quote">"$${DEB_BUILD_PROFILES} nogss"</span>; \ &lt;~snip~&gt; export DEB_BUILD_PROFILES=<span class="code-quote">"$${DEB_BUILD_PROFILES} crypto"</span>; \ &lt;~snip~&gt; export DEB_BUILD_PROFILES=<span class="code-quote">"$${DEB_BUILD_PROFILES} nocrypto"</span>; \ &lt;~snip~&gt; export DEB_BUILD_PROFILES=<span class="code-quote">"$${DEB_BUILD_PROFILES} systemd"</span>; \ </pre> </div></div> <p>The ENABLE_xxx variables are defined in config/&#42;.m4 files by checking enable_xxx variables, which are defined while running user specified configure command before running "make debs".</p> <p>As we can see, not all of the configure options are detected and passed to the configure command in debian/rules while running "make debs".<br/> I'm trying to figure out which ones are needed to be added into lustre/autoconf/&#42;.m4, config/&#42;.m4, autoMakefile.am and debian/rules. </p> <p>"Jian Yu &lt;yujian@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50464" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50464</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16517" title="&#39;make debs&#39; ignores extra build options" class="issue-link" data-issue-key="LU-16517"><del>LU-16517</del></a> build: pass extra configure options to "make debs"<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: ea176510f349bebdcf754bb645e7be12617465e9</p> <p>"Jian Yu &lt;yujian@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51178" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51178</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16517" title="&#39;make debs&#39; ignores extra build options" class="issue-link" data-issue-key="LU-16517"><del>LU-16517</del></a> build: pass extra configure options to "make debs"<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: 1<br/> Commit: 20f24f6238c4b2a0b4160ad6674ac8c61332f6e7</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50464/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50464/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16517" title="&#39;make debs&#39; ignores extra build options" class="issue-link" data-issue-key="LU-16517"><del>LU-16517</del></a> build: pass extra configure options to "make debs"<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 3989529f22f5c54a98e445674b4b3cc443a3af5f</p> <p>Landed for 2.16</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51178/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51178/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16517" title="&#39;make debs&#39; ignores extra build options" class="issue-link" data-issue-key="LU-16517"><del>LU-16517</del></a> build: pass extra configure options to "make debs"<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: <br/> Commit: 5abc979eb64d8a78888aea63c0cf7e285fa0a4dd</p> Related Development Rank 1|i03bgf: Rank (Obsolete) 9223372036854775807 Severity