https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-16555 Lustre <p>print more YAML compatible special chars for jobid. They are:</p> <p>':', '/'.</p> LU-16555

print more YAML compatible special chars for jobid

Improvement Minor Resolved Fixed Feng Lei Feng Lei Wed, 15 Feb 2023 03:23:03 +0000 Fri, 10 Mar 2023 19:52:14 +0000 Wed, 8 Mar 2023 04:12:47 +0000 Lustre 2.16.0 0 2 <p>"Feng Lei &lt;flei@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49998" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49998</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16555" title="print more YAML compatible special chars for jobid" class="issue-link" data-issue-key="LU-16555"><del>LU-16555</del></a> obdclass: print more special chars for jobid<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 6117dedfc8823d7b0de0f5912cda18ea16b0d6a7</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49998/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49998/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16555" title="print more YAML compatible special chars for jobid" class="issue-link" data-issue-key="LU-16555"><del>LU-16555</del></a> obdclass: print more special chars for jobid<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 12604ac4deb242877bac5f12f517c2a5c0c2c72f</p> <p>Landed for 2.16</p> <p>I just saw a system with JobIDs that look like "0:0:" or "12345:23456:", which is apparently "%u:%g:%j", where "%j" is unset on login nodes. This is causing YAML parsing by collecd to fail in the case where ":" is at the end of the JobID string. Pasting these job_stats into <a href="http://yaml-online-parser.appspot.com/" class="external-link" target="_blank" rel="nofollow noopener">http://yaml-online-parser.appspot.com/</a> confirms that quoting the "0:0:" string fixes the parsing error. </p> <p>So we need 3 types of chars:</p> <ol> <li>common chars (alnum +".@-_:/"), which can be printed literally</li> <li>other chars which should be escaped</li> <li>chars which indicate jobid should be quoted, which is actually chars of 2 + ':'</li> </ol> <p>Make sense?</p> <p>Yes, if ":" is at the end then the JobID needs to be quoted or there is a YAML parsing error. When I reviewed the original 49998 patch I thought this couldn't happen easily, but with the empty "<tt>jobid_var</tt>" variable and a ":" separator this is easy to hit (or even if users just add a ":" at the end of <tt>jobid_name</tt> for whatever reason).</p> <p>"Feng Lei &lt;flei@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50150" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50150</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16555" title="print more YAML compatible special chars for jobid" class="issue-link" data-issue-key="LU-16555"><del>LU-16555</del></a> obdclass: quote jobid with ':' char<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 27729ac227266699730b5c39dfdad4c5533f88a5</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50150/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50150/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16555" title="print more YAML compatible special chars for jobid" class="issue-link" data-issue-key="LU-16555"><del>LU-16555</del></a> obdclass: quote jobid with ':' char<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: a99eb0210a5741138981e999082c695aef0dffff</p> <p>Landed for 2.16</p> Related LU-11407 Development Rank 1|i03e4v: Rank (Obsolete) 9223372036854775807