https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-16565 Lustre <p>We have macros like ldlm_{is,set,clear}_#FLAG_NAME# for all of the ldlm flags.  I'm going to remove them and convert all usages to just using the flag bit names directly.</p> <p>They make it much harder to find all uses of the actual lock flags and we are entirely inconsistent on whether we use the macros or not.  And since we're always going to use the flag names for multi-flag uses, we can't convert 100% to macros anyway.</p> LU-16565

Remove ldlm flag ldlm_{is,set,clear} macros

Improvement Minor Open Unresolved Patrick Farrell Patrick Farrell Thu, 16 Feb 2023 22:49:04 +0000 Fri, 17 Feb 2023 17:52:00 +0000 0 2 <p>"Patrick Farrell &lt;pfarrell@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50030" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50030</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16565" title="Remove ldlm flag ldlm_{is,set,clear} macros" class="issue-link" data-issue-key="LU-16565">LU-16565</a> ldlm: Add ldlm_is,set,clear to spelling<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1daca97e5c32f279b7afebe09e42d94e2327b721</p> <p>"Patrick Farrell &lt;pfarrell@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50031" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50031</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16565" title="Remove ldlm flag ldlm_{is,set,clear} macros" class="issue-link" data-issue-key="LU-16565">LU-16565</a> ldlm: Remove ldlm is,set,clear macros<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1bd0f0c2278d5fbc9697a0b743b389c942bd8ffa</p> <p>"Patrick Farrell &lt;pfarrell@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50032" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50032</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16565" title="Remove ldlm flag ldlm_{is,set,clear} macros" class="issue-link" data-issue-key="LU-16565">LU-16565</a> ldlm: Remove ldlm is,set,clear macros<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: e821e6fcfae0d664553b41ac8f25836d3365e990</p> <p>"Patrick Farrell &lt;pfarrell@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50044" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50044</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16565" title="Remove ldlm flag ldlm_{is,set,clear} macros" class="issue-link" data-issue-key="LU-16565">LU-16565</a> ldlm: Remove ldlm is,set,clear macros<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 66bb7f56a9b22139ae999336bfe1bb222c9e0cd0</p> <p>"Patrick Farrell &lt;pfarrell@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50045" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50045</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16565" title="Remove ldlm flag ldlm_{is,set,clear} macros" class="issue-link" data-issue-key="LU-16565">LU-16565</a> ldlm: Remove ldlm is,set,clear macros<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 39e2e5b9b55e0d1443cd136d312845d3418ae2a7</p> <p>"Patrick Farrell &lt;pfarrell@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50046" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50046</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16565" title="Remove ldlm flag ldlm_{is,set,clear} macros" class="issue-link" data-issue-key="LU-16565">LU-16565</a> ldlm: Remove ldlm is,set,clear macros<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 87679af288291494423be10b7b31b3b3be957a0e</p> <p>"Patrick Farrell &lt;pfarrell@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50047" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50047</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16565" title="Remove ldlm flag ldlm_{is,set,clear} macros" class="issue-link" data-issue-key="LU-16565">LU-16565</a> ldlm: Remove ldlm is,set,clear macros<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 3d7e0826bd5b28a3e3c889863e17899d418710f8</p> <p>"Patrick Farrell &lt;pfarrell@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50049" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50049</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16565" title="Remove ldlm flag ldlm_{is,set,clear} macros" class="issue-link" data-issue-key="LU-16565">LU-16565</a> ldlm: Remove ldlm is,set,clear macros<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 719c6a155c742b95e1d89f557eed94a36ab24450</p> <p>"Patrick Farrell &lt;pfarrell@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50051" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50051</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16565" title="Remove ldlm flag ldlm_{is,set,clear} macros" class="issue-link" data-issue-key="LU-16565">LU-16565</a> ldlm: Remove ldlm is,set,clear macros<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 3109e4d50ad0c54be9fdd31141b82ca70a862b24</p> <p>"Patrick Farrell &lt;pfarrell@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50052" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50052</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16565" title="Remove ldlm flag ldlm_{is,set,clear} macros" class="issue-link" data-issue-key="LU-16565">LU-16565</a> ldlm: Remove ldlm is,set,clear macros<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 65bd32eee637b2e212141ef62b373df6b2ed6f40</p> <p>"Patrick Farrell &lt;pfarrell@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50053" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50053</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16565" title="Remove ldlm flag ldlm_{is,set,clear} macros" class="issue-link" data-issue-key="LU-16565">LU-16565</a> ldlm: Remove ldlm is,set,clear macros<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 799f8d76d575452c68f829d112276937c611555f</p> <p>"Patrick Farrell &lt;pfarrell@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50054" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50054</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16565" title="Remove ldlm flag ldlm_{is,set,clear} macros" class="issue-link" data-issue-key="LU-16565">LU-16565</a> ldlm: Remove ldlm is,set,clear macros<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 11108e29328c444f8801bd71574ef67cb28b7950</p> Development Rank 1|i03ecv: Rank (Obsolete) 9223372036854775807