Whamcloud Community JIRA

Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us

9.4.14

940014

05-12-2023

[LU-166] MDR assert of wire dat for ATTR_BY_FID case https://jira.whamcloud.com/browse/LU-166 Lustre <p>mdt_getattr_name_lock has this code:</p> <p> if (!info->mti_cross_ref) {<br/> /*</p> <ul> <li>XXX: Check for "namelen == 0" is for getattr by fid</li> <li>(OBD_CONNECT_ATTRFID), otherwise do not allow empty name,</li> <li>that is the name must contain at least one character and</li> <li>the terminating '\0'<br/> */<br/> if (namelen == 0) {<br/> reqbody = req_capsule_client_get(info->mti_pill,<br/> &RMF_MDT_BODY);<br/> LASSERT(fid_is_sane(&reqbody->fid2));</li> </ul> <p>This LASSERT is wrong because it depends on correctness of the client-supplied data.<br/> Should be replaced with EPROTO error.</p> LU-166

MDR assert of wire dat for ATTR_BY_FID case

Bug Minor Resolved Fixed nasf Oleg Drokin Sat, 26 Mar 2011 08:55:38 +0000 Tue, 3 May 2011 18:10:19 +0000 Tue, 3 May 2011 18:10:19 +0000 Lustre 2.0.0 Lustre 2.1.0 Lustre 2.1.0 0 0 <p>Right, the patch is in inspection:</p> <p><a href="http://review.whamcloud.com/#change,367" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,367</a></p> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/reviews-centos5/575/" class="external-link" target="_blank" rel="nofollow noopener">reviews-centos5 #575</a><br/> <a href="https://jira.whamcloud.com/browse/LU-166" title="MDR assert of wire dat for ATTR_BY_FID case" class="issue-link" data-issue-key="LU-166"><del>LU-166</del></a> NOT assert wire data from client for getattr-by-fid</p> <p>nasf : <a href="http://git.whamcloud.com/gitweb/?p=fs/lustre-release.git&a=commit&h=2c7b04b817930a1b8e93d04d4cb809ee5691b191" class="external-link" target="_blank" rel="nofollow noopener">2c7b04b817930a1b8e93d04d4cb809ee5691b191</a><br/> Files : </p> <ul> <li>lustre/mdt/mdt_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/red.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master-centos5/202/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master-centos5 #202</a><br/> <a href="https://jira.whamcloud.com/browse/LU-166" title="MDR assert of wire dat for ATTR_BY_FID case" class="issue-link" data-issue-key="LU-166"><del>LU-166</del></a> NOT assert wire data from client for getattr-by-fid</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb/?p=fs/lustre-release.git&a=commit&h=88dd29f38769744eac20b06e1baac52872bf423f" class="external-link" target="_blank" rel="nofollow noopener">88dd29f38769744eac20b06e1baac52872bf423f</a><br/> Files : </p> <ul> <li>lustre/mdt/mdt_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/red.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./build_type=client,platform=ubuntu-x86_64/29/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » client,ubuntu-x86_64 #29</a><br/> <a href="https://jira.whamcloud.com/browse/LU-166" title="MDR assert of wire dat for ATTR_BY_FID case" class="issue-link" data-issue-key="LU-166"><del>LU-166</del></a> NOT assert wire data from client for getattr-by-fid</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=88dd29f38769744eac20b06e1baac52872bf423f" class="external-link" target="_blank" rel="nofollow noopener">88dd29f38769744eac20b06e1baac52872bf423f</a><br/> Files : </p> <ul> <li>lustre/mdt/mdt_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./build_type=client,platform=el5-x86_64/29/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » client,el5-x86_64 #29</a><br/> <a href="https://jira.whamcloud.com/browse/LU-166" title="MDR assert of wire dat for ATTR_BY_FID case" class="issue-link" data-issue-key="LU-166"><del>LU-166</del></a> NOT assert wire data from client for getattr-by-fid</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=88dd29f38769744eac20b06e1baac52872bf423f" class="external-link" target="_blank" rel="nofollow noopener">88dd29f38769744eac20b06e1baac52872bf423f</a><br/> Files : </p> <ul> <li>lustre/mdt/mdt_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./build_type=client,platform=el5-i686/29/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » client,el5-i686 #29</a><br/> <a href="https://jira.whamcloud.com/browse/LU-166" title="MDR assert of wire dat for ATTR_BY_FID case" class="issue-link" data-issue-key="LU-166"><del>LU-166</del></a> NOT assert wire data from client for getattr-by-fid</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=88dd29f38769744eac20b06e1baac52872bf423f" class="external-link" target="_blank" rel="nofollow noopener">88dd29f38769744eac20b06e1baac52872bf423f</a><br/> Files : </p> <ul> <li>lustre/mdt/mdt_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./build_type=server,platform=el6-x86_64/29/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » server,el6-x86_64 #29</a><br/> <a href="https://jira.whamcloud.com/browse/LU-166" title="MDR assert of wire dat for ATTR_BY_FID case" class="issue-link" data-issue-key="LU-166"><del>LU-166</del></a> NOT assert wire data from client for getattr-by-fid</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=88dd29f38769744eac20b06e1baac52872bf423f" class="external-link" target="_blank" rel="nofollow noopener">88dd29f38769744eac20b06e1baac52872bf423f</a><br/> Files : </p> <ul> <li>lustre/mdt/mdt_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./build_type=client,platform=el6-i686/29/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » client,el6-i686 #29</a><br/> <a href="https://jira.whamcloud.com/browse/LU-166" title="MDR assert of wire dat for ATTR_BY_FID case" class="issue-link" data-issue-key="LU-166"><del>LU-166</del></a> NOT assert wire data from client for getattr-by-fid</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=88dd29f38769744eac20b06e1baac52872bf423f" class="external-link" target="_blank" rel="nofollow noopener">88dd29f38769744eac20b06e1baac52872bf423f</a><br/> Files : </p> <ul> <li>lustre/mdt/mdt_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./build_type=server,platform=el5-x86_64/29/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » server,el5-x86_64 #29</a><br/> <a href="https://jira.whamcloud.com/browse/LU-166" title="MDR assert of wire dat for ATTR_BY_FID case" class="issue-link" data-issue-key="LU-166"><del>LU-166</del></a> NOT assert wire data from client for getattr-by-fid</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=88dd29f38769744eac20b06e1baac52872bf423f" class="external-link" target="_blank" rel="nofollow noopener">88dd29f38769744eac20b06e1baac52872bf423f</a><br/> Files : </p> <ul> <li>lustre/mdt/mdt_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./build_type=client,platform=el6-x86_64/29/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » client,el6-x86_64 #29</a><br/> <a href="https://jira.whamcloud.com/browse/LU-166" title="MDR assert of wire dat for ATTR_BY_FID case" class="issue-link" data-issue-key="LU-166"><del>LU-166</del></a> NOT assert wire data from client for getattr-by-fid</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=88dd29f38769744eac20b06e1baac52872bf423f" class="external-link" target="_blank" rel="nofollow noopener">88dd29f38769744eac20b06e1baac52872bf423f</a><br/> Files : </p> <ul> <li>lustre/mdt/mdt_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./build_type=server,platform=el5-i686/29/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » server,el5-i686 #29</a><br/> <a href="https://jira.whamcloud.com/browse/LU-166" title="MDR assert of wire dat for ATTR_BY_FID case" class="issue-link" data-issue-key="LU-166"><del>LU-166</del></a> NOT assert wire data from client for getattr-by-fid</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=88dd29f38769744eac20b06e1baac52872bf423f" class="external-link" target="_blank" rel="nofollow noopener">88dd29f38769744eac20b06e1baac52872bf423f</a><br/> Files : </p> <ul> <li>lustre/mdt/mdt_handler.c</li> </ul> <p>Patch is landed.</p> Development Rank 1|hzv9h3: Rank (Obsolete) 5069 Severity