https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-16662 Lustre <p>Linux 5.19+ break configure test compile on CONFIG_KEYS when run configure without passing Linux src path.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> $ ./configure --disable-server ... checking whether to enable gss keyring backend... yes checking <span class="code-keyword">if</span> Linux kernel was built with CONFIG_KEYS in or as module... no configure: WARNING: GSS keyring backend requires that CONFIG_KEYS be enabled in your kernel. checking <span class="code-keyword">for</span> keyctl_search in -lkeyutils... yes configure: error: Cannot enable gss_keyring. See above <span class="code-keyword">for</span> details. $ grep CONFIG_KEYS -rn /boot/config-* 6884:CONFIG_KEYS=y </pre> </div></div> LU-16662

Linux 5.19+ break configure test compile on CONFIG_KEYS

Bug Minor Resolved Fixed Xinliang Liu Xinliang Liu Fri, 24 Mar 2023 01:21:01 +0000 Wed, 20 Dec 2023 03:49:01 +0000 Tue, 19 Dec 2023 19:57:26 +0000 Lustre 2.16.0 Lustre 2.15.4 0 8 <p>Looking at the config.log, there are many modpost errors. These errors make conftest.c compile failed.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> configure:20676: checking <span class="code-keyword">if</span> Linux kernel was built with CONFIG_KEYS in or as module configure:20716: cp conftest.c build &amp;&amp; make -d modules DEQUOTE_CC_VERSION_TEXT=yes LDFLAGS= LD=/usr/bin/ld CC=gcc -f /home/openeuler/lustre-release/build/Makefile LUSTRE_LINUX_CONFIG=/lib/modules/6.1.8-3.0.0.7.oe1.aarch64/build/.config LINUXINCLUDE= -I/lib/modules/6.1.8-3.0.0.7.oe1.aarch64/source/arch/arm64/include -Iinclude -Iarch/arm64/include/generated -I/lib/modules/6.1.8-3.0.0.7.oe1.aarch64/source/include -Iinclude2 -I/lib/modules/6.1.8-3.0.0.7.oe1.aarch64/source/include/uapi -Iinclude/generated -I/lib/modules/6.1.8-3.0.0.7.oe1.aarch64/source/arch/arm64/include/uapi -Iarch/arm64/include/generated/uapi -I/lib/modules/6.1.8-3.0.0.7.oe1.aarch64/source/include/uapi -Iinclude/generated/uapi -include /lib/modules/6.1.8-3.0.0.7.oe1.aarch64/source/include/linux/kconfig.h KBUILD_EXTRA_SYMBOLS= /usr/src/kernels/6.1.8-3.0.0.7.oe1.aarch64/Module.symvers -o tmp_include_depends -o scripts -o include/config/MARKER -C /lib/modules/6.1.8-3.0.0.7.oe1.aarch64/build EXTRA_CFLAGS=-Werror-implicit-function-declaration -g -I/home/openeuler/lustre-release/libcfs/include -I/home/openeuler/lustre-release/libcfs/include/libcfs -I/home/openeuler/lustre-release/lnet/include/uapi -I/home/openeuler/lustre-release/lnet/include -I/home/openeuler/lustre-release/lustre/include/uapi -I/home/openeuler/lustre-release/lustre/include -Wno-format-truncation -Wno-stringop-truncation -Wno-stringop-overflow M=/home/openeuler/lustre-release/build warning: the compiler differs from the one used to build the kernel   The kernel was built by:   You are using:           gcc (GCC) 10.3.1 ERROR: modpost: vmlinux: <span class="code-quote">'init_uts_ns'</span> exported twice. Previous export was in vmlinux ERROR: modpost: vmlinux: <span class="code-quote">'system_state'</span> exported twice. Previous export was in vmlinux ERROR: modpost: vmlinux: <span class="code-quote">'static_key_initialized'</span> exported twice. Previous export was in vmlinux ERROR: modpost: vmlinux: <span class="code-quote">'reset_devices'</span> exported twice. Previous export was in vmlinux ERROR: modpost: vmlinux: <span class="code-quote">'loops_per_jiffy'</span> exported twice. Previous export was in vmlinux ERROR: modpost: vmlinux: <span class="code-quote">'name_to_dev_t'</span> exported twice. Previous export was in vmlinux ERROR: modpost: vmlinux: <span class="code-quote">'wait_for_initramfs'</span> exported twice. Previous export was in vmlinux ERROR: modpost: vmlinux: <span class="code-quote">'init_task'</span> exported twice. Previous export was in vmlinux ERROR: modpost: vmlinux: <span class="code-quote">'fpsimd_context_busy'</span> exported twice. Previous export was in vmlinux ERROR: modpost: vmlinux: <span class="code-quote">'kernel_neon_begin'</span> exported twice. Previous export was in vmlinux ERROR: modpost: vmlinux: <span class="code-quote">'kernel_neon_end'</span> exported twice. Previous export was in vmlinux ERROR: modpost: vmlinux: <span class="code-quote">'pm_power_off'</span> exported twice. Previous export was in vmlinux ERROR: modpost: vmlinux: <span class="code-quote">'profile_pc'</span> exported twice. Previous export was in vmlinux ERROR: modpost: vmlinux: <span class="code-quote">'__memcpy_fromio'</span> exported twice. Previous export was in vmlinux ERROR: modpost: vmlinux: <span class="code-quote">'__memcpy_toio'</span> exported twice. Previous export was in vmlinux ...</pre> </div></div> <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=yujian" class="user-hover" rel="yujian">yujian</a> - I believe you're looking at this on another ticket</p> <p>The symbols exported twice printing is caused by pass kernel Module.symvers via KBUILD_EXTRA_SYMBOLS option when compiling.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> KBUILD_EXTRA_SYMBOLS=/usr/src/kernels/6.1.8-3.0.0.7.oe1.aarch64/Module.symvers </pre> </div></div> <p>And after commit "<a href="https://patchwork.kernel.org/project/linux-kbuild/patch/20220424190811.1678416-17-masahiroy@kernel.org/" class="external-link" target="_blank" rel="nofollow noopener">b8422711080f modpost: make multiple export error</a>" which introduced in v5.19 make this symbol exported twice as error from warning.</p> <p>So here it shouldn't put kernel's Module.symvers  to KBUILD_EXTRA_SYMBOLS option.</p> <p>Thanks <a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=paf0186" class="user-hover" rel="paf0186">paf0186</a> for the notice , I just can't find a related ticket and just working out the patch to send. If we find Jian's ticket we can mark this as a duplicated one</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> $ cat config.patch diff --git a/lnet/autoconf/lustre-lnet.m4 b/lnet/autoconf/lustre-lnet.m4 index 7421cfb91b..4f088a148b 100644 --- a/lnet/autoconf/lustre-lnet.m4 +++ b/lnet/autoconf/lustre-lnet.m4 @@ -245,7 +245,7 @@ AS_IF([test $ENABLEO2IB = <span class="code-quote">"no"</span>], [                         O2IB_SYMVER=$LINUX_OBJ/Module.symvers                 fi                 <span class="code-keyword">if</span> test -n <span class="code-quote">"$O2IB_SYMVER"</span>; then -                       <span class="code-keyword">if</span> test <span class="code-quote">"$O2IB_SYMVER"</span> != <span class="code-quote">"$LINUX_OBJ/Module.symvers"</span>; then +                       <span class="code-keyword">if</span> test ！<span class="code-quote">"$O2IB_SYMVER"</span> -ef <span class="code-quote">"$LINUX_OBJ/Module.symvers"</span>; then                                 AC_MSG_NOTICE([adding $O2IB_SYMVER to Symbol Path O2IB])                                 EXTRA_SYMBOLS=<span class="code-quote">"$EXTRA_SYMBOLS $O2IB_SYMVER"</span>                                 AC_SUBST(EXTRA_SYMBOLS) @@ -286,7 +286,7 @@ AC_SUBST(ENABLEO2IB) AS_IF([test $ENABLEO2IB != <span class="code-quote">"no"</span>], [         EXTRA_CHECK_INCLUDE=<span class="code-quote">"$EXTRA_OFED_CONFIG $EXTRA_OFED_INCLUDE"</span> -       <span class="code-keyword">if</span> test $O2IBPATH != $LINUX_OBJ; then +       <span class="code-keyword">if</span> test ! $O2IBPATH -ef $LINUX_OBJ; then                 KBUILD_EXTRA_SYMBOLS=<span class="code-quote">"$KBUILD_EXTRA_SYMBOLS $O2IBPATH/Module.symvers"</span>         fi </pre> </div></div> <p>For in-tree IB support and without passing Linux src path, the LINUX_OBJ  maybe just a soft link to O2IBPATH, they are pointing to the same dir.</p> <p>E.g.:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> O2IBPATH=<span class="code-quote">'/usr/src/kernels/6.1.8-3.0.0.7.oe1.aarch64'</span> LINUX_OBJ=<span class="code-quote">'/lib/modules/6.1.8-3.0.0.7.oe1.aarch64/build'</span> $ ls -l /lib/modules/6.1.8-3.0.0.7.oe1.aarch64/build lrwxrwxrwx 1 root root 42 Feb  7 00:00 /lib/modules/6.1.8-3.0.0.7.oe1.aarch64/build -&gt; /usr/src/kernels/6.1.8-3.0.0.7.oe1.aarch64</pre> </div></div> <p>Hi <a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=xinliang" class="user-hover" rel="xinliang">xinliang</a> and <a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=paf0186" class="user-hover" rel="paf0186">paf0186</a>,<br/> The ticket is DDN-3569. However, there are two issues. Please refer to <a href="https://jira.whamcloud.com/browse/DDN-3569?focusedCommentId=366961&amp;page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-366961" class="external-link" rel="nofollow">#comment-366961</a>.</p> <p>Sorry <a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=yujian" class="user-hover" rel="yujian">yujian</a> , I can't open the comment link.</p> <p>That is expected - it is not a public comment. So, it would be better to collaborate on this ticket</p> <p>Another issue is:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># ./configure --disable-server --with-o2ib # make rpms &lt;~snip~&gt; make[4]: *** No rule to make target 'crypto.c', needed by 'distdir'. Stop. </pre> </div></div> <p> </p> <p>Yeah, this is really another issue which need another ticket to track.</p> <p>But I can't reproduce this issue on my v6.1 kernel arm machine with your cmds on master branch.</p> <p>BTW, I apply some unmerged patches mentioned in <a href="https://jira.whamcloud.com/browse/LU-16351" title="Linux 6.1 client support" class="issue-link" data-issue-key="LU-16351"><del>LU-16351</del></a></p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> f7edfcb684 (HEAD -&gt; 6.1-openeuler) LU-16662 autoconf: fix configure test compile <span class="code-keyword">for</span> CONFIG_KEYS e61195e4f8 LU-16351 llite: Linux 6.1 prandom, folios_contig, vma_iterator 6add9c73a4 LU-16350 osd-ldiskfs: no_llseek removed, dquot_transfer 5bc0f95938 LU-16328 llite: Linux 6.0 migrate_folio, vfs_setxattr a0f760acdd LU-16327 llite: read_folio, release_folio, filler_t </pre> </div></div> <p>"xinliang &lt;xinliang.liu@linaro.org&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50399" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50399</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16662" title="Linux 5.19+ break configure test compile on CONFIG_KEYS" class="issue-link" data-issue-key="LU-16662"><del>LU-16662</del></a> autoconf: fix configure test compile for CONFIG_KEYS<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 32e82ef1eef4e7968ff4a543a61d9ab374e0b6f3</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50399/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50399/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16662" title="Linux 5.19+ break configure test compile on CONFIG_KEYS" class="issue-link" data-issue-key="LU-16662"><del>LU-16662</del></a> autoconf: fix configure test compile for CONFIG_KEYS<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 321a533b868908f37d01a4b787f5a463a02e427c</p> <p>Landed for 2.16</p> <p>"Jian Yu &lt;yujian@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50568" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50568</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16662" title="Linux 5.19+ break configure test compile on CONFIG_KEYS" class="issue-link" data-issue-key="LU-16662"><del>LU-16662</del></a> autoconf: fix configure test compile for CONFIG_KEYS<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: 1<br/> Commit: 3b719f23c352f73471a3f5904ef790e9936497bf</p> <p>Just found the mlx build was not enabled on master branch. With this patch applied on another branch, el9.0, el9.1, sles15sp3, sles15sp4, ubuntu2004 and ubuntu2204 mlx build failed:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>ERROR: modpost: "backport_dependency_symbol" [/tmp/rpmbuild-lustre-jenkins-7GHqQmd3/BUILD/....../lnet/klnds/o2iblnd/ko2iblnd.ko] undefined! ERROR: modpost: "ib_get_dma_mr" [/tmp/rpmbuild-lustre-jenkins-7GHqQmd3/BUILD/....../lnet/klnds/o2iblnd/ko2iblnd.ko] undefined! </pre> </div></div> <p>$O2IB_SYMVER was not added to Symbol Path.</p> <p>Maybe the $O2IB_SYMVER is not correct.</p> <p>And <a href="https://jira.whamcloud.com/browse/LU-15962" title="ko2iblnd: Unknown symbol __ib_alloc_pd" class="issue-link" data-issue-key="LU-15962"><del>LU-15962</del></a> shows that it should add kernel's Module.symvers to variable EXTRA_SYMBOLS.</p> <p>Looks like variable EXTRA_SYMBOLS and KBUILD_EXTRA_SYMBOLS are not the same thing.</p> <p>And can't find any description of EXTRA_SYMBOLS in <a href="https://www.kernel.org/doc/Documentation/kbuild/modules.txt" class="external-link" target="_blank" rel="nofollow noopener">https://www.kernel.org/doc/Documentation/kbuild/modules.txt</a> or somewhere else.</p> <p>Building against mlnx-ofa_kernel no longer works with this patch.</p> <p>running configure with this patch:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>&gt; git -P diff diff --git a/lnet/autoconf/lustre-lnet.m4 b/lnet/autoconf/lustre-lnet.m4 index 4f088a148b..3c45644447 100644 --- a/lnet/autoconf/lustre-lnet.m4 +++ b/lnet/autoconf/lustre-lnet.m4 @@ -249,6 +249,8 @@ AS_IF([test $ENABLEO2IB = "no"], [ AC_MSG_NOTICE([adding $O2IB_SYMVER to Symbol Path O2IB]) EXTRA_SYMBOLS="$EXTRA_SYMBOLS $O2IB_SYMVER" AC_SUBST(EXTRA_SYMBOLS) + else + AC_MSG_NOTICE([$O2IB_SYMVER -ef $LINUX_OBJ/Module.symvers]) fi else AC_MSG_ERROR([an external source tree was, either specified or detected, for o2iblnd however I could not find a $O2IBPATH/Module.symvers there]) &gt; ./configure --with-linux=/usr/src/linux-5.3.18-150300.59.106 --with-linux-obj=/usr/src/linux-5.3.18-150300.59.106-obj/x86_64/default --disable-server --with-o2ib=/usr/src/ofa_kernel/default ... configure: /usr/src/ofa_kernel/x86_64/5.3.18-150300.59.106-default/Module.symvers -ef /usr/src/linux-5.3.18-150300.59.106-obj/x86_64/default/Module.symvers ... &gt; md5sum /usr/src/ofa_kernel/x86_64/5.3.18-150300.59.106-default/Module.symvers 746f968f5349ba78622c251b5ca1f625 /usr/src/ofa_kernel/x86_64/5.3.18-150300.59.106-default/Module.symvers &gt; md5sum /usr/src/linux-5.3.18-150300.59.106-obj/x86_64/default/Module.symvers 445f21b295267047818da63f2ca27ee6 /usr/src/linux-5.3.18-150300.59.106-obj/x86_64/default/Module.symvers &gt; </pre> </div></div> <p>Strangely! I verified that the test operator "-ef" can test if a file is equal to a link, no matter if it is a soft or hard link.</p> <p>See <a href="https://stackoverflow.com/questions/40813253/compare-a-symlink-and-his-target-with-bash-test-ef" class="external-link" target="_blank" rel="nofollow noopener">https://stackoverflow.com/questions/40813253/compare-a-symlink-and-his-target-with-bash-test-ef</a> also.</p> <p>But another thing is that "-ef" is not a POSIX test, see: <a href="https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html#tag_20_128" class="external-link" target="_blank" rel="nofollow noopener">https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html#tag_20_128</a></p> <p> </p> <p>And the configure script seems to use shell interpreter "/bin/sh". Could you check which shell it is? And check that "-ef" is support like below</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> [jenkins@lustre-jenkins-slave-1 ~]$ ls -l /bin/sh lrwxrwxrwx. 1 root root 4 Jan 12  2021 /bin/sh -&gt; bash [jenkins@lustre-jenkins-slave-1 ~]$ sh -c <span class="code-quote">" test ! . -ef .. &amp;&amp; echo !="</span> != </pre> </div></div> <p> </p> <p>Looks like it will append EXTRA SYMBOLS to KBUILD_EXTRA_SYMBOLS eventually.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> [openeuler@oe-mainline-test lustre-release]$ grep @EXTRA_SYMBOLS@ -rn|grep KBUILD_EXTRA_SYMBOLS build/Rules.in:37:KBUILD_EXTRA_SYMBOLS += @EXTRA_SYMBOLS@ </pre> </div></div> <p><a href="https://www.kernel.org/doc/Documentation/kbuild/modules.txt" class="external-link" target="_blank" rel="nofollow noopener">https://www.kernel.org/doc/Documentation/kbuild/modules.txt</a> </p> <p>The below merged patch contains $O2IB_SYMVER adding fix. Thanks, Shaun Tancheff.</p> <p><a href="https://review.whamcloud.com/c/fs/lustre-release/+/50711" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50711</a></p> <p>All patches merged for 2.16</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50568/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50568/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16662" title="Linux 5.19+ break configure test compile on CONFIG_KEYS" class="issue-link" data-issue-key="LU-16662"><del>LU-16662</del></a> autoconf: fix configure test compile for CONFIG_KEYS<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: <br/> Commit: 05df94478440a0902467c177295804faeeac2991</p> Related LU-16719 Development Rank 1|i03h2v: Rank (Obsolete) 9223372036854775807 Severity