https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-16791 Lustre <p>When trying to build lustre against  zfs master tree we get this:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>libmount_utils_zfs.c: In function 'zfs_get_prop_int': libmount_utils_zfs.c:491:51: error: passing argument 3 of 'nvlist_lookup_string' from incompatible pointer type [-Werror=incompatible-pointer-types]   ret = nvlist_lookup_string(propval, ZPROP_VALUE, &amp;propstr);                                                    ^~~~~~~~ </pre> </div></div> <p>and related</p> LU-16791

Modern ZFS constified nvlist* functions breaking zfs_[gs]et_prop_*

Bug Minor Resolved Fixed Oleg Drokin Oleg Drokin LTS15 lug23dd Mon, 1 May 2023 23:23:35 +0000 Sun, 21 Jan 2024 05:54:27 +0000 Thu, 18 Jan 2024 13:16:01 +0000 Lustre 2.16.0 Lustre 2.16.0 0 9 <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50824" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50824</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16791" title="Modern ZFS constified nvlist* functions breaking zfs_[gs]et_prop_*" class="issue-link" data-issue-key="LU-16791"><del>LU-16791</del></a> utils: Constify prop argument for zfs nvlist*<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: f434618dfde371b05eafeeb9ab10ab8711e0a284</p> <p>"Brian Atkinson &lt;batkinson@lanl.gov&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/52519" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/52519</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16791" title="Modern ZFS constified nvlist* functions breaking zfs_[gs]et_prop_*" class="issue-link" data-issue-key="LU-16791"><del>LU-16791</del></a> utils: ZFS 2.2 const prop args<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: d01bf3997a43e13fb22067fd8ee803dc9a5a9f5c</p> <p>On the latest lustre-release code along with this patch, the build fails due to `arc_prune_func_t` changes: </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> /root/akash/akash/build/lustre-release/lustre/osd-zfs/osd_handler.c: In function <span class="code-quote">'osd_objset_register_callbacks'</span>: /root/akash/akash/build/lustre-release/lustre/osd-zfs/osd_handler.c:915:50: error: passing argument 1 of <span class="code-quote">'arc_add_prune_callback'</span> from incompatible pointer type [-Werror=incompatible-pointer-types] 915 | o-&gt;arc_prune_cb = arc_add_prune_callback(arc_prune_func, o); | ^~~~~~~~~~~~~~ | | | void (*)(int64_t, void *) {aka void (*)(<span class="code-object">long</span> <span class="code-object">long</span> <span class="code-object">int</span>, void *)} In file included from /root/akash/akash/build/lustre-release/lustre/osd-zfs/osd_internal.h:51, from /root/akash/akash/build/lustre-release/lustre/osd-zfs/osd_handler.c:51: /usr/src/zfs-2.2.2/include/sys/arc.h:310:55: note: expected <span class="code-quote">'void (*)(uint64_t, void *)'</span> {aka <span class="code-quote">'void (*)(<span class="code-object">long</span> <span class="code-object">long</span> unsigned <span class="code-object">int</span>, void *)'</span>} but argument is of type <span class="code-quote">'void (*)(int64_t, void *)'</span> {aka <span class="code-quote">'void (*)(<span class="code-object">long</span> <span class="code-object">long</span> <span class="code-object">int</span>, void *)'</span>} 310 | arc_prune_t *arc_add_prune_callback(arc_prune_func_t *func, void *priv); | ~~~~~~~~~~~~~~~~~~^~~~ cc1: all warnings being treated as errors make[6]: *** [scripts/Makefile.build:321: /root/akash/akash/build/lustre-release/lustre/osd-zfs/osd_handler.o] Error 1 make[6]: *** Waiting <span class="code-keyword">for</span> unfinished jobs.... make[5]: *** [scripts/Makefile.build:607: /root/akash/akash/build/lustre-release/lustre/osd-zfs] Error 2 make[4]: *** [scripts/Makefile.build:607: /root/akash/akash/build/lustre-release/lustre] Error 2 make[3]: *** [Makefile:1923: /root/akash/akash/build/lustre-release] Error 2 make[3]: Leaving directory <span class="code-quote">'/usr/src/kernels/5.14.0-284.18.1.x7.0.000.9.x86_64'</span> make[2]: *** [autoMakefile:1200: modules] Error 2 make[2]: Leaving directory <span class="code-quote">'/root/akash/akash/build/lustre-release'</span> make[1]: *** [autoMakefile:711: all-recursive] Error 1 make[1]: Leaving directory <span class="code-quote">'/root/akash/akash/build/lustre-release'</span> make: *** [autoMakefile:571: all] Error 2</pre> </div></div> <p>Build failure seems to be due to the changes to `arc_prune_func_t`  from the following commit from OpenZFS:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> commit 3ec4ea68d491a82c8de3360d50032bdecd53608f Date: Mon Oct 30 19:56:04 2023 -0400 Unify arc_prune_async() code Closes #15456 ... - typedef void arc_prune_func_t(int64_t bytes, void *priv); + typedef void arc_prune_func_t(uint64_t bytes, void *priv); ...</pre> </div></div> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/52519/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/52519/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16791" title="Modern ZFS constified nvlist* functions breaking zfs_[gs]et_prop_*" class="issue-link" data-issue-key="LU-16791"><del>LU-16791</del></a> utils: ZFS 2.2 const prop args<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: b4b32ffd22d276bc1d8f40e3336df982f3717070</p> <p>Landed for 2.16</p> <p>Can we check if openzfs (zfs-2.2-release and master) builds on the latest lustre-release code along with this patch, and see if there are any failures due to `arc_prune_func_t` <a href="https://jira.whamcloud.com/browse/LU-16791?focusedId=398996&amp;page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-398996" class="external-link" rel="nofollow">changes</a>? </p> <p>There are build failures when it's built against ZFS (master and zfs-2.2-release) builds even after landing <a href="https://jira.whamcloud.com/browse/LU-16791" title="Modern ZFS constified nvlist* functions breaking zfs_[gs]et_prop_*" class="issue-link" data-issue-key="LU-16791"><del>LU-16791</del></a>. Further, <a href="https://jira.whamcloud.com/browse/LU-17421" title="Lustre master build failure with ZFS 2.2.1" class="issue-link" data-issue-key="LU-17421">LU-17421</a> is created to fix the build issue for the `arc_prune_func_t` changes.</p> Related LU-16795 Development Rank 1|i03kef: Rank (Obsolete) 9223372036854775807