Whamcloud Community JIRA

Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us

9.4.14

940014

05-12-2023

[LU-16803] uapi guid_t removed in commit v6.2-rc5-72-g5e6a51787fef https://jira.whamcloud.com/browse/LU-16803 Lustre <p>Need to check user space has guid_t from uapi linux headers and fallback to uuid_le when guid_t is not present.</p> LU-16803

uapi guid_t removed in commit v6.2-rc5-72-g5e6a51787fef

Improvement Minor Resolved Fixed Shaun Tancheff Shaun Tancheff Sun, 7 May 2023 03:27:04 +0000 Fri, 19 May 2023 12:56:16 +0000 Fri, 19 May 2023 12:56:16 +0000 Lustre 2.16.0 0 3 <p>"Shaun Tancheff <shaun.tancheff@hpe.com>" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50878" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50878</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16803" title="uapi guid_t removed in commit v6.2-rc5-72-g5e6a51787fef" class="issue-link" data-issue-key="LU-16803"><del>LU-16803</del></a> build: Decouple guid_t and uuid_le<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: c3970b49fd60ed58f7e1aba0c4c055fc50815f86</p> <p>The issue is resolved in <a href="https://jira.whamcloud.com/browse/LU-16739" title="sanity 400b fails due to recent lustre_disk.h changes" class="issue-link" data-issue-key="LU-16739"><del>LU-16739</del></a> switching to uuid_le</p> <p>With <a href="https://jira.whamcloud.com/browse/LU-16739" title="sanity 400b fails due to recent lustre_disk.h changes" class="issue-link" data-issue-key="LU-16739"><del>LU-16739</del></a> ("uapi: make lustre_disk.h buildable in user land") applied the user space compile failure when 6.4 kernel-headers are installed is resolved.</p> <p>Unfortunately we get a new issue:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>/home/shaun/lustre-release/lustre/include/uapi/linux/lustre/lustre_disk.h:410:2: error: unknown type name ‘uuid_le’ 410 | uuid_le sf_uuid; /* 128-bit uuid for volume */ | ^~~~~~~ </pre> </div></div> <p>If including the new header <linux/mei_uuid.h> resolves the above, however a new problem appears due to guid_t and uuid_le not being the same type:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>/home/shaun/lustre-release/lustre/obdclass/scrub.c: In function ‘scrub_file_to_cpu’: /home/shaun/lustre-release/lustre/obdclass/scrub.c:50:12: error: passing argument 1 of ‘guid_copy’ from incompatible pointer type [-Werror=incompatible-pointer-types] 50 | guid_copy(&des->sf_uuid, &src->sf_uuid); | ^~~~~~~~~~~~~ | | | uuid_le * {aka struct <anonymous> *} In file included from /home/shaun/lustre-release/lustre/include/lustre_scrub.h:36, from /home/shaun/lustre-release/lustre/obdclass/scrub.c:38: include/linux/uuid.h:51:38: note: expected ‘guid_t *’ {aka ‘struct <anonymous> *’} but argument is of type ‘uuid_le *’ {aka ‘struct <anonymous> *’} 51 | static inline void guid_copy(guid_t *dst, const guid_t *src) | ~~~~~~~~^~~ /home/shaun/lustre-release/lustre/obdclass/scrub.c:50:27: error: passing argument 2 of ‘guid_copy’ from incompatible pointer type [-Werror=incompatible-pointer-types] 50 | guid_copy(&des->sf_uuid, &src->sf_uuid); | ^~~~~~~~~~~~~ | | | uuid_le * {aka struct <anonymous> *} In file included from /home/shaun/lustre-release/lustre/include/lustre_scrub.h:36, from /home/shaun/lustre-release/lustre/obdclass/scrub.c:38: </pre> </div></div> <p>"Shaun Tancheff <shaun.tancheff@hpe.com>" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50885" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50885</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16803" title="uapi guid_t removed in commit v6.2-rc5-72-g5e6a51787fef" class="issue-link" data-issue-key="LU-16803"><del>LU-16803</del></a> build: Map uuid_le to guid_t for in-kernel APIs<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 31816ebe32f6b5c52a86c2503b30a9f1370e20a8</p> <p>"Oleg Drokin <green@whamcloud.com>" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50885/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50885/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-16803" title="uapi guid_t removed in commit v6.2-rc5-72-g5e6a51787fef" class="issue-link" data-issue-key="LU-16803"><del>LU-16803</del></a> build: Map uuid_le to guid_t for in-kernel APIs<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 674aaa08011a8c04856069e55e91b43354d670ae</p> <p>Landed for 2.16</p> Development Rank 1|i03kqv: Rank (Obsolete) 9223372036854775807 Severity