https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-16811 Lustre <p>The <tt>check_if_lustre_mounted()</tt> function that is patched into <tt>mke2fs</tt> is not working properly, because it is checking <tt>/proc/fs/lustre/osd-ldiskfs/mntdev</tt> but this file has long ago moved to <tt>/sys/fs/lustre/osd-ldiskfs/mntdev</tt>.</p> <p>The checking for the Lustre mount device was necessary before the kernel <tt>open(O_EXCL)</tt> functionality was available to prevent <tt>mke2fs</tt> and <tt>e2fsck</tt> from running on a mounted block device. It seems that this patch is no longer needed and could be removed from e2fsprogs, one less patch that needs to be maintained.</p> <p>Before removing the patch completely, it would be good to manually test this is working against a (test) mounted ZFS filesystem device. I've tested with ldiskfs and can confirm that <tt>open(O_EXCL)</tt> fails for the <b>BLOCK DEVICE</b> (e.g. <tt>/dev/mapper/ost4_flakey</tt>), though it does <b>not</b> work if a plain file (e.g. <tt>/tmp/testfs-ost4</tt>) is mounted via loopback and the <b>file</b> is formatted by <tt>mke2fs</tt>, but that isn't unexpected and this patch wouldn't avoid it either way.</p> LU-16811

mke2fs check_if_lustre_mounted() not working or needed

Bug Major Open Unresolved WC Triage Andreas Dilger e2fsprogs easy Tue, 9 May 2023 22:00:28 +0000 Tue, 9 May 2023 22:00:48 +0000 0 2 Development Rank 1|i03kvz: Rank (Obsolete) 9223372036854775807 Severity