<!-- 
RSS generated by JIRA (9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c) at Sat Feb 10 03:30:24 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Whamcloud Community JIRA</title>
    <link>https://jira.whamcloud.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.4.14</version>
        <build-number>940014</build-number>
        <build-date>05-12-2023</build-date>
    </build-info>


<item>
            <title>[LU-16835] lustre-initialization: Operation not supported while trying to set fs label, tune2fs 1.47.0-wc1</title>
                <link>https://jira.whamcloud.com/browse/LU-16835</link>
                <project id="10000" key="LU">Lustre</project>
                    <description>&lt;p&gt;This issue was created by maloo for Andreas Dilger &amp;lt;adilger@whamcloud.com&amp;gt;&lt;/p&gt;

&lt;p&gt;This issue relates to the following test suite runs:&lt;br/&gt;
&lt;a href=&quot;https://testing.whamcloud.com/test_sets/1aec9220-17f7-4e40-831b-e742497b94e7&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://testing.whamcloud.com/test_sets/1aec9220-17f7-4e40-831b-e742497b94e7&lt;/a&gt;&lt;br/&gt;
&lt;a href=&quot;https://testing.whamcloud.com/test_sets/f1b438e1-bcd1-448a-aaab-fce424899d3f&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://testing.whamcloud.com/test_sets/f1b438e1-bcd1-448a-aaab-fce424899d3f&lt;/a&gt;&lt;br/&gt;
&lt;a href=&quot;https://testing.whamcloud.com/test_sets/b8ab97a5-4f83-4a85-918c-56f732236ba8&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://testing.whamcloud.com/test_sets/b8ab97a5-4f83-4a85-918c-56f732236ba8&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;lustre-initialization failed with the following error:&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;2023-05-12T14:31:49 CMD: onyx-113vm10 mkdir -p /mnt/lustre-mds1; mount -t lustre -o localrecov  /dev/mapper/mds1_flakey /mnt/lustre-mds1
2023-05-12T14:31:49    /mnt/lustre-mds1: Operation not supported while trying to set fs label
2023-05-12T14:31:49    tune2fs 1.47.0-wc1 (28-Apr-2023)
2023-05-12T14:31:54 CMD: onyx-113vm10 e2label /dev/mapper/mds1_flakey 				2&amp;gt;/dev/null | grep -E &apos;:[a-zA-Z]{3}[0-9]{4}&apos;
2023-05-12T14:31:54 pdsh@onyx-91vm5: onyx-113vm10: ssh exited with exit code 1
2023-05-12T14:31:54 Commit the device label on /dev/lvm-Role_MDS/P1
2023-05-12T14:31:54 CMD: onyx-113vm10 sync; sleep 1; sync
2023-05-12T14:31:59 CMD: onyx-113vm10 e2label /dev/mapper/mds1_flakey 2&amp;gt;/dev/null
2023-05-12T14:31:59 pdsh@onyx-91vm5: onyx-113vm10: ssh exited with exit code 1
2023-05-12T14:31:59 no label for /dev/mapper/mds1_flakey
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;Test session details:&lt;br/&gt;
clients: &lt;a href=&quot;https://build.whamcloud.com/job/lustre-master-next/703&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://build.whamcloud.com/job/lustre-master-next/703&lt;/a&gt; - 4.18.0-372.9.1.el8.aarch64&lt;br/&gt;
servers: &lt;a href=&quot;https://build.whamcloud.com/job/lustre-master-next/703&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://build.whamcloud.com/job/lustre-master-next/703&lt;/a&gt; - 4.18.0-372.32.1.el8_lustre.x86_64&lt;/p&gt;

&lt;p&gt;This may be related to the update to use e2fsprogs-1.47.0-wc1, which may have added support for new ioctl() to get/set the filesystem label (&lt;tt&gt;FS_IOC_GETFSLABEL&lt;/tt&gt; and &lt;tt&gt;FS_IOC_SETFSLABEL&lt;/tt&gt;) but this was added only in kernel v5.16-rc4-36-gbbc605cdb1e1.  It may be that the fallback for older kernels is not working?&lt;/p&gt;







&lt;p&gt;VVVVVVV DO NOT REMOVE LINES BELOW, Added by Maloo for auto-association VVVVVVV&lt;br/&gt;
lustre-initialization lustre-initialization - &quot;lustre-initialization timed out&quot;&lt;/p&gt;</description>
                <environment></environment>
        <key id="76120">LU-16835</key>
            <summary>lustre-initialization: Operation not supported while trying to set fs label, tune2fs 1.47.0-wc1</summary>
                <type id="1" iconUrl="https://jira.whamcloud.com/secure/viewavatar?size=xsmall&amp;avatarId=11303&amp;avatarType=issuetype">Bug</type>
                                            <priority id="4" iconUrl="https://jira.whamcloud.com/images/icons/priorities/minor.svg">Minor</priority>
                        <status id="1" iconUrl="https://jira.whamcloud.com/images/icons/statuses/open.png" description="The issue is open and ready for the assignee to start work on it.">Open</status>
                    <statusCategory id="2" key="new" colorName="default"/>
                                    <resolution id="-1">Unresolved</resolution>
                                        <assignee username="dongyang">Dongyang Li</assignee>
                                    <reporter username="maloo">Maloo</reporter>
                        <labels>
                    </labels>
                <created>Wed, 17 May 2023 19:13:21 +0000</created>
                <updated>Tue, 4 Jul 2023 04:06:08 +0000</updated>
                                            <version>Lustre 2.16.0</version>
                                    <fixVersion>Lustre 2.16.0</fixVersion>
                                        <due></due>
                            <votes>0</votes>
                                    <watches>7</watches>
                                                                            <comments>
                            <comment id="372995" author="adilger" created="Fri, 19 May 2023 20:38:29 +0000"  >&lt;p&gt;It  looks like e2fsprogs upstream commit v1.46.5-78-ga83e199da &quot;&lt;tt&gt;tune2fs: Add support for get/set UUID ioctls&lt;/tt&gt;&quot; is at least partly responsible for this issue.  It may also relate to an update to the kernel that backported these ioctls to an older kernel that is triggering the error, or possibly it was never tested on an older kernel without this functionality?&lt;/p&gt;</comment>
                            <comment id="372996" author="adilger" created="Fri, 19 May 2023 20:47:01 +0000"  >&lt;p&gt;It looks like this error might be coming from  the following code in &lt;tt&gt;ext4_ioctl()&lt;/tt&gt;:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
        /*
         * If any checksums (group descriptors or metadata) are being used
         * then the checksum seed feature is required to change the UUID.
         */
        &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (((ext4_has_feature_gdt_csum(sb) || ext4_has_metadata_csum(sb))
                        &amp;amp;&amp;amp; !ext4_has_feature_csum_seed(sb))
                || ext4_has_feature_stable_inodes(sb))
                &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; -EOPNOTSUPP;

&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;since we do not enable the &lt;tt&gt;EXT4_FEATURE_INCOMPAT_CSUM_SEED&lt;/tt&gt; on any Lustre filesystems, since we also do not handle the &lt;tt&gt;METADATA_CSUM&lt;/tt&gt; feature.  However, we &lt;b&gt;do&lt;/b&gt; enable &lt;tt&gt;GDT_CSUM&lt;/tt&gt;, which seems to be tripping this check up.  However, &lt;tt&gt;tune2fs&lt;/tt&gt; &lt;b&gt;should&lt;/b&gt; just ignore any such error and fall back to modify the superblock directly in that case.&lt;/p&gt;

&lt;p&gt;It looks like the bug is at:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
+
+               ret = -1;
+#ifdef __linux__
+               &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (fsuuid) {
+                       fsuuid-&amp;gt;fsu_len - UUID_SIZE;
+                       fsuuid-&amp;gt;fsu_flags = 0;
+                       memcpy(&amp;amp;fsuuid-&amp;gt;fsu_uuid, new_uuid, UUID_SIZE);
+                       ret = ioctl(fd, EXT4_IOC_SETFSUUID, fsuuid);
+               }
+#endif
+               ret = -1;
+               /*
+                * If we can&apos;t set the UUID via the ioctl, fall
+                * back to directly modifying the superblock
+                .*/
+               &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (ret) {
+                       memcpy(sb-&amp;gt;s_uuid, new_uuid, UUID_SIZE);
+                       ext2fs_init_csum_seed(fs);
+                       &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (set_csum) {
+                               &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; (i = 0; i &amp;lt; fs-&amp;gt;group_desc_count; i++)
+                                       ext2fs_group_desc_csum_set(fs, i);
+                               fs-&amp;gt;flags &amp;amp;= ~EXT2_FLAG_SUPER_ONLY;
+                       }
+                       ext2fs_mark_super_dirty(fs);
                }
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;In the fallback case (with Linux, and newer kernel that has &lt;tt&gt;EXT4_IOC_SETFSUUID&lt;/tt&gt; but filesystem with no &lt;tt&gt;CSUM_SEED&lt;/tt&gt; feature), it does not clear &quot;&lt;tt&gt;ret&lt;/tt&gt;&quot; so &quot;&lt;tt&gt;errno = EOPNOTSUPP&lt;/tt&gt;&quot; returned from the kernel is still hit.&lt;/p&gt;</comment>
                            <comment id="372998" author="gerrit" created="Fri, 19 May 2023 21:02:33 +0000"  >&lt;p&gt;&lt;del&gt;&quot;Andreas Dilger &amp;lt;adilger@whamcloud.com&amp;gt;&quot; uploaded a new patch:&lt;/del&gt; &lt;a href=&quot;https://review.whamcloud.com/c/tools/e2fsprogs/+/51068&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/c/tools/e2fsprogs/+/51068&lt;/a&gt;&lt;br/&gt;
&lt;del&gt;Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-16835&quot; title=&quot;lustre-initialization: Operation not supported while trying to set fs label, tune2fs 1.47.0-wc1&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-16835&quot;&gt;LU-16835&lt;/a&gt; tune2fs: reset ioctl error for old filesystem&lt;/del&gt;&lt;br/&gt;
&lt;del&gt;Project: tools/e2fsprogs&lt;/del&gt;&lt;br/&gt;
&lt;del&gt;Branch: master-lustre&lt;/del&gt;&lt;br/&gt;
&lt;del&gt;Current Patch Set: 1&lt;/del&gt;&lt;br/&gt;
&lt;del&gt;Commit: ea443cd29253837b82625de8bfe9147cc60c45a3&lt;/del&gt;&lt;/p&gt;</comment>
                            <comment id="373036" author="dongyang" created="Sat, 20 May 2023 07:34:34 +0000"  >&lt;p&gt;I used bpftrace and it confirms ioctl((FS_IOC_GETFSLABEL) does return EOPNOTSUPP as the error message suggested.&lt;br/&gt;
I was struggling to see where does the EOPNOTSUPP come from, as from ext4 level we either return ENOTTY or ENOIOCTLCMD. and from the ioctl syscall level it sets the return value to ENOTTY when it sees ENOIOCTLCMD.&lt;br/&gt;
Then I used a combination of trace-cmd and bpftrace it turns out the ioctl lands on the mount point and goes down to server_ioctl() provided by lustre, and server_ioctl() returns EOPNOTSUPP.&lt;/p&gt;

&lt;p&gt;Adding EOPNOTSUPP check in tune2fs will work, but I doubt upstream will like it, server_ioctl() should really just return ENOTTY and e2label will fallback to old ways to set/get label.&lt;/p&gt;

&lt;p&gt;Now, ATM-2790 actually shows a different issue, the handle_fslable() from tune2fs just quits if it fails to open the mount point. I think in this case we should just fallback to old method as well and no com_err is needed.&lt;br/&gt;
I will prepare the patches and send the tune2fs patch upstream.&lt;/p&gt;</comment>
                            <comment id="373038" author="gerrit" created="Sat, 20 May 2023 07:53:23 +0000"  >&lt;p&gt;&quot;Li Dongyang &amp;lt;dongyangli@ddn.com&amp;gt;&quot; uploaded a new patch: &lt;a href=&quot;https://review.whamcloud.com/c/fs/lustre-release/+/51072&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/c/fs/lustre-release/+/51072&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-16835&quot; title=&quot;lustre-initialization: Operation not supported while trying to set fs label, tune2fs 1.47.0-wc1&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-16835&quot;&gt;LU-16835&lt;/a&gt; target: server_ioctl() should return ENOTTY&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: 1&lt;br/&gt;
Commit: 0f25e703321336f82e0a6468bce7cb08051c3fb0&lt;/p&gt;</comment>
                            <comment id="373040" author="gerrit" created="Sat, 20 May 2023 10:35:06 +0000"  >&lt;p&gt;&quot;Li Dongyang &amp;lt;dongyangli@ddn.com&amp;gt;&quot; uploaded a new patch: &lt;a href=&quot;https://review.whamcloud.com/c/tools/e2fsprogs/+/51073&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/c/tools/e2fsprogs/+/51073&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-16835&quot; title=&quot;lustre-initialization: Operation not supported while trying to set fs label, tune2fs 1.47.0-wc1&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-16835&quot;&gt;LU-16835&lt;/a&gt; tune2fs: fall back to old get/set fs label on error&lt;br/&gt;
Project: tools/e2fsprogs&lt;br/&gt;
Branch: master-lustre&lt;br/&gt;
Current Patch Set: 1&lt;br/&gt;
Commit: af2a97f298bdda26f9b900ae53b76e779e957872&lt;/p&gt;</comment>
                            <comment id="373094" author="gerrit" created="Mon, 22 May 2023 08:37:00 +0000"  >&lt;p&gt;&lt;del&gt;&quot;Andreas Dilger &amp;lt;adilger@whamcloud.com&amp;gt;&quot; uploaded a new patch:&lt;/del&gt; &lt;a href=&quot;https://review.whamcloud.com/c/fs/lustre-release/+/51081&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/c/fs/lustre-release/+/51081&lt;/a&gt;&lt;br/&gt;
&lt;del&gt;Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-16835&quot; title=&quot;lustre-initialization: Operation not supported while trying to set fs label, tune2fs 1.47.0-wc1&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-16835&quot;&gt;LU-16835&lt;/a&gt; revert: &quot;&lt;a href=&quot;https://jira.whamcloud.com/browse/LU-137&quot; title=&quot;ioctl passthrough mechanism for Lustre OST/MDT mountpoints&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-137&quot;&gt;&lt;del&gt;LU-137&lt;/del&gt;&lt;/a&gt; osd-ldiskfs: pass through resize ioctl&quot;&lt;/del&gt;&lt;br/&gt;
&lt;del&gt;Project: fs/lustre-release&lt;/del&gt;&lt;br/&gt;
&lt;del&gt;Branch: master&lt;/del&gt;&lt;br/&gt;
&lt;del&gt;Current Patch Set: 1&lt;/del&gt;&lt;br/&gt;
&lt;del&gt;Commit: 973446ff6ade4d01612bbbf9d0cfe0ab7ec3fc13&lt;/del&gt;&lt;/p&gt;</comment>
                            <comment id="373095" author="gerrit" created="Mon, 22 May 2023 08:40:29 +0000"  >&lt;p&gt;&quot;Andreas Dilger &amp;lt;adilger@whamcloud.com&amp;gt;&quot; merged in patch &lt;a href=&quot;https://review.whamcloud.com/c/fs/lustre-release/+/51072/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/c/fs/lustre-release/+/51072/&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-16835&quot; title=&quot;lustre-initialization: Operation not supported while trying to set fs label, tune2fs 1.47.0-wc1&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-16835&quot;&gt;LU-16835&lt;/a&gt; target: server_ioctl() should return ENOTTY&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: &lt;br/&gt;
Commit: aadc6de18ed9af8f26cc829faa5643f8b4f0bba7&lt;/p&gt;</comment>
                            <comment id="373412" author="gerrit" created="Thu, 25 May 2023 01:47:45 +0000"  >&lt;p&gt;&quot;Li Dongyang &amp;lt;dongyangli@ddn.com&amp;gt;&quot; merged in patch &lt;a href=&quot;https://review.whamcloud.com/c/tools/e2fsprogs/+/51073/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/c/tools/e2fsprogs/+/51073/&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-16835&quot; title=&quot;lustre-initialization: Operation not supported while trying to set fs label, tune2fs 1.47.0-wc1&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-16835&quot;&gt;LU-16835&lt;/a&gt; tune2fs: fall back to old get/set fs label on error&lt;br/&gt;
Project: tools/e2fsprogs&lt;br/&gt;
Branch: master-lustre&lt;br/&gt;
Current Patch Set: &lt;br/&gt;
Commit: c6af13873a5b1102126fcedb93abeda93132e3ef&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Related</name>
                                            <outwardlinks description="is related to ">
                                        <issuelink>
            <issuekey id="10459">LU-137</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="is related to">
                                        <issuelink>
            <issuekey id="76437">LU-16879</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                            <customfield id="customfield_10890" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10390" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i03lrr:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10060" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Severity</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10022"><![CDATA[3]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>