https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-17052 Lustre <p>Recent commit "778791dd7d <a href="https://jira.whamcloud.com/browse/LU-8130" title="Migrate from libcfs hash to rhashtable" class="issue-link" data-issue-key="LU-8130">LU-8130</a> libcfs: don't use radix tree for xarray" breaks build on old kernel 4.17-4.19:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> make[3]: Entering directory <span class="code-quote">'/usr/src/kernels/4.19.90-2308.2.0.0213.oe1.aarch64'</span>   CC [M]  /home/openeuler/lustre-release/libcfs/libcfs/linux/linux-prim.o /home/openeuler/lustre-release/libcfs/libcfs/linux/linux-prim.c: In function ‘xarray_node_ctor’: /home/openeuler/lustre-release/libcfs/libcfs/linux/linux-prim.c:129:25: error: dereferencing pointer to incomplete type ‘struct xa_node’   memset(node, 0, sizeof(*node));                          ^~~~~ /home/openeuler/lustre-release/libcfs/libcfs/linux/linux-prim.c: In function ‘cfs_arch_init’: /home/openeuler/lustre-release/libcfs/libcfs/linux/linux-prim.c:143:15: error: invalid application of ‘sizeof’ to incomplete type ‘struct xa_node’         sizeof(struct xa_node), 0,                ^~~~~~ /home/openeuler/lustre-release/libcfs/libcfs/linux/linux-prim.c: At top level: </pre> </div></div> LU-17052

inux-prim.c:129:25: error: dereferencing pointer to incomplete type ‘struct xa_node’

Bug Minor Resolved Fixed Xinliang Liu Xinliang Liu Fri, 25 Aug 2023 02:35:43 +0000 Wed, 6 Sep 2023 13:09:58 +0000 Wed, 6 Sep 2023 13:09:58 +0000 Lustre 2.16.0 0 2 <p>This break build might affect old kernel from v4.17 to v4.19. Because v4.17 adds &lt;linux/xarray.h&gt; and make fs.h #include  &lt;linux/xarray.h&gt;, v4.20 introduces full xarray support.</p> <p>The cause is that fs.h(from kernel v4.17 commit b93b016313b3) is already included &lt;linux/xarray.h&gt;, so #include &lt;libcfs/linux/xarray.h&gt; which contains the definition of 'struct xa_node'  don't take effect.</p> <p> </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> cat libcfs/libcfs/linux/linux-prim.c ... #include &lt;linux/fs.h&gt; ... #ifndef HAVE_XARRAY_SUPPORT #include &lt;libcfs/linux/xarray.h&gt; #endif </pre> </div></div> <p> </p> <p> </p> <p>"xinliang &lt;xinliang.liu@linaro.org&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/52090" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/52090</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-17052" title="inux-prim.c:129:25: error: dereferencing pointer to incomplete type ‘struct xa_node’" class="issue-link" data-issue-key="LU-17052"><del>LU-17052</del></a> libcfs: fix build for old kernel<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: faab3d6bd3d898b6e849705476318e82210a7c09</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/52090/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/52090/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-17052" title="inux-prim.c:129:25: error: dereferencing pointer to incomplete type ‘struct xa_node’" class="issue-link" data-issue-key="LU-17052"><del>LU-17052</del></a> libcfs: fix build for old kernel<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 75dd69dd6ecac38267a8fbf475945b2a2f293ba9</p> <p>Landed for 2.16</p> Development Rank 1|i03twf: Rank (Obsolete) 9223372036854775807 Severity