https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-1715 Lustre <p>flock deadlocks are checked on the first attempt to grant the flock only. if we try again to grant it after its blocking lock is cancelled, we do not check for deadlocks which also may exist.</p> <p>the reproducer is attached, its output is the following:<br/> 4730: sleeping 1<br/> 4731: taking lock0 <span class="error">&#91;0, 100&#93;</span><br/> 4732: taking lock1 <span class="error">&#91;100, 200&#93;</span><br/> 4731: done<br/> 4731 sleeping 1<br/> 4732: done<br/> 4732 sleeping 2<br/> 4730: taking lock2 <span class="error">&#91;200, 300&#93;</span><br/> 4730: done<br/> 4730: taking lock0 <span class="error">&#91;0, 100&#93;</span><br/> 4731: taking lock3 <span class="error">&#91;100, 300&#93;</span><br/> 4732: putting lock1 <span class="error">&#91;100, 200&#93;</span><br/> 4732: done<br/> 4732 Exit<br/> --&gt; it is waiting forever here.</p> LU-1715

flock deadlock detection does not work properly

Bug Minor Resolved Fixed Keith Mannthey Andriy Skulysh patch Tue, 7 Aug 2012 08:17:31 +0000 Wed, 21 Aug 2013 16:29:51 +0000 Sat, 10 Aug 2013 00:42:54 +0000 Lustre 2.5.0 0 6 <p><a href="http://review.whamcloud.com/3553" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/3553</a></p> <p>Xyratex-bug-id: <a href="http://jira-nss.xy01.xyratex.com:8080/browse/MRP-393" class="external-link" target="_blank" rel="nofollow noopener">MRP-393</a></p> <p>Looks like this has been sitting for a bit. Please rebase the patch if it is still a desired change. </p> <p>I have a problem with adding new ldlm flag. It looks like master uses autogen to generate lustre_dlm_flags.h<br/> I've added flag description to lustre_dlm_flags.def but observe following error : </p> <p>$ pwd<br/> /local/work/lustre-release/contrib/bit-masks<br/> $ make<br/> + autogen --version<br/> + autogen -DTESTING=1 lustre_dlm_flags.def<br/> /bin/bash: line 46: .: script.sh: file not found<br/> columns: illegal option &#8211; end= };<br/> columns (GNU AutoGen) - Columnize Input Text - Ver. 1.2<br/> USAGE: columns [ -&lt;flag&gt; <span class="error">&#91;&lt;val&gt;&#93;</span> | --&lt;name&gt;[</p> {=| }&lt;val&gt;] ]...<br/> Flg Arg Option-Name Description<br/> -W Num width Maximum Line Width<br/> -c Num columns Desired number of columns<br/> -w Num col-width Set width of each column<br/> Num spread maximum spread added to column width<br/> no fill Fill lines with input<br/> -I Str indent Line prefix or indentation<br/> Str first-indent First line prefix<br/> Num tab-width tab width<br/> -s opt sort Sort input text<br/> -f Str format Formatting string for each input<br/> -S Str separation Separation string - follows all but last<br/> Str line-separation string at end of all lines but last<br/> no by-columns Print entries in column order<br/> -i Str input Input file (if not stdin)<br/> -v opt version Output version information and exit<br/> -? no help Display usage information and exit<br/> -! no more-help Extended usage information passed thru pager<br/> -&gt; opt save-opts Save the option state to a config file<br/> -&lt; Str load-opts Load options from a config file<br/> <br/> Options are specified by doubled hyphens and their name<br/> or by a single hyphen and the flag character.<br/> <br/> please send bug reports to: autogen-users@lists.sourceforge.net<br/> columns: illegal option &#8211; end= };<br/> columns (GNU AutoGen) - Columnize Input Text - Ver. 1.2<br/> USAGE: columns [ -&lt;flag&gt; <span class="error">&#91;&lt;val&gt;&#93;</span> | --&lt;name&gt;[{=| } <p>&lt;val&gt;] ]...<br/> Flg Arg Option-Name Description<br/> -W Num width Maximum Line Width<br/> -c Num columns Desired number of columns<br/> -w Num col-width Set width of each column<br/> Num spread maximum spread added to column width<br/> no fill Fill lines with input<br/> -I Str indent Line prefix or indentation<br/> Str first-indent First line prefix<br/> Num tab-width tab width<br/> -s opt sort Sort input text<br/> -f Str format Formatting string for each input<br/> -S Str separation Separation string - follows all but last<br/> Str line-separation string at end of all lines but last<br/> no by-columns Print entries in column order<br/> -i Str input Input file (if not stdin)<br/> -v opt version Output version information and exit<br/> -? no help Display usage information and exit<br/> -! no more-help Extended usage information passed thru pager<br/> -&gt; opt save-opts Save the option state to a config file<br/> -&lt; Str load-opts Load options from a config file</p> <p>Options are specified by doubled hyphens and their name<br/> or by a single hyphen and the flag character.</p> <p>please send bug reports to: autogen-users@lists.sourceforge.net<br/> + rm -f ../../lustre/include/lustre_dlm_flags.h<br/> + sed '/It has been AutoGen-ed/s/-ed.*/-ed/;s/ *$//' lustre_dlm_flags.h</p> <p>I've installed autogen-5.9.4-7 using :<br/> $ yum --enablerepo=epel-testing install autogen</p> <p>How autogen is supposed to be executed ? manually or during Lustre make ?<br/> BTW script.sh is generated in the current directory and I managed to patch lustre_dlm_flags.tpl to execute it from current directory.</p> <p>You do need to run autogen.sh Manually. When I make Lustre by hand I run ./autogen.sh in the top level directory before I do anything else. </p> <p>A rough guide for building dev builds by hand can be seen here: <a href="https://wiki.hpdd.intel.com/display/PUB/Walk-thru-+Build+Lustre+MASTER+on+RHEL+6.3+from+Whamcloud+git" class="external-link" target="_blank" rel="nofollow noopener">https://wiki.hpdd.intel.com/display/PUB/Walk-thru-+Build+Lustre+MASTER+on+RHEL+6.3+from+Whamcloud+git</a></p> <p>My basic build steps are:<br/> ./autogen.sh <br/> ./configure ....<br/> make </p> <p>I will keep an eye on your new patch to see if it build in the autotest system.</p> <p>Of course I run autogen.sh, but it doesn't generate lustre_dlm_flags.h. Another executable autogen (without .sh) <a href="http://www.gnu.org/software/autogen/" class="external-link" target="_blank" rel="nofollow noopener">http://www.gnu.org/software/autogen/</a> is needed to do this job.</p> <p>Bruce added the auto build of the LDLM flags, perhaps he can comment on how this should be done correctly, if it isn't automatically generated by make. </p> <blockquote><p>Bruce added the auto build of the LDLM flags, perhaps he can comment on how this should be done correctly</p></blockquote> <p>To have it automatically done by make would require that autogen be installed by builders of Lustre. You can install it for any distro, but you have to explicitly request it in a distro-specific way.</p> <blockquote><p>You do need to run autogen.sh Manually</p></blockquote> <p>Well, no. "autogen.sh" has nothing whatever to do with autogen. I offered to help the Gnome project regenerate some of their pre-configure sources, but they declined the help, still used the name for their bootstrap process and it became a "standard" name for bootstrapping projects. I advocate renaming autogen.sh to bootstrap.sh. Anyway, the method for rebuilding the flags (once autogen is installed) is:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">cd contrib/bit-masks &amp;&amp; make</pre> </div></div> <p>P.S. the output should be:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>$ autogen --version autogen (GNU AutoGen) 5.17.1 $ make &gt;sh&gt; autogen --version &gt;sh&gt; autogen -DTESTING=1 lustre_dlm_flags.def &gt;sh&gt; rm -f ../../lustre/include/lustre_dlm_flags.h &gt;sh&gt; sed '/It has been AutoGen-ed/s/-ed.*/-ed/;s/ *$//' lustre_dlm_flags.h $ </pre> </div></div> <p>I don't think the actual version makes much difference.</p> <p>Master patch has been merged. </p> Related LU-3783 Development Rank 1|hzvq27: Rank (Obsolete) 8095 Severity