https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-17398 Lustre <p>rpmbuild reports the following warning:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>00:08:26.905 sh: -c: line 0: syntax error near unexpected token `)' 00:08:26.905 sh: -c: line 0: `)' 00:08:26.905 warning: Macro expanded in comment on line 261: %() </pre> </div></div> <p>However the root cause if this entire 3 lines of warning is a %() found in comment.<br/> Rewrite the comment to escape the %() as %%() ... and suppress the warning.</p> LU-17398

Quash rpmbuild false warning due to %() in comment

Improvement Minor Resolved Fixed Shaun Tancheff Shaun Tancheff Sat, 6 Jan 2024 15:09:47 +0000 Tue, 30 Jan 2024 22:14:08 +0000 Wed, 10 Jan 2024 14:59:00 +0000 Lustre 2.16.0 0 6 <p>"Shaun Tancheff &lt;shaun.tancheff@hpe.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/53604" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/53604</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-17398" title="Quash rpmbuild false warning due to %() in comment" class="issue-link" data-issue-key="LU-17398"><del>LU-17398</del></a> build: quash rpmbuild false warning<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 51b601b66792ee5b0e594b540f323c39fd427330</p> <p>"Shaun Tancheff &lt;shaun.tancheff@hpe.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/53613" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/53613</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-17398" title="Quash rpmbuild false warning due to %() in comment" class="issue-link" data-issue-key="LU-17398"><del>LU-17398</del></a> build: detect mlnx-ofa_kernel-devel contents<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: a16751e16167be9caa1a79a412817815d64e84b9</p> <p>I've attached logs from the failed builds:</p> <ul class="alternate" type="square"> <li><span class="nobr"><a href="https://jira.whamcloud.com/secure/attachment/51589/51589_lustre-master-next-756-x86_86.txt" title="lustre-master-next-756-x86_86.txt attached to LU-17398">lustre-master-next-756-x86_86.txt^{<img class="rendericon" src="https://jira.whamcloud.com/images/icons/link_attachment_7.gif" height="7" width="7" align="absmiddle" alt="" border="0"/>}</a></span> patch <a href="https://review.whamcloud.com/53604" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/53604</a> "<tt><a href="https://jira.whamcloud.com/browse/LU-17398" title="Quash rpmbuild false warning due to %() in comment" class="issue-link" data-issue-key="LU-17398"><del>LU-17398</del></a> build: quash rpmbuild false warning</tt>"</li> <li><span class="nobr"><a href="https://jira.whamcloud.com/secure/attachment/51590/51590_lustre-reviews-ib-6871-x86_86.txt" title="lustre-reviews-ib-6871-x86_86.txt attached to LU-17398">lustre-reviews-ib-6871-x86_86.txt^{<img class="rendericon" src="https://jira.whamcloud.com/images/icons/link_attachment_7.gif" height="7" width="7" align="absmiddle" alt="" border="0"/>}</a></span> patch <a href="https://review.whamcloud.com/53613" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/53613</a> "<tt><a href="https://jira.whamcloud.com/browse/LU-17398" title="Quash rpmbuild false warning due to %() in comment" class="issue-link" data-issue-key="LU-17398"><del>LU-17398</del></a> build: detect mlnx-ofa_kernel-devel contents</tt>"</li> </ul> <p>The 53604 patch resolved the syntax error/warning, but 53613 has not yet resolved the MOFED IB build failure, though it has changed the mode of failure. It no longer complains about <tt>BuildRequires</tt> but hits an error later during the build (you may not be able to access the URL, but this is the <span class="nobr"><a href="https://jira.whamcloud.com/secure/attachment/51590/51590_lustre-reviews-ib-6871-x86_86.txt" title="lustre-reviews-ib-6871-x86_86.txt attached to LU-17398">lustre-reviews-ib-6871-x86_86.txt^{<img class="rendericon" src="https://jira.whamcloud.com/images/icons/link_attachment_7.gif" height="7" width="7" align="absmiddle" alt="" border="0"/>}</a></span> log that is attached):<br/> <a href="https://build.whamcloud.com/job/lustre-reviews-ib/6871/arch=x86_64,build_type=client,distro=el9.1,ib_stack=mlx/console" class="external-link" target="_blank" rel="nofollow noopener">https://build.whamcloud.com/job/lustre-reviews-ib/6871/arch=x86_64,build_type=client,distro=el9.1,ib_stack=mlx/console</a></p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>00:07:30.741 + export OMPI_MCA_rmaps_base_oversubscribe=1 00:07:30.741 + OMPI_MCA_rmaps_base_oversubscribe=1 00:07:30.741 + WITH_O2IB= 00:07:30.741 ++ find /usr/src/ofa_kernel/ -type d -name ofed_scripts 00:07:30.742 ++ xargs dirname 00:07:30.743 find: '/usr/src/ofa_kernel/': No such file or directory 00:07:30.743 dirname: missing operand 00:07:30.743 Try 'dirname --help' for more information. 00:07:30.744 + o2ib_path= 00:07:30.744 error: Bad exit status from /tmp/rpmbuild-lustre-jenkins-szUKCBIl/TMP/rpm-tmp.UzokKA (%build) </pre> </div></div> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> 610 WITH_O2IB="" 611 %<span class="code-keyword">if</span> %{with mofed} 612 ▶·······o2ib_path=$(find /usr/src/ofa_kernel/ -type d -name ofed_scripts | xargs dirname) 613 ▶·······<span class="code-keyword">if</span> [ -z <span class="code-quote">"$o2ib_path"</span> ]; then </pre> </div></div> <p>Need to check if /usr/src/ofa_kernel exists</p> <p>The most recent version of patch <a href="https://review.whamcloud.com/53613" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/53613</a> "<tt><a href="https://jira.whamcloud.com/browse/LU-17398" title="Quash rpmbuild false warning due to %() in comment" class="issue-link" data-issue-key="LU-17398"><del>LU-17398</del></a> build: detect mlnx-ofa_kernel-devel contents</tt>" resolves the MOFED build issue. </p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/53604/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/53604/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-17398" title="Quash rpmbuild false warning due to %() in comment" class="issue-link" data-issue-key="LU-17398"><del>LU-17398</del></a> build: quash rpmbuild false warning<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: fdab3f6455c99072d2b4e93e176432cd7f5d3c2f</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/53613/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/53613/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-17398" title="Quash rpmbuild false warning due to %() in comment" class="issue-link" data-issue-key="LU-17398"><del>LU-17398</del></a> build: detect mlnx-ofa_kernel-devel contents<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 3c66185c84c94c47f5d8031b92165c68ef666e0e</p> <p>Merged for 2.16</p> <p>this patch contains a regression. see <a href="https://jira.whamcloud.com/browse/LU-17487" title="parsing --with-o2ib fails" class="issue-link" data-issue-key="LU-17487">LU-17487</a></p> Related LU-16967 LU-17487 Development Rank 1|i046in: Rank (Obsolete) 9223372036854775807 Severity