https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-1747 Lustre <p>This leads to "cp -p" failures when copying files without ACLs. For example, sanity 103 may fail at "<span class="error">&#91;22&#93;</span>". Deleting a nonexistent attribute, at least if it is "system.posix_acl_access", should succeed. That's also what ext4_xattr_acl_access_handler does.</p> LU-1747

osd_xattr_del() in osd-zfs returns -ENOENT when deleting nonexistent "system.posix_acl_access"

Bug Blocker Resolved Fixed Minh Diep Li Wei Wed, 15 Aug 2012 01:53:29 +0000 Wed, 19 Sep 2012 02:10:12 +0000 Tue, 18 Sep 2012 11:46:39 +0000 Lustre 2.4.0 Lustre 2.4.0 0 2 <p>I'd rather think the caller should expect -ENOENT as a valid return.</p> <p>Assign to Minh for landing on master.</p> <p>Looking at the ldiskfs code for the current semantics:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">/* * ext4_xattr_set_handle() * * Create, replace or remove an extended attribute <span class="code-keyword">for</span> <span class="code-keyword">this</span> inode. Value * is NULL to remove an existing extended attribute, and non-NULL to * either replace an existing extended attribute, or create a <span class="code-keyword">new</span> extended * attribute. The flags XATTR_REPLACE and XATTR_CREATE * specify that an extended attribute must exist and must not exist * previous to the call, respectively. * * Returns 0, or a negative error number on failure. */ <span class="code-object">int</span> ext4_xattr_set_handle(handle_t *handle, struct inode *inode, <span class="code-object">int</span> name_index, <span class="code-keyword">const</span> <span class="code-object">char</span> *name, <span class="code-keyword">const</span> void *value, size_t value_len, <span class="code-object">int</span> flags) { error = ext4_xattr_ibody_find(inode, &amp;i, &amp;is); <span class="code-keyword">if</span> (error) <span class="code-keyword">goto</span> cleanup; <span class="code-keyword">if</span> (is.s.not_found) error = ext4_xattr_block_find(inode, &amp;i, &amp;bs); <span class="code-keyword">if</span> (error) <span class="code-keyword">goto</span> cleanup; <span class="code-keyword">if</span> (is.s.not_found &amp;&amp; bs.s.not_found) { error = -ENODATA; <span class="code-keyword">if</span> (flags &amp; XATTR_REPLACE) <span class="code-keyword">goto</span> cleanup; error = 0; <span class="code-keyword">if</span> (!value) <span class="code-keyword">goto</span> cleanup; </pre> </div></div> <p>So only if <tt>XATTR_REPLACE</tt> is set does the deletion of a non-existent entry cause <tt>-ENODATA</tt> to be returned. We can't even pass <tt>XATTR_REPLACE</tt> to the MDS for xattr deletion, nor is it possible with the VFS <tt>&#45;&gt;removexattr()</tt> method, so we may as well keep this semantic of not returning an error when deleting a non-existent xattr in the ZFS OSD layer as well.</p> <p>This is a blocker for ZFS functionality on 2.4. It isn't strictly required for 2.3, since we don't support ZFS MDTs with 2.3.</p> <p>patch for master <a href="http://review.whamcloud.com/#change,3833" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,3833</a></p> <p>landed on master</p> <p>I'd like to hear opinions.. shouldn't MDD ignore such an error instead? </p> <p>Alex,</p> <p>osd-ldiskfs does not return an error when deleting a nonexistent "system.posix_acl_access" EA. Since that is not easy to change, osd-zfs shall do the same. Then, one concern is if osd-zfs should do the same for <em>all</em> EAs or just ACL ones. I think so far it looks "for all" is fine. If that ever becomes an issue, we can add EA name checks to osd-zfs.</p> <p>I was going to write the same as Li Wei. Since ldiskfs already hides this error, I have little motivation to patch the code just to discard the error at the MDD layer. </p> <p>ok, i'm fine with this then.</p> Development Rank 1|hzv5l3: Rank (Obsolete) 4439 Severity Story Points 1.0