https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-178 Lustre <p>Niu has found in <a href="https://jira.whamcloud.com/browse/LU-128" title="OSSs frequent crashes due to LBUG/[ASSERTION(last_rcvd&gt;=le64_to_cpu(lcd-&gt;lcd_last_transno)) failed] in recovery" class="issue-link" data-issue-key="LU-128"><del>LU-128</del></a> that there is race possible in target_handle_connect(). The server sets RECOVERING flag in reply but right after that the recovery is ended, so client is evicted and new connection is established. The client will start replaying over established connection and server accepts them fully.</p> <p>We have two problems here:<br/> 1) The race itself to be fixed so client shouldn't get RECOVERING flag for new connection.<br/> 2) The server must deny replay requests during normal processing otherwise it is possible to break transaction flow by malformed client which will send replays without recovery.</p> <p>I am going to add patches in gerrit for both problems.</p> LU-178

server can do replays after recovery

Bug Minor Resolved Fixed Niu Yawei Mikhail Pershin Tue, 29 Mar 2011 09:56:46 +0000 Thu, 23 Jun 2016 08:10:25 +0000 Thu, 23 Jun 2016 08:10:25 +0000 Lustre 2.1.0 Lustre 2.1.0 0 2 <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/reviews-centos5/634/" class="external-link" target="_blank" rel="nofollow noopener">reviews-centos5 #634</a><br/> <a href="https://jira.whamcloud.com/browse/LU-178" title="server can do replays after recovery" class="issue-link" data-issue-key="LU-178"><del>LU-178</del></a> prevent replays after recovery on server</p> <p>Mikhail Pershin : <a href="http://git.whamcloud.com/gitweb/?p=fs/lustre-release.git&amp;a=commit&amp;h=c5608451d7afcf50bfd535b2e3583667dc9b50ae" class="external-link" target="_blank" rel="nofollow noopener">c5608451d7afcf50bfd535b2e3583667dc9b50ae</a><br/> Files : </p> <ul> <li>lustre/ptlrpc/service.c</li> <li>lustre/include/obd_support.h</li> <li>lustre/mdt/mdt_handler.c</li> <li>lustre/ptlrpc/client.c</li> <li>lustre/tests/replay-single.sh</li> <li>lustre/ldlm/ldlm_lib.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el5,ib_stack=inkernel/110/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el5,inkernel #110</a><br/> <a href="https://jira.whamcloud.com/browse/LU-178" title="server can do replays after recovery" class="issue-link" data-issue-key="LU-178"><del>LU-178</del></a> prevent replays after recovery on server</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8" class="external-link" target="_blank" rel="nofollow noopener">5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8</a><br/> Files : </p> <ul> <li>lustre/tests/replay-single.sh</li> <li>lustre/ldlm/ldlm_lib.c</li> <li>lustre/mdt/mdt_handler.c</li> <li>lustre/ptlrpc/client.c</li> <li>lustre/include/obd_support.h</li> <li>lustre/ptlrpc/service.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el5,ib_stack=inkernel/110/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el5,inkernel #110</a><br/> <a href="https://jira.whamcloud.com/browse/LU-178" title="server can do replays after recovery" class="issue-link" data-issue-key="LU-178"><del>LU-178</del></a> prevent replays after recovery on server</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8" class="external-link" target="_blank" rel="nofollow noopener">5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8</a><br/> Files : </p> <ul> <li>lustre/mdt/mdt_handler.c</li> <li>lustre/tests/replay-single.sh</li> <li>lustre/ldlm/ldlm_lib.c</li> <li>lustre/ptlrpc/service.c</li> <li>lustre/include/obd_support.h</li> <li>lustre/ptlrpc/client.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=ubuntu1004,ib_stack=inkernel/110/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,ubuntu1004,inkernel #110</a><br/> <a href="https://jira.whamcloud.com/browse/LU-178" title="server can do replays after recovery" class="issue-link" data-issue-key="LU-178"><del>LU-178</del></a> prevent replays after recovery on server</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8" class="external-link" target="_blank" rel="nofollow noopener">5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8</a><br/> Files : </p> <ul> <li>lustre/mdt/mdt_handler.c</li> <li>lustre/ldlm/ldlm_lib.c</li> <li>lustre/include/obd_support.h</li> <li>lustre/ptlrpc/client.c</li> <li>lustre/tests/replay-single.sh</li> <li>lustre/ptlrpc/service.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el6,ib_stack=inkernel/110/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el6,inkernel #110</a><br/> <a href="https://jira.whamcloud.com/browse/LU-178" title="server can do replays after recovery" class="issue-link" data-issue-key="LU-178"><del>LU-178</del></a> prevent replays after recovery on server</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8" class="external-link" target="_blank" rel="nofollow noopener">5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8</a><br/> Files : </p> <ul> <li>lustre/tests/replay-single.sh</li> <li>lustre/ptlrpc/service.c</li> <li>lustre/ldlm/ldlm_lib.c</li> <li>lustre/include/obd_support.h</li> <li>lustre/ptlrpc/client.c</li> <li>lustre/mdt/mdt_handler.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el5,ib_stack=ofa/110/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el5,ofa #110</a><br/> <a href="https://jira.whamcloud.com/browse/LU-178" title="server can do replays after recovery" class="issue-link" data-issue-key="LU-178"><del>LU-178</del></a> prevent replays after recovery on server</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8" class="external-link" target="_blank" rel="nofollow noopener">5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8</a><br/> Files : </p> <ul> <li>lustre/mdt/mdt_handler.c</li> <li>lustre/ldlm/ldlm_lib.c</li> <li>lustre/include/obd_support.h</li> <li>lustre/tests/replay-single.sh</li> <li>lustre/ptlrpc/client.c</li> <li>lustre/ptlrpc/service.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el5,ib_stack=ofa/110/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el5,ofa #110</a><br/> <a href="https://jira.whamcloud.com/browse/LU-178" title="server can do replays after recovery" class="issue-link" data-issue-key="LU-178"><del>LU-178</del></a> prevent replays after recovery on server</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8" class="external-link" target="_blank" rel="nofollow noopener">5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8</a><br/> Files : </p> <ul> <li>lustre/ptlrpc/service.c</li> <li>lustre/include/obd_support.h</li> <li>lustre/tests/replay-single.sh</li> <li>lustre/ptlrpc/client.c</li> <li>lustre/mdt/mdt_handler.c</li> <li>lustre/ldlm/ldlm_lib.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el5,ib_stack=inkernel/110/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el5,inkernel #110</a><br/> <a href="https://jira.whamcloud.com/browse/LU-178" title="server can do replays after recovery" class="issue-link" data-issue-key="LU-178"><del>LU-178</del></a> prevent replays after recovery on server</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8" class="external-link" target="_blank" rel="nofollow noopener">5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8</a><br/> Files : </p> <ul> <li>lustre/ptlrpc/client.c</li> <li>lustre/include/obd_support.h</li> <li>lustre/mdt/mdt_handler.c</li> <li>lustre/ldlm/ldlm_lib.c</li> <li>lustre/tests/replay-single.sh</li> <li>lustre/ptlrpc/service.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=ubuntu1004,ib_stack=ofa/110/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,ubuntu1004,ofa #110</a><br/> <a href="https://jira.whamcloud.com/browse/LU-178" title="server can do replays after recovery" class="issue-link" data-issue-key="LU-178"><del>LU-178</del></a> prevent replays after recovery on server</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8" class="external-link" target="_blank" rel="nofollow noopener">5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8</a><br/> Files : </p> <ul> <li>lustre/ptlrpc/service.c</li> <li>lustre/tests/replay-single.sh</li> <li>lustre/include/obd_support.h</li> <li>lustre/mdt/mdt_handler.c</li> <li>lustre/ptlrpc/client.c</li> <li>lustre/ldlm/ldlm_lib.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el6,ib_stack=inkernel/110/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el6,inkernel #110</a><br/> <a href="https://jira.whamcloud.com/browse/LU-178" title="server can do replays after recovery" class="issue-link" data-issue-key="LU-178"><del>LU-178</del></a> prevent replays after recovery on server</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8" class="external-link" target="_blank" rel="nofollow noopener">5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8</a><br/> Files : </p> <ul> <li>lustre/tests/replay-single.sh</li> <li>lustre/ptlrpc/service.c</li> <li>lustre/mdt/mdt_handler.c</li> <li>lustre/include/obd_support.h</li> <li>lustre/ptlrpc/client.c</li> <li>lustre/ldlm/ldlm_lib.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el6,ib_stack=inkernel/110/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el6,inkernel #110</a><br/> <a href="https://jira.whamcloud.com/browse/LU-178" title="server can do replays after recovery" class="issue-link" data-issue-key="LU-178"><del>LU-178</del></a> prevent replays after recovery on server</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8" class="external-link" target="_blank" rel="nofollow noopener">5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8</a><br/> Files : </p> <ul> <li>lustre/include/obd_support.h</li> <li>lustre/ldlm/ldlm_lib.c</li> <li>lustre/ptlrpc/client.c</li> <li>lustre/ptlrpc/service.c</li> <li>lustre/mdt/mdt_handler.c</li> <li>lustre/tests/replay-single.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el5,ib_stack=ofa/110/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el5,ofa #110</a><br/> <a href="https://jira.whamcloud.com/browse/LU-178" title="server can do replays after recovery" class="issue-link" data-issue-key="LU-178"><del>LU-178</del></a> prevent replays after recovery on server</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8" class="external-link" target="_blank" rel="nofollow noopener">5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8</a><br/> Files : </p> <ul> <li>lustre/ldlm/ldlm_lib.c</li> <li>lustre/mdt/mdt_handler.c</li> <li>lustre/include/obd_support.h</li> <li>lustre/ptlrpc/service.c</li> <li>lustre/tests/replay-single.sh</li> <li>lustre/ptlrpc/client.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el6,ib_stack=inkernel/110/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el6,inkernel #110</a><br/> <a href="https://jira.whamcloud.com/browse/LU-178" title="server can do replays after recovery" class="issue-link" data-issue-key="LU-178"><del>LU-178</del></a> prevent replays after recovery on server</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8" class="external-link" target="_blank" rel="nofollow noopener">5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8</a><br/> Files : </p> <ul> <li>lustre/include/obd_support.h</li> <li>lustre/ptlrpc/service.c</li> <li>lustre/mdt/mdt_handler.c</li> <li>lustre/ldlm/ldlm_lib.c</li> <li>lustre/tests/replay-single.sh</li> <li>lustre/ptlrpc/client.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el5,ib_stack=inkernel/110/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el5,inkernel #110</a><br/> <a href="https://jira.whamcloud.com/browse/LU-178" title="server can do replays after recovery" class="issue-link" data-issue-key="LU-178"><del>LU-178</del></a> prevent replays after recovery on server</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8" class="external-link" target="_blank" rel="nofollow noopener">5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8</a><br/> Files : </p> <ul> <li>lustre/tests/replay-single.sh</li> <li>lustre/ptlrpc/client.c</li> <li>lustre/mdt/mdt_handler.c</li> <li>lustre/ldlm/ldlm_lib.c</li> <li>lustre/include/obd_support.h</li> <li>lustre/ptlrpc/service.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el5,ib_stack=ofa/110/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el5,ofa #110</a><br/> <a href="https://jira.whamcloud.com/browse/LU-178" title="server can do replays after recovery" class="issue-link" data-issue-key="LU-178"><del>LU-178</del></a> prevent replays after recovery on server</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8" class="external-link" target="_blank" rel="nofollow noopener">5d4ae6c905b8e8a38a6e4d3195f550a1e2b37ba8</a><br/> Files : </p> <ul> <li>lustre/ptlrpc/client.c</li> <li>lustre/include/obd_support.h</li> <li>lustre/mdt/mdt_handler.c</li> <li>lustre/ldlm/ldlm_lib.c</li> <li>lustre/tests/replay-single.sh</li> <li>lustre/ptlrpc/service.c</li> </ul> <p>Is any further work required or can this ticket be marked as resolved?</p> <p>Looks b1_8 has the same problem, we should port it to b1)8 as well.</p> <p>Niu,</p> <p>Do I understand correctly that this is a long-standing issue with recovery on 1.8.x?</p> <p>Peter</p> <p>Yes, I think so, at least current b1_8 has the same problem.</p> <p>There is no intention to backport the fix to b1_8. This can be closed.</p> Development Rank 1|hzv9bz: Rank (Obsolete) 5046 Severity