https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-1820 Lustre <p>ptlrpc_server_handle_req_in() call ptlrpc_server_request_add()<br/> and hp request can be added to export-&gt;exp_hp_rpcs, but reference<br/> increase at ptlrpc_server_handle_request(). If class_disconnect() and<br/> class_export_destroy() occures before ptlrpc_server_handle_request()<br/> we got ASSERTION.</p> LU-1820

(genops.c:766:class_export_destroy()) ASSERTION(cfs_list_empty(&exp->exp_hp_rpcs)) failed

Bug Blocker Closed Fixed Mikhail Pershin Alexander Boyko MB patch Tue, 4 Sep 2012 05:29:44 +0000 Wed, 24 Apr 2013 13:49:28 +0000 Mon, 22 Apr 2013 16:09:22 +0000 Lustre 2.1.0 Lustre 2.2.0 Lustre 2.3.0 Lustre 2.4.0 Lustre 2.3.0 Lustre 2.4.0 0 8 <p>req <a href="http://review.whamcloud.com/3855" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/3855</a></p> <p>Liang</p> <p>Could you please make the necessary revisions to the existing patch?</p> <p>Thanks</p> <p>Peter</p> <p>Landed for 2.3 and 2.4</p> <p>Xyratex-bug-id: <a href="http://jira-nss.xy01.xyratex.com:8080/browse/MRP-649" class="external-link" target="_blank" rel="nofollow noopener">MRP-649</a></p> <p>We have seen this assert again, sources contain the fix <a href="http://review.whamcloud.com/3855" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/3855</a>.</p> <p>The root cause of this bugs is the next part of target_handle_connect()</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> if (req-&gt;rq_export != NULL) class_export_put(req-&gt;rq_export); /* request takes one export refcount */ req-&gt;rq_export = class_export_get(export); </pre> </div></div> <p>req-&gt;rq_export was changed but export contain hp request (this is valid after connect became hp req).<br/> And after that at ptlrpc_server_handle_req()</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>out_req: if (export != NULL) class_export_rpc_put(export); ptlrpc_server_finish_request(svcpt, request); </pre> </div></div> <p>1) delete last reference for the first export with hp req<br/> 2) ptlrpc_server_hpreq_fini() delete list entry for hp req</p> <p>This invalid logic cause topic assert.<br/> Request for review to fix this - <a href="http://review.whamcloud.com/#change,5922" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,5922</a>.</p> <p>Reopening in light of new evidence that the previous fix was incomplete</p> <p>Mike can you please review this latest patch?</p> <p>Landed for 2.4</p> <p>Xyratex-bug-id: <a href="http://jira-nss.xy01.xyratex.com:8080/browse/MRP-881" class="external-link" target="_blank" rel="nofollow noopener">MRP-881</a></p> Development Rank 1|hzv5in: Rank (Obsolete) 4428 Severity