Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 [LU-1821] build errors with newer gcc https://jira.whamcloud.com/browse/LU-1821 Lustre <p>newer gcc checks stricter about C99 VLA and set-but-unused variables.</p> LU-1821 build errors with newer gcc Bug Minor Resolved Fixed Keith Mannthey Peng Tao Tue, 4 Sep 2012 06:42:11 +0000 Thu, 18 Apr 2013 20:15:54 +0000 Wed, 3 Oct 2012 08:54:41 +0000 Lustre 2.3.0 Lustre 2.4.0 0 2 <p>VLA error:</p> <p> drivers/incore/fs_incore.c:340:54: error: variably modified<br/> ‘incore_dir_template’ at file scope <span class="error">&#91;-Werror&#93;</span></p> <p>$gcc --version<br/> gcc (GCC) 4.6.3 20120306 (Red Hat 4.6.3-2)<br/> Copyright (C) 2011 Free Software Foundation, Inc.<br/> This is free software; see the source for copying conditions. There is NO<br/> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.</p> <p>patch submitted:<br/> <a href="http://review.whamcloud.com/3856" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/3856</a></p> <p>Another error after rebasing my code...</p> <p>make<span class="error">&#91;3&#93;</span>: Entering directory `/home/bergwolf/src/linux-2.6'</p> <p> WARNING: Symbol version dump /home/bergwolf/src/linux-2.6/Module.symvers<br/> is missing; modules will have no dependencies and modversions.</p> <p> CC <span class="error">&#91;M&#93;</span> /home/bergwolf/rpmbuild/BUILD/lustre-2.3.50/lustre/osc/osc_request.o<br/> cc1: warnings being treated as errors<br/> /home/bergwolf/rpmbuild/BUILD/lustre-2.3.50/lustre/osc/osc_request.c: In function ‘osc_setup’:<br/> /home/bergwolf/rpmbuild/BUILD/lustre-2.3.50/lustre/osc/osc_request.c:3581: error: ignoring return value of ‘PTR_ERR’, declared with attribute warn_unused_result</p> <p>$gcc --version<br/> gcc (GCC) 4.4.6 20120305 (Red Hat 4.4.6-4)<br/> Copyright (C) 2010 Free Software Foundation, Inc.<br/> This is free software; see the source for copying conditions. There is NO<br/> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.</p> <p>patch submitted to<br/> <a href="http://review.whamcloud.com/3884" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/3884</a></p> <p>This is the same problem we seen on SLES11 SP2. Please take a look at <a href="http://review.whamcloud.com/#change,3734" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,3734</a> for jira ticket <a href="https://jira.whamcloud.com/browse/LU-1691" title="kernel update [SLES11 SP2 3.0.34-0.7.9]" class="issue-link" data-issue-key="LU-1691"><del>LU-1691</del></a>. This is really a duplicate of that ticket.</p> <p><a href="https://jira.whamcloud.com/browse/LU-1691" title="kernel update [SLES11 SP2 3.0.34-0.7.9]" class="issue-link" data-issue-key="LU-1691"><del>LU-1691</del></a> doesn't address the VLA error. Shall I abandon this ticket (and the two patches) and let Yang Sheng fold the VLA part into <a href="http://review.whamcloud.com/#change,3734" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,3734</a> ?</p> <p>Look at the <a href="https://jira.whamcloud.com/browse/LU-1691" title="kernel update [SLES11 SP2 3.0.34-0.7.9]" class="issue-link" data-issue-key="LU-1691"><del>LU-1691</del></a> patch and your two patches I would suggest the easiest path is to fold your changes into one patch and make it dependent on the patch from <a href="https://jira.whamcloud.com/browse/LU-1691" title="kernel update [SLES11 SP2 3.0.34-0.7.9]" class="issue-link" data-issue-key="LU-1691"><del>LU-1691</del></a> since they over lap. You are right your patch adds even more fixes that are needed beyond SLES11 SP2 support.</p> <p>I agree. I'll just abandon <a href="http://review.whamcloud.com/#change,3884" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,3884</a> and reduce <a href="http://review.whamcloud.com/#change,3856" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,3856</a> to just fix VLA error. There is no need to depend on patch from <a href="https://jira.whamcloud.com/browse/LU-1691" title="kernel update [SLES11 SP2 3.0.34-0.7.9]" class="issue-link" data-issue-key="LU-1691"><del>LU-1691</del></a> because VLA fix is independent. Thanks.</p> <p>Landed for 2.3</p> <p>Found another problem. Could we reopen and keep this ticket around? We will continue to have gcc build errors from time to time.</p> <p>James</p> <p>It makes it much easier to track which fix is in which release if we have one ticket per issue rather than reused tickets (and I bet it takes less time to open a new ticket than to find the existing one to reuse<img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/wink.png" height="16" width="16" align="absmiddle" alt="" border="0"/> ). My preference would be for us to look into ways that we can catch introducing these problems <em>before</em> they land. Perhaps we can discuss ideas on how we could accomplish this on the next CDWG call?</p> <p>Peter</p> <p>Okay. Its under <a href="https://jira.whamcloud.com/browse/LU-2111" title="echo_client does return proper error code when it fails." class="issue-link" data-issue-key="LU-2111"><del>LU-2111</del></a></p> Development Rank 1|hzv5on: Rank (Obsolete) 4455 Severity