https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-1972 Lustre <p>This issue was created by maloo for Li Wei &lt;liwei@whamcloud.com&gt;</p> <p>This issue relates to the following test suite run: <a href="https://maloo.whamcloud.com/test_sets/0b17713c-015a-11e2-bc4e-52540035b04c" class="external-link" target="_blank" rel="nofollow noopener">https://maloo.whamcloud.com/test_sets/0b17713c-015a-11e2-bc4e-52540035b04c</a>.</p> <p>The sub-test test_53a failed with the following error:</p> <blockquote> <p>test_53a failed with 2</p></blockquote> <p>Info required for matching: replay-single 53a</p> LU-1972

Test failure on test suite replay-single, subtest test_53a

Bug Minor Resolved Cannot Reproduce WC Triage Maloo Tue, 18 Sep 2012 03:49:47 +0000 Mon, 29 May 2017 05:46:57 +0000 Mon, 29 May 2017 05:46:57 +0000 0 8 <p>It seems OBD_FAIL_MDS_CLOSE_NET is defined but never appears in any place in the code?</p> <p><a href="https://maloo.whamcloud.com/test_sets/b5b17ebc-0939-11e2-a95c-52540035b04c" class="external-link" target="_blank" rel="nofollow noopener">https://maloo.whamcloud.com/test_sets/b5b17ebc-0939-11e2-a95c-52540035b04c</a></p> <p>Li Wei, it seems that OBD_FAIL_MDS_CLOSE_NET <em>does</em> exist, but it is defined in an extremely confusing manner:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">#define DEF_HNDL(prefix, base, suffix, flags, opc, fn, fmt) \ [prefix ## _ ## opc - prefix ## _ ## base] = { \ .mh_name = #opc, \ .mh_fail_id = OBD_FAIL_ ## prefix ## _ ## opc ## suffix, \ .mh_opc = prefix ## _ ## opc, \ .mh_flags = flags, \ .mh_act = fn, \ .mh_fmt = fmt \ } #define DEF_MDT_HNDL_F(flags, name, fn) \ DEF_HNDL(MDS, GETATTR, _NET, flags, name, fn, &amp;RQF_MDS_ ## name) <span class="code-keyword">static</span> struct mdt_handler mdt_mds_ops[] = { : : DEF_MDT_HNDL_F(HABEO_CORPUS, CLOSE, mdt_close), <span class="code-keyword">static</span> <span class="code-object">int</span> mdt_req_handle(struct mdt_thread_info *info, struct mdt_handler *h, struct ptlrpc_request *req) { : : /* * Checking <span class="code-keyword">for</span> various OBD_FAIL_$PREF_$OPC_NET codes. _Do_ not <span class="code-keyword">try</span> * to put same checks into handlers like mdt_close(), mdt_reint(), * etc., without talking to mdt authors first. Checking same thing * there again is useless and returning 0 error without packing reply * is buggy! Handlers either pack reply or <span class="code-keyword">return</span> error. * * We <span class="code-keyword">return</span> 0 here and <span class="code-keyword">do</span> not send any reply in order to emulate * network failure. Do not send any reply in <span class="code-keyword">case</span> any of NET related * fail_id has occured. */ <span class="code-keyword">if</span> (OBD_FAIL_CHECK_ORSET(h-&gt;mh_fail_id, OBD_FAIL_ONCE)) RETURN(0); </pre> </div></div> <p>and the only reason that I found it was coincidentally because of <tt>mdt_close()</tt> in the above comment... Searching for OBD_FAIL_MDS_CLOSE_NET, MDS_CLOSE, or RQF_MDS_CLOSE produced nothing. I found the mdt_close() function and had started searching for that in the code when I found the comment.</p> <p>Grrr, this makes the MDS code nearly impossible to follow (as if it wasn't already)...</p> <p>I've submitted <a href="http://review.whamcloud.com/4260" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4260</a> to address the terrible coding style. This may make it easier to understand the code, but does nothing to actually fix the problem reported here.</p> <p>Lustre Client: 2.1.4 RC2<br/> Lustre Server: 2.2.0<br/> Distro/Arch: RHEL6.3/x86_64</p> <p>The same issue occurred: <a href="https://maloo.whamcloud.com/test_sets/16e08334-4bea-11e2-a817-52540035b04c" class="external-link" target="_blank" rel="nofollow noopener">https://maloo.whamcloud.com/test_sets/16e08334-4bea-11e2-a817-52540035b04c</a></p> <p>another instance seen in 2.3.0 server vs 2.4 client:<br/> <a href="https://maloo.whamcloud.com/test_sets/8cf3b9cc-5b55-11e2-8985-52540035b04c" class="external-link" target="_blank" rel="nofollow noopener">https://maloo.whamcloud.com/test_sets/8cf3b9cc-5b55-11e2-8985-52540035b04c</a></p> <p>Close old ticket.</p> Development Rank 1|hzv48f: Rank (Obsolete) 4218 Severity