Whamcloud Community JIRA

Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us

9.4.14

940014

05-12-2023

[LU-2072] Leak of s_mb_prealloc_table in ldiskfs https://jira.whamcloud.com/browse/LU-2072 Lustre <p>All 2.x versions at least seems to be affected.</p> <p>It seems ext4-prealloc-rhel6.patch adds sbi->s_mb_prealloc_table field that is allocated using kmalloc (128 bytes on my system) and is never freed.</p> <p>Needs to be freed in ldiskfs_mb_release</p> LU-2072

Leak of s_mb_prealloc_table in ldiskfs

Bug Minor Resolved Fixed Bruno Faccini Oleg Drokin ldiskfs Mon, 1 Oct 2012 23:46:32 +0000 Tue, 1 Sep 2015 22:52:13 +0000 Wed, 6 Feb 2013 09:51:26 +0000 Lustre 2.4.0 Lustre 2.1.5 0 4 <p>Bruno</p> <p>Can you please look into this one?</p> <p>Peter</p> <p>Hello Oleg,<br/> Just for my understanding did you find this by monitoring the slabs usage or by browsing the source code ??<br/> Thank's.<br/> Bruno.</p> <p>Master patch submitted at <a href="http://review.whamcloud.com/4683" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4683</a>.</p> <p>Oops, just submitted patch set 2 ..., because I forgot some rules to patch a patch !!!</p> <p>Patch Set 2 looks better ..., I verified that after "mount <del>t ldiskfs/umount/sync/drop_caches", super_block</del>>s_fs_info>s_mb_prealloc_table was freed.</p> <p>I submitted patch #3 according to Andreas comment to better add missing kfree()s of s_mb_prealloc_table, in patch ext4-prealloc-rhel6.patch where it was introduced.</p> <p>I did not submit a new patch against ext4-<span class="error">[prealloc,malloc]</span>-rhel5.patch for master since it seems we don't build master Server distros for rhel5, am I right ? Or do I need to do it anyway, at least for 1.8 ?</p> <p>Status as fixed since not reported with Lustre-1.8/EL5 and Master patch should be ok for all 2.x versions.</p> <p>b2_1 port is at <a href="http://review.whamcloud.com/5474" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/5474</a></p> Related LU-7087 Development Rank 1|hzv4w7: Rank (Obsolete) 4326 Severity