https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-2184 Lustre <p>Andreas' comment on <a href="http://review.whamcloud.com/#patch,sidebyside,4255,3,lustre/mdt/mdt_handler.c" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#patch,sidebyside,4255,3,lustre/mdt/mdt_handler.c</a> suggests that <tt>fid_is_igif</tt> should be called when <tt>fid_is_norm</tt> is called to avoid breaking access to IGIF files.</p> LU-2184

avoid breaking access to IGIF files when testing fid_is_norm

Bug Minor Resolved Fixed Richard Henwood Richard Henwood Mon, 15 Oct 2012 16:19:01 +0000 Wed, 18 Jun 2014 22:23:18 +0000 Fri, 9 May 2014 19:51:11 +0000 Lustre 2.4.0 Lustre 2.4.0 0 2 <p>Some time in the past, the call in question was replaced by a call to fid_is_namespace_visible which addresses the concerns in this ticket. fid_is_namespace_visible is defined in lustre_fid.h as:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-keyword">static</span> inline <span class="code-object">int</span> fid_is_namespace_visible(<span class="code-keyword">const</span> struct lu_fid *fid) { <span class="code-keyword">const</span> __u64 seq = fid_seq(fid); /* Here, we cannot distinguish whether the normal FID is <span class="code-keyword">for</span> OST * object or not. It is caller's duty to check more <span class="code-keyword">if</span> needed. */ <span class="code-keyword">return</span> (!fid_is_last_id(fid) &amp;&amp; (fid_seq_is_norm(seq) || fid_seq_is_igif(seq))) || fid_is_root(fid) || fid_seq_is_dot_lustre(seq); } </pre> </div></div> <p>Fix was in patch <a href="http://review.whamcloud.com/5764" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/5764</a> for 2.4.0</p> Related LU-3039 Development Rank 1|hzvafj: Rank (Obsolete) 5225 Severity