https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-2185 Lustre <p>looked at <a href="https://jira.whamcloud.com/browse/LU-974" title="Lustre does not ignore umask when default ACL with mask is set" class="issue-link" data-issue-key="LU-974"><del>LU-974</del></a>, but not exactly the same problem. </p> <p>I did one test on lustre and the same test on /tmp (ext3). Started by clearing out all <br/> setfacl's using "setfacl -R -b" on top level directory before each example is started.</p> <p>=================<br/> lustre filesystem<br/> =================</p> <p><span class="error">&#91;client1:workdir&#93;</span>$ pwd<br/> /nobackup/workdir<br/> <span class="error">&#91;client1:workdir&#93;</span>$ setfacl -M setfacl.jdk .<br/> <span class="error">&#91;client1:workdir&#93;</span>$ ls -ld ../workdir/<br/> drwxrwxr-x+ 5 user2 g26137 4096 Oct 5 13:10 ../workdir/</p> <p><span class="error">&#91;client1:workdir&#93;</span>$ mkdir test1<br/> <span class="error">&#91;client1:workdir&#93;</span>$ touch test1/file1<br/> <span class="error">&#91;client1:workdir&#93;</span>$ getfacl test1/</p> <ol> <li>file: test1</li> <li>owner: user2</li> <li>group: g26137<br/> user::rwx<br/> user:user1:rwx #effective:---<br/> user:user2:rwx #effective:---<br/> user:user3:rwx #effective:---<br/> user:user4:rwx #effective:---<br/> group::rwx #effective:---<br/> mask::---<br/> other::---<br/> default:user::rwx<br/> default:user:user1:rwx<br/> default:user:user2:rwx<br/> default:user:user3:rwx<br/> default:user:user4:rwx<br/> default:group::rwx<br/> default:mask::rwx<br/> default:other::r-x</li> </ol> <p><span class="error">&#91;client1:workdir&#93;</span>$ getfacl test1/file1 </p> <ol> <li>file: test1/file1</li> <li>owner: user2</li> <li>group: g26137<br/> user::rw-<br/> user:user1:rwx #effective:---<br/> user:user2:rwx #effective:---<br/> user:user3:rwx #effective:---<br/> user:user4:rwx #effective:---<br/> group::rwx #effective:---<br/> mask::---<br/> other::---</li> </ol> <p>setfacl file used:<br/> <span class="error">&#91;client1:workdir&#93;</span>$ cat setfacl.jdk</p> <ol> <li>file: workdir</li> <li>owner: user2</li> <li>group: g26137<br/> user::rwx<br/> user:user1:rwx<br/> user:user2:rwx<br/> user:user3:rwx<br/> user:user4:rwx<br/> group::rwx<br/> mask::rwx<br/> other::r-x<br/> default:user::rwx<br/> default:user:user1:rwx<br/> default:user:user2:rwx<br/> default:user:user3:rwx<br/> default:user:user4:rwx<br/> default:group::rwx<br/> default:mask::rwx<br/> default:other::r-x</li> </ol> <p>=================<br/> tmp/ext3 filesystem<br/> =================</p> <p><span class="error">&#91;client1:workdir&#93;</span>$ pwd<br/> /tmp/workdir<br/> <span class="error">&#91;client1:workdir&#93;</span>$ setfacl -M setfacl.jdk .<br/> <span class="error">&#91;client1:workdir&#93;</span>$ ls -ld ../workdir/<br/> drwxrwxr-x+ 5 user2 g26137 4096 Oct 5 13:10 ../workdir/</p> <p><span class="error">&#91;client1:workdir&#93;</span>$ mkdir test2<br/> <span class="error">&#91;client1:workdir&#93;</span>$ touch test2/file2<br/> <span class="error">&#91;client1:workdir&#93;</span>$ getfacl test2</p> <ol> <li>file: test2</li> <li>owner: user2</li> <li>group: g26137<br/> user::rwx<br/> user:user1:rwx<br/> user:user2:rwx<br/> user:user3:rwx<br/> user:user4:rwx<br/> group::rwx<br/> mask::rwx<br/> other::r-x<br/> default:user::rwx<br/> default:user:user1:rwx<br/> default:user:user2:rwx<br/> default:user:user3:rwx<br/> default:user:user4:rwx<br/> default:group::rwx<br/> default:mask::rwx<br/> default:other::r-x</li> </ol> <p><span class="error">&#91;client1:workdir&#93;</span>$ getfacl test2/file2 </p> <ol> <li>file: test2/file2</li> <li>owner: user2</li> <li>group: g26137<br/> user::rw-<br/> user:user1:rwx #effective:rw-<br/> user:user2:rwx #effective:rw-<br/> user:user3:rwx #effective:rw-<br/> user:user4:rwx #effective:rw-<br/> group::rwx #effective:rw-<br/> mask::rw-<br/> other::r--</li> </ol> <p>setfacl file used:<br/> <span class="error">&#91;client1:workdir&#93;</span>$ cat setfacl.jdk </p> <ol> <li>file: workdir</li> <li>owner: user2</li> <li>group: g26137<br/> user::rwx<br/> user:user1:rwx<br/> user:user2:rwx<br/> user:user3:rwx<br/> user:user4:rwx<br/> group::rwx<br/> mask::rwx<br/> other::r-x<br/> default:user::rwx<br/> default:user:user1:rwx<br/> default:user:user2:rwx<br/> default:user:user3:rwx<br/> default:user:user4:rwx<br/> default:group::rwx<br/> default:mask::rwx<br/> default:other::r-x<br/> =================</li> </ol> <p>Let me know if you need more information. </p> <p>jdk</p> sles11sp1 2.1.3 (NASA version) client with 2.1.2 (NAS version) server bits LU-2185

setfacl not working correctly

Bug Minor Resolved Duplicate Jian Yu James Karellas Mon, 15 Oct 2012 16:24:34 +0000 Tue, 20 Nov 2012 01:50:48 +0000 Tue, 20 Nov 2012 01:49:26 +0000 Lustre 2.1.3 0 6 <p>To (try to) clarify: When ACLs are set on a file (individually), in my limited testing it works as expected. When<br/> I create a directory and then file, the new ACLs are not propogated correctly. Give it a try and let me know what you come up with.</p> <p>Yujian</p> <p>Could you please look into this one?</p> <p>Thanks</p> <p>Peter</p> <p>lustre mounted with the following options:</p> <p>acl,errors=panic,iopen_nopriv,user_xattr</p> <p>Sorry for the late response. I'll look into this right away.</p> <p>Here is my test result:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Lustre Client: 2.1.3 Lustre Build: http://build.whamcloud.com/job/lustre-b2_1/121/ Distro/Arch: SLES11SP1/x86_64 (kernel version: 2.6.32.36-0.5-default) Lustre Server: 2.1.2 Lustre Build: http://build.whamcloud.com/job/lustre-b2_1/91/ Distro/Arch: RHEL6.3/x86_64 (kernel version: 2.6.32-220.17.1.el6_lustre.x86_64) client-3:~ # mount | grep lustre fat-intel-4@tcp:/lustre on /nobackup/workdir type lustre (rw,acl,user_xattr) [root@fat-intel-4 ~]# mount | grep lustre /dev/sdc9 on /nobackup/mds1 type lustre (rw,acl,errors=panic,iopen_nopriv,user_xattr) /dev/sdc5 on /nobackup/ost1 type lustre (rw) /dev/sdc6 on /nobackup/ost2 type lustre (rw) /dev/sdc7 on /nobackup/ost3 type lustre (rw) /dev/sdc8 on /nobackup/ost4 type lustre (rw) </pre> </div></div> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>================= lustre filesystem ================= user2@client-3:~&gt; df -T /nobackup/workdir Filesystem Type 1K-blocks Used Available Use% Mounted on fat-intel-4@tcp:/lustre lustre 7874112 410224 7063632 6% /nobackup/workdir user2@client-3:~&gt; setfacl -R -b /nobackup/workdir user2@client-3:~&gt; cd /nobackup/workdir user2@client-3:/nobackup/workdir&gt; pwd /nobackup/workdir user2@client-3:/nobackup/workdir&gt; setfacl -M setfacl.jdk . user2@client-3:/nobackup/workdir&gt; ls -ld ../workdir/ drwxrwxr-x+ 3 user2 g26137 4096 2012-10-31 01:18 ../workdir/ user2@client-3:/nobackup/workdir&gt; mkdir test1 user2@client-3:/nobackup/workdir&gt; touch test1/file1 user2@client-3:/nobackup/workdir&gt; getfacl test1/ # file: test1/ # owner: user2 # group: g26137 user::rwx user:user1:rwx #effective:r-x user:user2:rwx #effective:r-x user:user3:rwx #effective:r-x user:user4:rwx #effective:r-x group::rwx #effective:r-x mask::r-x other::r-x default:user::rwx default:user:user1:rwx default:user:user2:rwx default:user:user3:rwx default:user:user4:rwx default:group::rwx default:mask::rwx default:other::r-x user2@client-3:/nobackup/workdir&gt; getfacl test1/file1 # file: test1/file1 # owner: user2 # group: g26137 user::rw- user:user1:rwx #effective:r-- user:user2:rwx #effective:r-- user:user3:rwx #effective:r-- user:user4:rwx #effective:r-- group::rwx #effective:r-- mask::r-- other::r-- user2@client-3:/nobackup/workdir&gt; cat setfacl.jdk # file: workdir # owner: user2 # group: g26137 user::rwx user:user1:rwx user:user2:rwx user:user3:rwx user:user4:rwx group::rwx mask::rwx other::r-x default:user::rwx default:user:user1:rwx default:user:user2:rwx default:user:user3:rwx default:user:user4:rwx default:group::rwx default:mask::rwx default:other::r-x ================= tmp/ext3 filesystem ================= user2@client-3:~&gt; df -T /tmp/workdir Filesystem Type 1K-blocks Used Available Use% Mounted on /dev/sda1 ext3 20635700 1492244 18095220 8% / user2@client-3:~&gt; setfacl -R -b /tmp/workdir user2@client-3:~&gt; cd /tmp/workdir user2@client-3:/tmp/workdir&gt; pwd /tmp/workdir user2@client-3:/tmp/workdir&gt; setfacl -M setfacl.jdk . user2@client-3:/tmp/workdir&gt; ls -ld ../workdir/ drwxrwxr-x+ 2 user2 g26137 4096 2012-10-31 01:26 ../workdir/ user2@client-3:/tmp/workdir&gt; mkdir test2 user2@client-3:/tmp/workdir&gt; touch test2/file2 user2@client-3:/tmp/workdir&gt; getfacl test2 # file: test2 # owner: user2 # group: g26137 user::rwx user:user1:rwx user:user2:rwx user:user3:rwx user:user4:rwx group::rwx mask::rwx other::r-x default:user::rwx default:user:user1:rwx default:user:user2:rwx default:user:user3:rwx default:user:user4:rwx default:group::rwx default:mask::rwx default:other::r-x user2@client-3:/tmp/workdir&gt; getfacl test2/file2 # file: test2/file2 # owner: user2 # group: g26137 user::rw- user:user1:rwx #effective:rw- user:user2:rwx #effective:rw- user:user3:rwx #effective:rw- user:user4:rwx #effective:rw- group::rwx #effective:rw- mask::rw- other::r-- user2@client-3:/tmp/workdir&gt; cat setfacl.jdk # file: workdir # owner: user2 # group: g26137 user::rwx user:user1:rwx user:user2:rwx user:user3:rwx user:user4:rwx group::rwx mask::rwx other::r-x default:user::rwx default:user:user1:rwx default:user:user2:rwx default:user:user3:rwx default:user:user4:rwx default:group::rwx default:mask::rwx default:other::r-x </pre> </div></div> <p>From the above test result, the effective rights mask on Lustre filesystem was incorrect:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>For directory, it was "mask::r-x", but should be "mask::rwx". For regular file, it was "mask::r--", but should be "mask::rw-". </pre> </div></div> <p>From my test result, it turned out to be the same issue as that in <a href="https://jira.whamcloud.com/browse/LU-974" title="Lustre does not ignore umask when default ACL with mask is set" class="issue-link" data-issue-key="LU-974"><del>LU-974</del></a>, which was just reopened because the real patches had not been landed yet.</p> <p>While I performing the above test, the umask value was:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>user2@client-3:~&gt; umask 0022 </pre> </div></div> <p>After I changed the value to 0002 and performed the same test again, the result on Lustre filesystem became correct:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>user2@client-3:~&gt; umask 0002 user2@client-3:~&gt; df -T /nobackup/workdir Filesystem Type 1K-blocks Used Available Use% Mounted on fat-intel-4@tcp:/lustre lustre 7874112 410228 7063628 6% /nobackup/workdir user2@client-3:~&gt; setfacl -R -b /nobackup/workdir user2@client-3:~&gt; cd /nobackup/workdir user2@client-3:/nobackup/workdir&gt; pwd /nobackup/workdir user2@client-3:/nobackup/workdir&gt; setfacl -M setfacl.jdk . user2@client-3:/nobackup/workdir&gt; ls -ld ../workdir/ drwxrwxr-x+ 3 user2 g26137 4096 2012-11-01 04:42 ../workdir/ user2@client-3:/nobackup/workdir&gt; mkdir test1 user2@client-3:/nobackup/workdir&gt; touch test1/file1 user2@client-3:/nobackup/workdir&gt; getfacl test1/ # file: test1/ # owner: user2 # group: g26137 user::rwx user:user1:rwx user:user2:rwx user:user3:rwx user:user4:rwx group::rwx mask::rwx other::r-x default:user::rwx default:user:user1:rwx default:user:user2:rwx default:user:user3:rwx default:user:user4:rwx default:group::rwx default:mask::rwx default:other::r-x user2@client-3:/nobackup/workdir&gt; getfacl test1/file1 # file: test1/file1 # owner: user2 # group: g26137 user::rw- user:user1:rwx #effective:rw- user:user2:rwx #effective:rw- user:user3:rwx #effective:rw- user:user4:rwx #effective:rw- group::rwx #effective:rw- mask::rw- other::r-- user2@client-3:/nobackup/workdir&gt; cat setfacl.jdk # file: workdir # owner: user2 # group: g26137 user::rwx user:user1:rwx user:user2:rwx user:user3:rwx user:user4:rwx group::rwx mask::rwx other::r-x default:user::rwx default:user:user1:rwx default:user:user2:rwx default:user:user3:rwx default:user:user4:rwx default:group::rwx default:mask::rwx default:other::r-x </pre> </div></div> <p>Hi James,</p> <p>Could you please take a look at the umask value on your test system? Thanks.</p> <p>Our default umask is 77. Please test with 77.</p> <blockquote><p>Our default umask is 77. Please test with 77.</p></blockquote> <p>OK, will do.</p> <p>Here is the test result with umask 77:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>user2@client-3:~&gt; umask 77 user2@client-3:~&gt; df -T /nobackup/workdir Filesystem Type 1K-blocks Used Available Use% Mounted on fat-intel-4@tcp:/lustre lustre 7874112 410224 7063632 6% /nobackup/workdir user2@client-3:~&gt; setfacl -R -b /nobackup/workdir user2@client-3:~&gt; cd /nobackup/workdir user2@client-3:/nobackup/workdir&gt; pwd /nobackup/workdir user2@client-3:/nobackup/workdir&gt; setfacl -M setfacl.jdk . user2@client-3:/nobackup/workdir&gt; ls -ld ../workdir/ drwxrwxr-x+ 3 user2 g26137 4096 2012-11-19 00:30 ../workdir/ user2@client-3:/nobackup/workdir&gt; mkdir test1 user2@client-3:/nobackup/workdir&gt; touch test1/file1 user2@client-3:/nobackup/workdir&gt; getfacl test1/ # file: test1/ # owner: user2 # group: g26137 user::rwx user:user1:rwx #effective:--- user:user2:rwx #effective:--- user:user3:rwx #effective:--- user:user4:rwx #effective:--- group::rwx #effective:--- mask::--- other::--- default:user::rwx default:user:user1:rwx default:user:user2:rwx default:user:user3:rwx default:user:user4:rwx default:group::rwx default:mask::rwx default:other::r-x user2@client-3:/nobackup/workdir&gt; getfacl test1/file1 # file: test1/file1 # owner: user2 # group: g26137 user::rw- user:user1:rwx #effective:--- user:user2:rwx #effective:--- user:user3:rwx #effective:--- user:user4:rwx #effective:--- group::rwx #effective:--- mask::--- other::--- user2@client-3:/nobackup/workdir&gt; cat setfacl.jdk # file: workdir # owner: user2 # group: g26137 user::rwx user:user1:rwx user:user2:rwx user:user3:rwx user:user4:rwx group::rwx mask::rwx other::r-x default:user::rwx default:user:user1:rwx default:user:user2:rwx default:user:user3:rwx default:user:user4:rwx default:group::rwx default:mask::rwx default:other::r-x </pre> </div></div> <p>So, with umask 77, the test result is the same as James'. Let me take a look at the patch <a href="http://review.whamcloud.com/1972" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/1972</a> for <a href="https://jira.whamcloud.com/browse/LU-974" title="Lustre does not ignore umask when default ACL with mask is set" class="issue-link" data-issue-key="LU-974"><del>LU-974</del></a>.</p> <p>I just verified that the patch in <a href="http://review.whamcloud.com/1972" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/1972</a> for <a href="https://jira.whamcloud.com/browse/LU-974" title="Lustre does not ignore umask when default ACL with mask is set" class="issue-link" data-issue-key="LU-974"><del>LU-974</del></a> fixed the above issue. Here is the test result with build <a href="http://build.whamcloud.com/job/lustre-reviews/10353/" class="external-link" target="_blank" rel="nofollow noopener">http://build.whamcloud.com/job/lustre-reviews/10353/</a> on SLES11SP1 client:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>user2@client-3:~&gt; umask 77 user2@client-3:~&gt; umask -S u=rwx,g=,o= user2@client-3:~&gt; df -T /nobackup/workdir Filesystem Type 1K-blocks Used Available Use% Mounted on fat-intel-4@tcp:/lustre lustre 7874112 413640 7059392 6% /nobackup/workdir user2@client-3:~&gt; setfacl -R -b /nobackup/workdir user2@client-3:~&gt; cd /nobackup/workdir user2@client-3:/nobackup/workdir&gt; pwd /nobackup/workdir user2@client-3:/nobackup/workdir&gt; setfacl -M setfacl.jdk . user2@client-3:/nobackup/workdir&gt; ls -ld ../workdir/ drwxrwxr-x+ 3 user2 g26137 4096 2012-11-19 22:38 ../workdir/ user2@client-3:/nobackup/workdir&gt; mkdir test1 user2@client-3:/nobackup/workdir&gt; touch test1/file1 user2@client-3:/nobackup/workdir&gt; getfacl test1/ # file: test1/ # owner: user2 # group: g26137 user::rwx user:user1:rwx user:user2:rwx user:user3:rwx user:user4:rwx group::rwx mask::rwx other::r-x default:user::rwx default:user:user1:rwx default:user:user2:rwx default:user:user3:rwx default:user:user4:rwx default:group::rwx default:mask::rwx default:other::r-x user2@client-3:/nobackup/workdir&gt; getfacl test1/file1 # file: test1/file1 # owner: user2 # group: g26137 user::rw- user:user1:rwx #effective:rw- user:user2:rwx #effective:rw- user:user3:rwx #effective:rw- user:user4:rwx #effective:rw- group::rwx #effective:rw- mask::rw- other::r-- user2@client-3:/nobackup/workdir&gt; cat setfacl.jdk # file: workdir # owner: user2 # group: g26137 user::rwx user:user1:rwx user:user2:rwx user:user3:rwx user:user4:rwx group::rwx mask::rwx other::r-x default:user::rwx default:user:user1:rwx default:user:user2:rwx default:user:user3:rwx default:user:user4:rwx default:group::rwx default:mask::rwx default:other::r-x </pre> </div></div> <p>So, let's close this ticket as a duplicate of <a href="https://jira.whamcloud.com/browse/LU-974" title="Lustre does not ignore umask when default ACL with mask is set" class="issue-link" data-issue-key="LU-974"><del>LU-974</del></a>.</p> Duplicate LU-974 Development Rank 1|hzvafr: Rank (Obsolete) 5226 Severity