https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-2217 Lustre <p>Thanks to the Coverity tool, we found some Null pointer dereferences in the Lustre code.</p> <p>I will propose a patch to address the issues. </p> LU-2217

Fix 'NULL pointer dereference' errors

Technical task LU-2753 Major Resolved Fixed Emoly Liu Sebastien Buisson build coverity patch Mon, 22 Oct 2012 05:10:23 +0000 Fri, 6 Sep 2013 23:50:36 +0000 Fri, 6 Sep 2013 23:50:36 +0000 Lustre 2.4.0 Lustre 2.1.3 Lustre 2.5.0 0 6 <p>The patch is available here:</p> <p><a href="http://review.whamcloud.com/4369" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4369</a></p> <p>It implements a defensive approach in some parts of the code, adding many LASSERT() calls.</p> <p>Thanks,<br/> Sebastien.</p> <p>Thanks for the patch Sebastien.</p> <p>Emoly</p> <p>Could you please help by reviewing Sebastien's suggested patch?</p> <p>Thanks</p> <p>Peter </p> <p>Sorry for my late reply. I am still relative new for jira.<br/> I will review this patch soon.</p> <p>Emoly</p> <p>The patch has been reviewed. Since the new assetion in mdt_open.c caused recovery-small.sh test_23 and replay-single.sh test_14 failure, the patch needs to be revised further.</p> <p>The big patch proposed initially has been split into four smaller ones:<br/> <a href="http://review.whamcloud.com/4720" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4720</a><br/> <a href="http://review.whamcloud.com/4721" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4721</a><br/> <a href="http://review.whamcloud.com/4722" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4722</a><br/> <a href="http://review.whamcloud.com/4723" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4723</a></p> <p>Oleg,</p> <p>As Keith mentioned, these patches are a great many LASSERT adds, something like <a href="https://jira.whamcloud.com/browse/LU-1961" title="Fix &#39;dereference before null check&#39; errors" class="issue-link" data-issue-key="LU-1961"><del>LU-1961</del></a>, so could you please take a look at them?</p> <p>Thanks,<br/> Emoly</p> <p>Hi,</p> <p>After reviews, I removed unnecessary assertions from the patches. As the resulting patches are a lot smaller, I reintegrated all the modifications into a single patch, pushed here:<br/> <a href="http://review.whamcloud.com/4720" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4720</a></p> <p>The other patches are abandoned.</p> <p>Sebastien.</p> <p>Landed for 2.5</p> Development Rank 1|hzvaqn: Rank (Obsolete) 5275