https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-2259 Lustre <p>After commit f715e4e (<a href="https://jira.whamcloud.com/browse/LU-1606" title="lustre_idl.h does not compile in user-space" class="issue-link" data-issue-key="LU-1606"><del>LU-1606</del></a> api: Rename liblustreapi.h -&gt; lustreapi.h) was landed on master branch, the e2fsprogs build failed as follows:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>In file included from /root/lustre-2.3.54/lustre/include/lustre/lustreapi.h:46, from /root/lustre-2.3.54/lustre/include/lustre/liblustreapi.h:40, from ../lib/ext2fs/lfsck.h:14, from lfsck.c:80: /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h: In function 'lustre_lma_swab': /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:345: warning: implicit declaration of function 'cpu_to_le32' /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:346: warning: implicit declaration of function '__swab32s' /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:349: warning: implicit declaration of function '__swab64s' In file included from /root/lustre-2.3.54/lustre/include/lustre/lustreapi.h:46, from /root/lustre-2.3.54/lustre/include/lustre/liblustreapi.h:40, from ../lib/ext2fs/lfsck.h:14, from lfsck_common.c:29: /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h: In function 'lustre_lma_swab': /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:345: warning: implicit declaration of function 'cpu_to_le32' /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:346: warning: implicit declaration of function '__swab32s' /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:349: warning: implicit declaration of function '__swab64s' /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h: In function 'fid_ostid_unpack': /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:572: warning: implicit declaration of function 'CERROR' /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:572: error: expected ')' before 'LPU64' /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:584: error: expected ')' before 'LPU64' /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:597: error: expected ')' before 'LPU64' /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:603: warning: implicit declaration of function 'unlikely' /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:606: error: expected ')' before 'LPU64' /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h: In function 'fid_ostid_pack': /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:608: error: expected ')' before 'LPX64' /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h: In function 'ostid_seq': /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:658: warning: implicit declaration of function 'CWARN' /root/lustre-2.3.54/lustre/include/lustre/lustre_idl.h:658: error: expected ')' before 'LPU64' </pre> </div></div> <p>A patch is being created.</p> LU-2259

e2fsprogs: rename liblustreapi.h with lustreapi.h

Bug Minor Resolved Fixed Jian Yu Jian Yu Fri, 2 Nov 2012 08:34:22 +0000 Tue, 11 Jun 2013 20:55:29 +0000 Sat, 1 Jun 2013 18:01:37 +0000 Lustre 2.4.0 Lustre 2.5.0 0 5 <p>Just renaming liblustreapi.h with lustreapi.h will not fix the above build failures. The main issue is still being resolved in <a href="https://jira.whamcloud.com/browse/LU-1606" title="lustre_idl.h does not compile in user-space" class="issue-link" data-issue-key="LU-1606"><del>LU-1606</del></a>. </p> <p>Correct, the header rename was done in a backwards compatible way, if we did it right. It would be nice to update it to the new name, but that will not fix this problem.</p> <p>Status update:<br/> After <a href="https://jira.whamcloud.com/browse/LU-1606" title="lustre_idl.h does not compile in user-space" class="issue-link" data-issue-key="LU-1606"><del>LU-1606</del></a> is fixed, I'll create a patch for e2fsprogs to rename liblustreapi.h with lustreapi.h.</p> <p>Just be aware that when you do that e2fsprogs will no longer build against any older versions of lustre.</p> <blockquote><p>Just be aware that when you do that e2fsprogs will no longer build against any older versions of lustre.</p></blockquote> <p>Thanks for the reminder, Chris. After <a href="https://jira.whamcloud.com/browse/LU-1606" title="lustre_idl.h does not compile in user-space" class="issue-link" data-issue-key="LU-1606"><del>LU-1606</del></a> is fixed and e2fsprogs can be built successfully without renaming liblustreapi.h, I'll lower the priority of this ticket.</p> <p>After the patch for <a href="https://jira.whamcloud.com/browse/LU-1606" title="lustre_idl.h does not compile in user-space" class="issue-link" data-issue-key="LU-1606"><del>LU-1606</del></a> was landed on master branch, building e2fsprogs succeeded on Jenkins:</p> <p><a href="http://build.whamcloud.com/job/e2fsprogs-reviews/128/arch=x86_64,distro=el6/" class="external-link" target="_blank" rel="nofollow noopener">http://build.whamcloud.com/job/e2fsprogs-reviews/128/arch=x86_64,distro=el6/</a></p> <p>Let's lower the priority of this ticket now.</p> <p>What is the state of this?</p> <p><a href="http://build.whamcloud.com/job/e2fsprogs-reviews/128" class="external-link" target="_blank" rel="nofollow noopener">http://build.whamcloud.com/job/e2fsprogs-reviews/128</a> failed on el5, and didn't get pushed to head.</p> <p>Hi Chris,</p> <blockquote><p>What is the state of this?</p></blockquote> <blockquote><p><a href="http://build.whamcloud.com/job/e2fsprogs-reviews/128" class="external-link" target="_blank" rel="nofollow noopener">http://build.whamcloud.com/job/e2fsprogs-reviews/128</a> failed on el5, and didn't get pushed to head.</p></blockquote> <p>This is TT-955.</p> <p>This problem is fixed in recent e2fsprogs releases. It checks for both lustreapi and liblustreapi in configure. </p> Related LU-1606 Development Rank 1|hzvbin: Rank (Obsolete) 5408 Severity