[LU-2268] SMP scalablity enhancements break FMR pools

Fri, 19 Apr 2013 20:47:11 +0000

The SMP scalability patch never uses FMR due to the following code from master at 2299:

   2286         }
   2287 
   2288         for (i = 0; i < ncpts; i++) {
   2289                 cpt = (cpts == NULL) ? i : cpts[i];
   2290                 rc = kiblnd_init_fmr_poolset(net->ibn_fmr_ps[cpt], cpt, net,
   2291                                              kiblnd_fmr_pool_size(ncpts),
   2292                                              kiblnd_fmr_flush_trigger(ncpts));
   2293                 if (rc == -ENOSYS && i == 0) /* no FMR */
   2294                         break; /* create PMR pool */
   2295                 if (rc != 0)
   2296                         goto failed; /* a real error */
   2297         }
   2298 
   2299         cfs_percpt_free(net->ibn_fmr_ps);
   2300         net->ibn_fmr_ps = NULL;
   2301

I had hoped that just adding the following would be sufficient:

if (rc > 0)
         return 0; /* FMR success */

However, when attempting to run with that I am seeing a kernel panic. Right now I have the patch for ~~LU-1757~~ in the code I will remove and test again just to make sure its not that patch.

Whamcloud Community JIRA

[LU-2268] SMP scalablity enhancements break FMR pools