https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-2302 Lustre <p>The lfs_migrate utility suffers from a few robustness issues:</p> <ul> <li>can temporarily leak information if used by root with a lenient umask;</li> <li>fails if called with a non-English locale;</li> <li>does not correctly handle newline characters in file/directory names;</li> <li>is not compatible between 1.8 and 2.x Lustre versions.</li> </ul> <p>I'll attach patches for all of the above right away. (Corporate firewall blocks access to Gerrit, so I cannot push them directly, unfortunately.)</p> LU-2302

Increase lfs_migrate robustness

Improvement Minor Resolved Fixed Keith Mannthey Daniel Kobras patch Thu, 8 Nov 2012 10:31:45 +0000 Mon, 28 Oct 2013 12:58:20 +0000 Mon, 28 Oct 2013 12:58:20 +0000 Lustre 2.4.0 Lustre 2.4.0 0 6 <p>prevent lfs_migrate data disclosure</p> <p>fix lfs_migrate with non-English locale</p> <p>null-terminated file lists in lfs_migrate</p> <p>make lfs_migrate compatible with 1.8</p> <p>Hi Daniel,<br/> thanks for the patches. Sorry not to get back to you sooner. I saw the patches go through my inbox and thought someone else would take a look at them, but I guess that didn't happen. Someone will be importing them into Gerrit soon.</p> <p>I ported the patches into git. lfs-migrate-nullchar.patch and lfs-migrate-sizeopt.patch had a little patch contextual issues that I worked out. I was not able to use "git am". Did you create the patches from "git format-patch" ? </p> <p><a href="http://review.whamcloud.com/4697" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4697</a> is: <a href="https://jira.whamcloud.com/browse/LU-2302" title="Increase lfs_migrate robustness" class="issue-link" data-issue-key="LU-2302"><del>LU-2302</del></a> scripts: fix lfs_migrate with non-English locale (locale)<br/> <a href="http://review.whamcloud.com/4700" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4700</a> is: <a href="https://jira.whamcloud.com/browse/LU-2302" title="Increase lfs_migrate robustness" class="issue-link" data-issue-key="LU-2302"><del>LU-2302</del></a> scripts: null-terminated file lists in lfs_migrate (nullchar)<br/> <a href="http://review.whamcloud.com/4702" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4702</a> is: <a href="https://jira.whamcloud.com/browse/LU-2302" title="Increase lfs_migrate robustness" class="issue-link" data-issue-key="LU-2302"><del>LU-2302</del></a> scripts: make lfs_migrate compatible with 1.8 (sizeopt)<br/> <a href="http://review.whamcloud.com/4699" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4699</a> is: <a href="https://jira.whamcloud.com/browse/LU-2302" title="Increase lfs_migrate robustness" class="issue-link" data-issue-key="LU-2302"><del>LU-2302</del></a> scripts: prevent lfs_migrate data disclosure (umask) </p> <p>Keith, please mark an inspection on these patches (even though you submitted them yourself) in Gerrit, since you didn't actually write them.</p> <p>Daniel,<br/> It seems <a href="http://review.whamcloud.com/4702" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4702</a> scripts: make lfs_migrate compatible with 1.8 (sizeopt) needs a little work.</p> <p>If you submit a 2nd version of the patch I will be happy to put it into git for you.</p> <p>While testing <a href="http://review.whamcloud.com/4702" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4702</a> an error may have been found in test:</p> <p><a href="https://maloo.whamcloud.com/test_sets/120d91a0-5b1a-11e2-8985-52540035b04c" class="external-link" target="_blank" rel="nofollow noopener">https://maloo.whamcloud.com/test_sets/120d91a0-5b1a-11e2-8985-52540035b04c</a></p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>== sanity test 56w: check lfs_migrate -c stripe_count works == 18:28:50 (1357784930) /usr/bin/lfs_migrate -y -c 6 /mnt/lustre/d0.sanity/d56w/file1 /usr/bin/lfs_migrate: line 100: /bin: is a directory sanity test_56w: @@@@@@ FAIL: /usr/bin/lfs_migrate -y -c 6 /mnt/lustre/d0.sanity/d56w/file1 failed </pre> </div></div> <p>Where /usr/bin/lfs_migrate: line 100 is part of the code changed in the patch. </p> <p>Keith, many thanks for taking care of the patches! I was out of office for several weeks but should be more responsive now. As for the test failure, I've added a note in Gerrit indicating the trivial fix. Could you please adjust the patch accordingly?</p> <p>With Change, 4702 landed can this ticket be closed, or is another patch needed?</p> <p>It looks like this was landed for 2.4</p> Development Rank 1|hzvbxr: Rank (Obsolete) 5501