https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-2389 Lustre <p>Comments from Andreas,<br/> "in facet_failover() I still don't agree with the inclusion of sync before triggering failover (which is apparently from <a href="https://jira.whamcloud.com/browse/LU-924" title="Test failure on test suite recovery-small, subtest test_105" class="issue-link" data-issue-key="LU-924"><del>LU-924</del></a>). That is not how failover works in real life and I think it will hide bugs during testing. Also, a change like that does not belong in a patch which describes only changes for DNE testing. Per inspections in the <a href="https://jira.whamcloud.com/browse/LU-924" title="Test failure on test suite recovery-small, subtest test_105" class="issue-link" data-issue-key="LU-924"><del>LU-924</del></a> patch (which is where it should be landed), there are AFAIK only a very small number of tests that may be affected by this problem (basically only after a client first mounts or reconnects after eviction and then does nothing in the few seconds before another eviction) so I'd rather add explicit sync to those tests than for every test, or add some mechanism to only force sync updates to last_rcvd for connections during testing."</p> LU-2389

move sync out of facet_failover

Bug Minor Resolved Duplicate WC Triage Di Wang Tue, 27 Nov 2012 01:11:57 +0000 Tue, 27 Nov 2012 15:25:31 +0000 Tue, 27 Nov 2012 15:25:31 +0000 0 2 <p>Hmm, there is some confusion here. facet_failover() in master does not have any sync calls in it, since commit 5458e96d82a103315095c234c22de0efff7956af landed via <a href="http://review.whamcloud.com/3239" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/3239</a> in <a href="https://jira.whamcloud.com/browse/LU-1582" title="replay-ost-single.sh test_8b: client stuck with -115 (-EINPROGRESS)" class="issue-link" data-issue-key="LU-1582"><del>LU-1582</del></a>. It is only in your patch that sync calls are being added.</p> <p>Was fixed in <a href="https://jira.whamcloud.com/browse/LU-1582" title="replay-ost-single.sh test_8b: client stuck with -115 (-EINPROGRESS)" class="issue-link" data-issue-key="LU-1582"><del>LU-1582</del></a>, we just need to avoid adding them back.</p> Duplicate LU-1582 Development Rank 1|hzvcsv: Rank (Obsolete) 5665 Severity