https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-2426 Lustre <p>when a patch is pushed for review, make -C utils/newwiretest is not done so we have to commit the wiretest modifications</p> LU-2426

newwiretest not run before starting a test

Bug Minor Resolved Not a Bug Bob Glossman CEA Tue, 4 Dec 2012 11:28:21 +0000 Wed, 5 Aug 2020 13:32:55 +0000 Tue, 4 Dec 2012 22:27:56 +0000 0 4 <p>Bob</p> <p>Could you please look into this one?</p> <p>Thanks</p> <p>Peter</p> <p>This is not a bug. Generation of new wiretest.c files is intended to be a manual operation, not automatic in every build. Unless there is a specific need for fresh wiretest source files the previously committed versions are kept and reused in every build.</p> <p>New files are generated by manually invoking 'make newwiretest' after a build, then the new files are committed with 'git commit'.</p> <p>Bob is exactly correct. Changing the network protocol should be an intentional action, which is exactly why we have the wiretest.c programs to verify each build that it has NOT changed.</p> <p>I'm sure we could add <em>more</em> checks to these files, since I don't think they cover enough aspects of the actual protocol usage, but they are at least a reasonable first guard against protocol changes.</p> <p>So when we push a patch we have to push the wiretest.c changes.<br/> The issue is that the code generated does not follow the coding style so if you use the official git hooks you cannot commit (see <a href="https://jira.whamcloud.com/browse/LU-2425" title="wirecheck does not follow new coding style" class="issue-link" data-issue-key="LU-2425"><del>LU-2425</del></a>)</p> Development Rank 1|hzvd8v: Rank (Obsolete) 5751 Severity