https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-2528 Lustre <p>Is this message really necessary:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>2012-12-19 16:10:59 Lustre: Server ls1-OST0143_UUID version (2.3.57.0) is much newer than client version. Consider upgrading client (2.1.2) </pre> </div></div> <p>? I vote for its removal.</p> <p>I feel like I've already opened a ticket on this message, but after a quick search it didn't turn up.</p> LU-2528

Is the "consider upgrading" console message necessary?

Improvement Minor Resolved Fixed Bob Glossman Prakash Surya mn1 shh Wed, 26 Dec 2012 18:49:11 +0000 Tue, 31 Dec 2013 15:54:44 +0000 Thu, 19 Dec 2013 22:14:18 +0000 Lustre 2.1.2 Lustre 2.6.0 Lustre 2.5.1 0 4 <p>Oleg</p> <p>What do you think about this?</p> <p>Peter</p> <p>The actual code in question is:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">if</span> ((ocd-&gt;ocd_connect_flags &amp; OBD_CONNECT_VERSION) &amp;&amp; (ocd-&gt;ocd_version &gt; LUSTRE_VERSION_CODE + LUSTRE_VERSION_OFFSET_WARN || ocd-&gt;ocd_version &lt; LUSTRE_VERSION_CODE - LUSTRE_VERSION_OFFSET_WARN)) { </pre> </div></div> <p>For 2.1 LUSTRE_VERSION_OFFSET_WARN is <tt>OBD_OCD_VERSION(0,0,1,32)</tt>, while on master it is <tt>OBD_OCD_VERSION(0,252,0,0)</tt>, so there will not be any warning messages on 2.4 already. It would be trivial to back-port this larger version margin to 2.1.</p> <p>There shouldn't be a printed message like this printed for any two compatible versions, IMO. I don't see much value in it.</p> <p>It was originally added for the Cray/libcfs clients, which did not have any cross-version interoperability. The Linux client check is more intended to alert administrators if there are clients that are very old <em>before</em> they break due to some incompatible change.</p> <p>In sites like LLNL where the clients are well controlled this is extraneous. In other customer sites where there are a mix of clients this is useful to alert administrators of old clients, and allows us to deprecate support for old versions of Lustre more easily.</p> <p>I'm not dead set on keeping this message, but I think that fixing 2.1 to match master would be enough to avoid the problems reported here.</p> <p>Oleg, any opinions on this?</p> <p>Oh, OK. Well I can see value in using a message to report deprecated releases. Though, it'd be nice to do that in a less intrusive way. IIRC, this message is printed for each connection made, which can spam the console log when using many OSTs or when many disconnect/reconnects happen in a short period of time.</p> <p>I realized we will again have a problem with this for 2.5.n clients connecting to 2.1.(n-1) servers, and vice versa. I've increased the window to be +/- 0.4.50 versions, since we don't plan to allow interoperation between 2.1 and 2.6 releases. It also quiets the warning so that it only prints once.</p> <p>Patch for b2_1: <a href="http://review.whamcloud.com/7917" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/7917</a><br/> Patch for master: <a href="http://review.whamcloud.com/7916" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/7916</a></p> <p>patch landed to master for 2.6.0, closing bug.</p> Development Rank 1|hzve8v: Rank (Obsolete) 5947