https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-2660 Lustre <p>On the ext4 call today I heard from Ted Ts'o that the e2fsck checking for the quota files is broken. Apparently, if there is an error in the quota accounting (e.g. blocks used for user_X in the quota file doesn't match actual blocks counted in inodes owned by user_x) then the whole quota file is rewritten from the in-memory quota table, but the quota limits are not saved. This can be checked by creating a filesystem with quotas, then use debugfs to delete some inodes with allocated data blocks (probably on the OST) and run e2fsck. This probably needs a test in sanity-quota.sh to verify the quota limits after debugfs + e2fsck have been run. </p> <p>A second problem is that the e2fsck quota code does not detect if there is a user that owns inodes/blocks but is not present in the on-disk quota file. If the quota file is somehow corrupted, the user will not have any assigned quota.</p> <p>This is discussed in the linux-ext4 thread with the subject <tt>how to quotacheck with the new quota implementation (hidden inode)?</tt> <a href="http://www.spinics.net/lists/linux-ext4/msg36077.html" class="external-link" target="_blank" rel="nofollow noopener">http://www.spinics.net/lists/linux-ext4/msg36077.html</a>, so it would be good to check for any patches and/or reply to that thread if someone is going to start working on this.</p> LU-2660

e2fsck clears quota limits when error is found

Bug Major Resolved Fixed Niu Yawei Andreas Dilger e2fsprogs Mon, 21 Jan 2013 14:22:52 +0000 Fri, 1 Jul 2016 02:29:14 +0000 Fri, 1 Jul 2016 02:29:14 +0000 Lustre 2.4.0 0 4 <p>The first problem will not affect lustre, since we never set &amp; use the limits in the local fs. I'll monitor the mail thread, and start work on the fix if there is spare time.</p> <p>The second problem has been fixed in upstream and already being included in our tree.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">Author: Theodore Ts'o &lt;tytso@mit.edu&gt; Date: Sat May 10 01:27:31 2014 -0400 quota: fix e2fsck to notice missing quota entries Previously <span class="code-keyword">if</span> there was a missing quota entry --- i.e., <span class="code-keyword">if</span> there were files owned by group <span class="code-quote">"eng"</span>, but there was no quota record <span class="code-keyword">for</span> group <span class="code-quote">"eng"</span>, e2fsck would not notice the missing entry. This means that the usage informtion would not be properly repaired. This is unfortunate. Fix <span class="code-keyword">this</span> by marking each quota record in quota_dict that has a corresponding record on disk, and then check to see <span class="code-keyword">if</span> there are any records in quota_dict that have not been marked as having been seen. In that <span class="code-keyword">case</span>, we know we need to update the relevant quota inode. Signed-off-by: <span class="code-quote">"Theodore Ts'o"</span> &lt;tytso@mit.edu&gt; Reviewed-by: Aditya Kali &lt;adityakali@google.com&gt; </pre> </div></div> <p>Already fixed in upstream.</p> Development Rank 1|hzvftj: Rank (Obsolete) 6209 Severity