Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 [LU-2675] clang: code cleanups for sparse static analyzer https://jira.whamcloud.com/browse/LU-2675 Lustre <p>Tracking for minor cleanups suggested by sparse checker.</p> LU-2675 clang: code cleanups for sparse static analyzer Technical task LU-2753 Minor Resolved Fixed John Hammond John Hammond Thu, 24 Jan 2013 21:45:42 +0000 Fri, 9 Sep 2016 22:35:34 +0000 Tue, 27 Jan 2015 19:15:21 +0000 Lustre 2.4.0 Lustre 2.7.0 0 7 <p><a href="http://review.whamcloud.com/5166" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/5166</a> make bitfield (un)signedness explicit</p> <p><a href="http://review.whamcloud.com/5175" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/5175</a> remove User Mode Linux specific code</p> <p><a href="http://review.whamcloud.com/5177" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/5177</a> remove unused mkdirdeep.c lltrace.h</p> <p><a href="http://review.whamcloud.com/5178" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/5178</a> static and extern corrections for libcfs</p> <p><a href="http://review.whamcloud.com/5190" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/5190</a> remove unused recov_thread.c and llog code</p> <p>5166: make bitfield (un)signedness explicit landed.<br/> 5175: remove User Mode Linux specific code landed.</p> <p><a href="http://review.whamcloud.com/5580" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/5580</a> echo: remove #if 0-ed out regions from echo_client.c</p> <p><a href="http://review.whamcloud.com/5581" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/5581</a> lov: remove some dead lov code</p> <p><a href="http://review.whamcloud.com/6660" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/6660</a> lvfs: cleanup lvfs.h and collateral</p> <p><a href="http://review.whamcloud.com/6969" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/6969</a> cleanup: define sparse annotations for libcfs</p> <p>Patches have landed to Master. If more work is needed, please reopen a new ticket.</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/12849" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12849</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> llite: remove lli_lvb<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 71221e7d27dfdab6ad7703d38a61b583349131af</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/12850" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12850</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> llite: remove some cl wrappers<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 08468ad376f32ce13e9d7f9d9ff33773df26a1f6</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/12851" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12851</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> llapi: find_param cleanup part II<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: c4903fb9ed29e7533f2d4952dd914a227902dbf2</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/12893" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12893</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> mdc: remove mdc_sendpage()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: b37b334193fc18b43ea3b0689c5746da8171255e</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/12922" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12922</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> obd: remove destroy cookie handling<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: bb3e63fd06dd9545326ba6ed773fe6734abe695d</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12113/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12113/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> md: remove unused code from md_object.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e18a3a687ccc08fa3907f2687c0a3da30fd79958</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12115/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12115/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> lmv: remove lmv_init_</p> {lock,unlock} <p>()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 7c814c2971be916520bd552f44173b41140ebac6</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12117/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12117/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> lnet: remove ulnds<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 86b8c3319b01e5ab03b1285012db1c7b18ddd908</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12231/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12231/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> obd: remove client_obd_lock_t<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 79c00733d0b4f8662b630fa2c6c1d475eb7556d2</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/12932" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12932</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> lnet: remove lnet/include/lnet/linux/<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: daa878f5b16c45809609534abec8035414a1d3dc</p> <p>Now that the lnet/ulnds code has been removed, the code under lnet/lnet that supports userspace LNDs should be removed as well. To find such code, just: </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>grep __KERNEL__ lnet/lnet/*.[ch] </pre> </div></div> <p>Isaac,</p> <p>Yes. I will push a patch eventually to do this. I would like to sort out the headers a bit first. lib-types.h contains some structures and defines that are shared by kernel space and user space, and some that are kernel only. I could move the shared stuff to lnet/types.h, or to some other header, or to a new header. Once it is clear which headers are shared I will unifdef _<em>KERNEL</em>_ all the others along with the appropriate .c files.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12849/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12849/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> llite: remove lli_lvb<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 0c6776db8cce84fd623c76a18df93759f2fcaed4</p> <p>Patch landed to Master. <br/> Please open a new specific ticket if there is any additional work needed.</p> <p>As part of this change we should ensure that we remove the_lnet.ln_eq_waitni and associated logic, since this is not used at all for the LNet Kernel code.</p> <p>Also, many Doxygen comments over lnet APIs (those whose names begin with LNet) include stuff that only applies to user space. Those can be removed as well.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12851/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12851/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> llapi: find_param cleanup part II<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 530763d717189fd57c48b352ba4d13a751a2ba64</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12893/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12893/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> mdc: remove mdc_sendpage()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 017c04a20bb9adc42faf0c6b8226e5109008ee80</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/13121" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13121</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> lnet: assume a kernel build<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 2b19d2d27cd6cbe5e791de40505ad55d0dc0d37a</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/13123" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13123</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> obd: remove linux/obd.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: cac5222019f65561c3b9d1eb10e7e403faba3b32</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12850/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12850/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> llite: remove some cl wrappers<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 1224f40d2e5be236b76b4013e4d926b77a56a3da</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/12932/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/12932/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> lnet: remove lnet/include/lnet/linux/<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: aab1d832130ee5c181cf7e0e5aa555244d150b00</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13123/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13123/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> obd: remove linux/obd.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: ff56dc60715dd40bfbf5acd7e46637a098eef52f</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/13196" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13196</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> build: remove obsolete Kernelenv files<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 74b124ccad08e9400da643fc46fda9d2e0b44020</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13196/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13196/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> build: remove obsolete Kernelenv files<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 4a2c8c8db7b106f24cb0d44a8973ef2a6d3725c5</p> <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/13271" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13271</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> lustre: remove lustre/include/linux/<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: e131d84e8c00a640a4aa178567064604f08f3b07</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13271/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13271/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> lustre: remove lustre/include/linux/<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: bca975c7fa261ffb926e8a18d5869b886c65f447</p> <p>James Simmons (uja.ornl@gmail.com) uploaded a new patch: <a href="http://review.whamcloud.com/13339" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13339</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> build: Fix build issue with lustre-core.m4<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 7a1871ba81eafe9f69e260d6cf36715911d715b7</p> <p>Li Xi (pkuelelixi@gmail.com) uploaded a new patch: <a href="http://review.whamcloud.com/13495" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13495</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> lustre: remove lustre/include/linux for debian<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1d42b88d14492a5cd45efd25d79b9750bd9e3e18</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13495/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13495/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> lustre: remove lustre/include/linux for debian<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 47f51b79b0edf3869ab8dc1dc0e133ca1e9c4349</p> <p>Patches landed to Master.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13121/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13121/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> lnet: assume a kernel build<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: faeb94fe81e4646b3121c263521d30e0e83fa71f</p> <p>Isaac Huang (he.huang@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/13698" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13698</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> lnet: remove unnecessary goto<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1cba6a5beedbdd4bc1c30a4d354d8e9e89516a1f</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13698/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13698/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> lnet: remove unnecessary goto<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 015d4763eb41be60731aa62aac58b568c9fc2b16</p> <p>Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/17593" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17593</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2675" title="clang: code cleanups for sparse static analyzer" class="issue-link" data-issue-key="LU-2675"><del>LU-2675</del></a> utils: restore lshowmount utility<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 7a0ab07dfb55bf853bf2b0f22e75d845acbe209d</p> Related LU-871 LU-8599 LU-4962 LUDOC-349 Development Epic Rank 1|hzvg1z: Rank (Obsolete) 6248