Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 [LU-2682] clean up direct _id and _seq access, use ost_id everywhere https://jira.whamcloud.com/browse/LU-2682 Lustre <p>There are a number of cleanups that should be done for the ost_id members of various structures.</p> <p>Access/copying the individual _id and _seq fields should be replaced with the _oi field, and compatibility macros for accessing the individual fields should be removed.</p> <p>POID/DOID macros should be introduced to print out the _oi fields, similar to PFID/DFID is used for lu_fid fields. Johann had a patch for doing some of this in <a href="http://review.whamcloud.com/2004" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2004</a> that needs to be refreshed and resubmitted.</p> LU-2682 clean up direct _id and _seq access, use ost_id everywhere Technical task LU-1185 Major Resolved Fixed Di Wang Andreas Dilger Fri, 25 Jan 2013 18:35:31 +0000 Thu, 28 Mar 2013 15:03:27 +0000 Thu, 28 Mar 2013 15:03:27 +0000 Lustre 2.4.0 Lustre 2.4.0 0 3 <p>As part of this ost_id cleanup patch, please rename <tt>lsm_object_oid</tt> to <tt>lsm_oi</tt> or <tt>lsm_ostid</tt>, if it hasn't been done through a refresh of <a href="http://review.whamcloud.com/3081" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/3081</a>. It would be good to use a similar field name "<b>_oi" or "</b>_ostid" for other ost_id members in other structures as well.</p> <p>Di, I still see a lot of code like:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> oa-&gt;o_id = lsm-&gt;lsm_object_id; oa-&gt;o_seq = lsm-&gt;lsm_object_seq; </pre> </div></div> <p>that should be replaced with:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> oa-&gt;o_oi = lsm-&gt;lsm_object_oid; </pre> </div></div> <p>also, lsm_object_oid should be renamed lsm_oi or lsm_ostid so that it is not confused with f_oid.</p> <p> <a href="http://review.whamcloud.com/5601" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/5601</a></p> <p>Landed for 2.4</p> Related LU-2684 Development Rank 1|hzvg6n: Rank (Obsolete) 6269