https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-27 Lustre <p>We are hitting frequent MDS hangs at Titech due to LBUG caused by "no handle for file close in mds_close()".<br/> it looks like similar bug 22104 and 22528, but no solution and patches yet to address this problem.<br/> could you have a look at attachment and any suggestions?</p> LU-27

(mds_open.c:1667:mds_close()) @@@ no handle for file close ino

Bug Minor Resolved Fixed Niu Yawei Shuichi Ihara Fri, 17 Dec 2010 16:28:18 +0000 Tue, 28 Jun 2011 15:01:40 +0000 Tue, 8 Feb 2011 11:20:16 +0000 Lustre 1.8.6 Lustre 1.8.6 0 1 <p>I think the LBUG is because error handler in mds_verify_child() is not quite right:</p> <p> switch(cleanup_phase) {<br/> case 2:<br/> if (child_res_id-&gt;name<span class="error">&#91;0&#93;</span> != 0)<br/> ldlm_lock_decref(child_lockh, child_mode);</p> <p>we do have chance to get "child_res_id-&gt;name<span class="error">&#91;0&#93;</span> != 0" and "child_lockh == NULL" at here, probably Niu can look into it to see whether these is any other issue, as he is also working on open/close related code for 2.x? </p> <p>Assigned to Niu, per Liang's comments and suggestion. </p> <p>Yes, there are some defects in the mds_verify_child():</p> <ul class="alternate" type="square"> <li>Wrongly decref child lock in the "no child lock wanted" case;</li> <li>Wrongly decref parent lock in the "reget child lock successfully" case;</li> </ul> <p>This bug isn't necessarily caused by the "no handle for file close in mds_close()", so I think it's not similar to bug 22104 and 22528.</p> <p>Will post a patch for review soon.</p> <p>Niu, just confirmation. you did file this on bugzilla as 24360, then moving forward to review patches, right?</p> <p>Yes, the patch has been posted on BZ and Gerrit for review.</p> <p>It looks like this patch has landed on the Oracle 1.8.6. Is the same fix needed for master? </p> <p>No, the master doesn't have this bug.</p> <p>Great! So, does any work remain or can we mark this issue as resolved?</p> <p>Yes, I think we can mark this as resolved, not sure if it should be marked by reporter or assignee.</p> <p>ok I will mark it as resolved. Ihara, please reopen if you feel that this is inappropriate</p> Development Rank 1|hzw2an: Rank (Obsolete) 10454 Severity