https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-2745 Lustre <p>NULL == msg cause lockup</p> LU-2745

lnet_create_reply_msg

Bug Minor Resolved Fixed Liang Zhen thfeathers Mon, 4 Feb 2013 07:31:43 +0000 Tue, 31 Dec 2013 15:54:22 +0000 Tue, 19 Nov 2013 14:06:59 +0000 Lustre 2.6.0 Lustre 2.4.2 Lustre 2.5.1 0 2 <p>Could you provide a little more details? e.g. which version and when it can happen, how the lockup looks like, thanks.</p> <p>i just browsed the source code 2.3.0 <br/> function : lnet_create_reply_msg<br/> //------------------------------------------------------------------<br class="atl-forced-newline" /></p> <p>cpt = lnet_cpt_of_cookie(getmd-&gt;md_lh.lh_cookie);<br/> lnet_res_lock(cpt);<font color="red">//lock res</font></p> <p> LASSERT (getmd-&gt;md_refcount &gt; 0);</p> <p> if (msg == NULL) {<br/> CERROR ("%s: Dropping REPLY from %s: can't allocate msg\n",<br/> libcfs_nid2str(ni-&gt;ni_nid), libcfs_id2str(peer_id));<br/> <font color="red">//------------------here!goto with hold the res lock</font><br/> goto drop;<br/> }</p> <p> if (getmd-&gt;md_threshold == 0) {<br/> CERROR ("%s: Dropping REPLY from %s for inactive MD %p\n",<br/> libcfs_nid2str(ni-&gt;ni_nid), libcfs_id2str(peer_id), <br/> getmd);<br/> <font color="red">//-------------------here!goto with release the res lock</font><br/> lnet_res_unlock(cpt);<br/> goto drop;<br/> }</p> <p>ah, thanks, I will post a patch.</p> <p>patch is here: <a href="http://review.whamcloud.com/#change,5542" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,5542</a></p> <p>patch landed</p> <p>hmm, it's not landed, reopen it.</p> <p>It's landed for 2.6 now <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> Development Rank 1|hzviiv: Rank (Obsolete) 6669 Severity