https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-2771 Lustre <p>There is an 8 byte write only field and some separated flag bits that trigger another 8 bytes of extra alignment padding that are not necessary. There are also a couple of fields that are only used on the server side and others only used on the client side. These fields could be overlaid, with 24 bytes easily saved. This is important on systems where 100's of thousands of these structures get allocated.</p> <p>My first comment will show one approach for coalescing all the flag bits into a single 64 bit flag word.</p> LU-2771

Wasted space in ldlm_lock structure

Improvement Minor Resolved Fixed Keith Mannthey Bruce Korb locking patch Wed, 6 Feb 2013 10:48:04 +0000 Thu, 19 Jan 2023 15:32:27 +0000 Fri, 7 Jun 2013 17:02:42 +0000 Lustre 2.5.0 0 5 <p>an approximation of the new bit field code</p> <p><a href="http://jira-nss.xy01.xyratex.com:8080/browse/MRP-376" class="external-link" target="_blank" rel="nofollow noopener">Xyratex bug id MRP-376</a></p> <p>Bruce, it is easier to review changes in the form of a patch. If you are just looking for comments and not landing, please add in the commit comment:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Test-Parameters: fortestonly testlist=runtests </pre> </div></div> <p>so that it will run only the one test. We don't have a "don't test anything" marker yet.</p> <p>OK, coming. That generated header was sufficiently preliminary that I was not sure it would compile even. Actually, I'd guess it would not. <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/> But the approach is visible. Another 30-60 minutes, and I should have something that compiles.</p> <p>And I've removed the osc_ldlm_weigh_ast() -&gt; ei_cb_wg -&gt; lcs_weigh -&gt; dead store in l_weigh_ast chain.</p> <p><a href="http://review.whamcloud.com/#change,5312" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,5312</a> &#8211; Patch Set 11: No score<br/> trying a new review</p> <p>That's right - I remember: error: excess elements in struct initializer</p> <p>There was more to it than just removing an assignment. There were the initializers, too.<br/> Tomorrow.</p> <p>Andreas Dilger Mar 4</p> <p>Patch Set 8: Looks good to me, approved</p> <p>(3 inline comments)</p> <p>Some minor style issues if patch is refreshed</p> <p>Maloo Mar 9</p> <p>Patch Set 8: Verified</p> <p>Tests received by maloo, run on CentOS release 6.3/x86_64: (<a href="https://maloo.whamcloud.com/test_sessions/ce9b01e0-88ba-11e2-b643-52540035b04c" class="external-link" target="_blank" rel="nofollow noopener">https://maloo.whamcloud.com/test_sessions/ce9b01e0-88ba-11e2-b643-52540035b04c</a>). Ran 12 tests. No failures.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Artem Blagodarenko 12:28 AM Patch Set 13: Bruce, please, re-submit the patch, because LU-2988 was submitted after your testing is failed. Thanks.</pre> </div></div> <p><del>14</del> 15 coming up. It <em>will</em> get installed before it gets obsolete this time, I am sure.</p> <p><a href="http://review.whamcloud.com/#change,5312" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,5312</a> – Patch Set <del>14</del> 15</p> <p><a href="https://jira.whamcloud.com/browse/LU-2906" title="ldlm_{is,set,clear}_bitname macros should replace bit fiddling code" class="issue-link" data-issue-key="LU-2906"><del>LU-2906</del></a> was opened to track replacing direct bit fiddling operations with accessor macros.</p> <p>Thanks for link to the macro work. </p> <p>5312 has been merged into Master. </p> <p>"Andreas Dilger &lt;adilger@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49563" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49563</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2771" title="Wasted space in ldlm_lock structure" class="issue-link" data-issue-key="LU-2771"><del>LU-2771</del></a> ldlm: remove obsolete LDLM_FL_SERVER_LOCK<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: b045e816a75667e931af60214811c7476202a3f0</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/49563/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/49563/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-2771" title="Wasted space in ldlm_lock structure" class="issue-link" data-issue-key="LU-2771"><del>LU-2771</del></a> ldlm: remove obsolete LDLM_FL_SERVER_LOCK<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: cb0aa0285b32fb432fc484cfd44e6e6e789c1025</p> Development Rank 1|hzviqn: Rank (Obsolete) 6713