<!-- 
RSS generated by JIRA (9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c) at Sat Feb 10 01:28:17 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Whamcloud Community JIRA</title>
    <link>https://jira.whamcloud.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.4.14</version>
        <build-number>940014</build-number>
        <build-date>05-12-2023</build-date>
    </build-info>


<item>
            <title>[LU-2798] error: variable &#8216;site&#8217; set but not used</title>
                <link>https://jira.whamcloud.com/browse/LU-2798</link>
                <project id="10000" key="LU">Lustre</project>
                    <description>&lt;p&gt;$ /usr/linux-k1om-4.7/bin/x86_64-k1om-linux-gcc -v&lt;br/&gt;
Using built-in specs.&lt;br/&gt;
COLLECT_GCC=/usr/linux-k1om-4.7/bin/x86_64-k1om-linux-gcc&lt;br/&gt;
COLLECT_LTO_WRAPPER=/usr/linux-k1om-4.7/libexec/gcc/x86_64-k1om-linux/4.7.0/lto-wrapper&lt;br/&gt;
Target: x86_64-k1om-linux&lt;br/&gt;
Configured with: ../../gcc-4.7/configure --target=x86_64-k1om-linux --enable-languages=c,c++,fortran --disable-multilib --with-demangler-in-ld --with-sysroot=/usr/linux-k1om-4.7/linux-k1om --prefix=/usr/linux-k1om-4.7 --with-local-prefix=/usr/local --with-gmp-lib=/usr/local/lib&lt;br/&gt;
Thread model: posix&lt;br/&gt;
gcc version 4.7.0 20110509 (experimental) 4.7.0 (GCC)&lt;/p&gt;

&lt;p&gt;cl_lock.c: In function &#8216;cl_lock_put&#8217;:&lt;br/&gt;
cl_lock.c:308:34: error: variable &#8216;site&#8217; set but not used &lt;span class=&quot;error&quot;&gt;&amp;#91;-Werror=unused-but-set-variable&amp;#93;&lt;/span&gt;&lt;br/&gt;
cc1: all warnings being treated as errors&lt;/p&gt;

&lt;p&gt;lmv_obd.c: In function &#8216;lmv_connect_mdc&#8217;:&lt;br/&gt;
lmv_obd.c:347:34: error: variable &#8216;mdc_data&#8217; set but not used &lt;span class=&quot;error&quot;&gt;&amp;#91;-Werror=unused-but-set-variable&amp;#93;&lt;/span&gt;&lt;br/&gt;
cc1: all warnings being treated as errors&lt;/p&gt;</description>
                <environment></environment>
        <key id="17535">LU-2798</key>
            <summary>error: variable &#8216;site&#8217; set but not used</summary>
                <type id="1" iconUrl="https://jira.whamcloud.com/secure/viewavatar?size=xsmall&amp;avatarId=11303&amp;avatarType=issuetype">Bug</type>
                                            <priority id="4" iconUrl="https://jira.whamcloud.com/images/icons/priorities/minor.svg">Minor</priority>
                        <status id="6" iconUrl="https://jira.whamcloud.com/images/icons/statuses/closed.png" description="The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.">Closed</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="3">Duplicate</resolution>
                                        <assignee username="wc-triage">WC Triage</assignee>
                                    <reporter username="dmiter">Dmitry Eremin</reporter>
                        <labels>
                    </labels>
                <created>Tue, 12 Feb 2013 10:14:19 +0000</created>
                <updated>Fri, 15 Feb 2013 13:21:58 +0000</updated>
                            <resolved>Fri, 15 Feb 2013 13:21:58 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>2</watches>
                                                                            <comments>
                            <comment id="52265" author="dmiter" created="Wed, 13 Feb 2013 07:40:51 +0000"  >&lt;p&gt;The first variable was not not removed after following commit:&lt;/p&gt;
&lt;div class=&quot;panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;panelHeader&quot; style=&quot;border-bottom-width: 1px;&quot;&gt;&lt;b&gt;variable &#8216;site&#8217; set but not used&lt;/b&gt;&lt;/div&gt;&lt;div class=&quot;panelContent&quot;&gt;
&lt;p&gt;commit 5cae09a2409dcd396a1ee7be1eca7d3bbf77365e&lt;br/&gt;
Author: Jinshan Xiong &amp;lt;jinshan.xiong@intel.com&amp;gt;&lt;br/&gt;
Date:   Fri Dec 7 10:01:53 2012 -0800&lt;/p&gt;

&lt;p&gt;    &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-744&quot; title=&quot;Single client&amp;#39;s performance degradation on 2.1&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-744&quot;&gt;&lt;del&gt;LU-744&lt;/del&gt;&lt;/a&gt; obdclass: revise stats for cl_object cache&lt;/p&gt;

&lt;p&gt;    It turns out that atomic doesn&apos;t scale well for highly contented&lt;br/&gt;
    cl_page stats. Enable it only when CONFIG_DEBUG_PAGESTATE_TRACKING&lt;br/&gt;
    is turned on.&lt;/p&gt;

&lt;p&gt;    Signed-off-by: Jinshan Xiong &amp;lt;jinshan.xiong@intel.com&amp;gt;&lt;br/&gt;
    Change-Id: I0163f65557135759f100fddde70c7e3ee2e45aed&lt;br/&gt;
    Reviewed-on: &lt;a href=&quot;http://review.whamcloud.com/4519&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/4519&lt;/a&gt;&lt;br/&gt;
    Tested-by: Hudson&lt;br/&gt;
    Reviewed-by: Andreas Dilger &amp;lt;andreas.dilger@intel.com&amp;gt;&lt;br/&gt;
    Tested-by: Maloo &amp;lt;whamcloud.maloo@gmail.com&amp;gt;&lt;br/&gt;
    Reviewed-by: Bobi Jam &amp;lt;bobijam@gmail.com&amp;gt;&lt;/p&gt;

&lt;p&gt;diff --git a/lustre/obdclass/cl_lock.c b/lustre/obdclass/cl_lock.c&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;+#ifdef CONFIG_DEBUG_PAGESTATE_TRACKING
+#define CS_LOCK_INC(o, item) \
+       cfs_atomic_inc(&amp;amp;cl_object_site(o)-&amp;gt;cs_locks.cs_stats[CS_##item])
+#define CS_LOCK_DEC(o, item) \
+       cfs_atomic_dec(&amp;amp;cl_object_site(o)-&amp;gt;cs_locks.cs_stats[CS_##item])
+#define CS_LOCKSTATE_INC(o, state) \
+        cfs_atomic_inc(&amp;amp;cl_object_site(o)-&amp;gt;cs_locks_state[state])
+#define CS_LOCKSTATE_DEC(o, state) \
+        cfs_atomic_dec(&amp;amp;cl_object_site(o)-&amp;gt;cs_locks_state[state])
+#else
+#define CS_LOCK_INC(o, item)
+#define CS_LOCK_DEC(o, item)
+#define CS_LOCKSTATE_INC(o, state)
+#define CS_LOCKSTATE_DEC(o, state)
+#endif
[...]
@@ -269,8 +285,8 @@ static void cl_lock_free(const struct lu_env *env, struct cl
                 cfs_list_del_init(lock-&amp;gt;cll_layers.next);
                 slice-&amp;gt;cls_ops-&amp;gt;clo_fini(env, slice);
         }
-        cfs_atomic_dec(&amp;amp;cl_object_site(obj)-&amp;gt;cs_locks.cs_total);
-        cfs_atomic_dec(&amp;amp;cl_object_site(obj)-&amp;gt;cs_locks_state[lock-&amp;gt;cll_state]);
+       CS_LOCK_DEC(obj, total);
+       CS_LOCKSTATE_DEC(obj, lock-&amp;gt;cll_state);
         lu_object_ref_del_at(&amp;amp;obj-&amp;gt;co_lu, lock-&amp;gt;cll_obj_ref, &quot;cl_lock&quot;, lock);
         cl_object_put(env, obj);
         lu_ref_fini(&amp;amp;lock-&amp;gt;cll_reference);
@@ -308,7 +324,7 @@ void cl_lock_put(const struct lu_env *env, struct cl_lock *l
                         LASSERT(cfs_list_empty(&amp;amp;lock-&amp;gt;cll_linkage));
                         cl_lock_free(env, lock);
                 }
-                cfs_atomic_dec(&amp;amp;site-&amp;gt;cs_locks.cs_busy);
+               CS_LOCK_DEC(obj, busy);
         }
         EXIT;
 }
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;The second variable was not not removed after following commit:&lt;/p&gt;
&lt;div class=&quot;panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;panelHeader&quot; style=&quot;border-bottom-width: 1px;&quot;&gt;&lt;b&gt;variable &#8216;mdc_data&#8217; set but not used&lt;/b&gt;&lt;/div&gt;&lt;div class=&quot;panelContent&quot;&gt;
&lt;p&gt;commit b3a53261ee18bf0c00e509208a5729890347d582&lt;br/&gt;
Author: wangdi &amp;lt;di.wang@whamcloud.com&amp;gt;&lt;br/&gt;
Date:   Fri Nov 1 05:50:24 2013 -0700&lt;/p&gt;

&lt;p&gt;    &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-1187&quot; title=&quot;DNE Phase 1: Remote Directories&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-1187&quot;&gt;&lt;del&gt;LU-1187&lt;/del&gt;&lt;/a&gt; lmv: allocate lmv tgts array by index&lt;/p&gt;

&lt;p&gt;    Allocate lmv tgts array by MDT index, which is similar as lov&lt;br/&gt;
    tgts arrary, so the index of tgts will be decided by MDT index,&lt;br/&gt;
    instead of mount sequence in current implementation.&lt;/p&gt;

&lt;p&gt;    Signed-off-by: wang di &amp;lt;di.wang@intel.com&amp;gt;&lt;br/&gt;
    Change-Id: If4903553251e1dba653aa79fb02bce581580629f&lt;br/&gt;
    Reviewed-on: &lt;a href=&quot;http://review.whamcloud.com/4936&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/4936&lt;/a&gt;&lt;br/&gt;
    Tested-by: Hudson&lt;br/&gt;
    Reviewed-by: Fan Yong &amp;lt;fan.yong@intel.com&amp;gt;&lt;br/&gt;
    Tested-by: Maloo &amp;lt;whamcloud.maloo@gmail.com&amp;gt;&lt;br/&gt;
    Reviewed-by: Andreas Dilger &amp;lt;andreas.dilger@intel.com&amp;gt;&lt;br/&gt;
diff --git a/lustre/lmv/lmv_obd.c b/lustre/lmv/lmv_obd.c&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;-        /*
-         * Copy connect data, it may be used later.
-         */
-        lmv-&amp;gt;datas[tgt-&amp;gt;ltd_idx] = *mdc_data;
-
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;/div&gt;&lt;/div&gt;</comment>
                            <comment id="52456" author="jlevi" created="Fri, 15 Feb 2013 13:21:58 +0000"  >&lt;p&gt;duplicate of &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-2810&quot; title=&quot;cl_lock.c:308:34: error: variable &#8216;site&#8217; set but not used&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-2810&quot;&gt;&lt;del&gt;LU-2810&lt;/del&gt;&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10010">
                    <name>Duplicate</name>
                                            <outwardlinks description="duplicates">
                                        <issuelink>
            <issuekey id="17571">LU-2810</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                            <customfield id="customfield_10890" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10390" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hzvizz:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>6774</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10060" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Severity</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10022"><![CDATA[3]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>