https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-2800 Lustre <p>It currently takes longer to run configure on the Lustre source than it does to build it. There are a ton of configure tests that can be removed in light of the support matrix for 2.4+</p> LU-2800

build: clean out old autoconf options

Bug Minor Resolved Fixed Bob Glossman Jeff Mahoney patch Wed, 13 Feb 2013 00:37:54 +0000 Tue, 17 Dec 2013 06:00:16 +0000 Mon, 2 Dec 2013 13:47:41 +0000 Lustre 2.6.0 Lustre 2.4.2 0 12 <p>Oleg mentioned that configure can be built with caching support so that many tests can use results of the previous configure runs.</p> <p>There's not a ton of duplication in the testing and it already does some caching.</p> <p>I have a patchset that removes all of the obsolete ones. I'm just cleaning it up to pass the pre-commit checks for Gerrit.</p> <p>(Edited long list of commits)</p> <p>This method makes it much more difficult to review patch series. I'll group all of the ones that only remove code together and refactor.</p> <p>Improving configure time is much appreciated. Thanks for looking into this, Jeff.</p> <p>Is there any way to get the config.log out of Jenkins? <a href="http://review.whamcloud.com/5371" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/5371</a> works fine for me locally with both SLES and RHEL but is failing there.</p> <p><a href="http://review.whamcloud.com/5505" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/5505</a> contains 53 of the test removal commits in one. Outside of modifying another test when removing a dependency, there is only code removal.</p> <p>Ok, I added some debugging output to 5371 so that it dumps find $LINUX/include $LINUX/fs as well as the config.log, so I can see what's going on.</p> <p>The 64-bit quota stuff wants fs/quota/quotaio_v2.h, but it looks like the build environment only provides actual files other than Makefile and Kconfig under fs/ext3 and fs/ext4.</p> <p>I can see the needed files in my own RHEL6 kernel tree, but not in the Jenkins environment. What creates that? Can it be modified to provide those files as well? <a href="http://build.whamcloud.com/job/lustre-reviews/13535/" class="external-link" target="_blank" rel="nofollow noopener">http://build.whamcloud.com/job/lustre-reviews/13535/</a> contains the debugging output for reference.</p> <p>Bob</p> <p>Could you please keep an eye on this one?</p> <p>thanks</p> <p>Peter</p> <p>Jeff, Am I correct in thinking the myriad of previous autoconf patches are now combined into <a href="http://review.whamcloud.com/#change,5546" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,5546</a> and <a href="http://review.whamcloud.com/#change,5505" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,5505</a> making all the earlier ones obsolete?</p> <p>No. I combined all the ones that only removed code. I marked the ones that I merged into 5505 as abandoned already. There are still a bunch more that do either slight or more involved modifications.</p> <p>Hi Jeff,</p> <p>Did you try to compare the time it saved after the clean up?</p> <p>Is there list of updated patches?</p> <p>Alexey, Not sure I understand the question. Can you just look at the git history on ldiskfs/kernel_patches or lustre/kernel_patches and find what you want to know?</p> <p>If you mean has it been refreshed, I have a refreshed version I can push. I've been holding off since Chris was talking about "false positives" but he hasn't commented since.</p> <p>Finish the first round of the painful resynchronizing of the patches. All the patch for this ticket we be viewed with</p> <p><a href="http://review.whamcloud.com/#/q/status:open+message:LU-2800,n,z" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/q/status:open+message:LU-2800,n,z</a></p> <p>Please be aware all patches are against master so if you attempted to apply them all some patches will collide. Having dependencies between patches delays the landing process and we don't know which patches will be merged first.</p> <p>Because of the "painful resynchronizing" process, it would be great if these can get some attention from Oleg before they become stale again. I'd hate to see cleanup like this die due to lack of attention.</p> <p>Luckily most of the smaller patches will not collide often with other non <a href="https://jira.whamcloud.com/browse/LU-2800" title="build: clean out old autoconf options" class="issue-link" data-issue-key="LU-2800"><del>LU-2800</del></a> patches. The the big is <a href="http://review.whamcloud.com/#/c/5505" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5505</a> which can easily end up in the rebase treadmill.</p> <p>The follow matches make the next series to merge. They will not conflict with master as it stands or each other.</p> <p><a href="http://review.whamcloud.com/#/c/5336" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5336</a><br/> <a href="http://review.whamcloud.com/#/c/5340" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5340</a><br/> <a href="http://review.whamcloud.com/#/c/5343" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5343</a><br/> <a href="http://review.whamcloud.com/#/c/5345" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5345</a><br/> <a href="http://review.whamcloud.com/#/c/5347" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5347</a><br/> <a href="http://review.whamcloud.com/#/c/5353" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5353</a><br/> <a href="http://review.whamcloud.com/#/c/5384" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5384</a><br/> <a href="http://review.whamcloud.com/#/c/5393" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5393</a><br/> <a href="http://review.whamcloud.com/#/c/5411" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5411</a></p> <p>The follow patches are the next series to merge. They will not conflict with master or each other. Please review if you haven't already.</p> <p><a href="http://review.whamcloud.com/#/c/5338" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5338</a><br/> <a href="http://review.whamcloud.com/#/c/5340" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5340</a><br/> <a href="http://review.whamcloud.com/#/c/5347" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5347</a><br/> <a href="http://review.whamcloud.com/#/c/5359" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5359</a><br/> <a href="http://review.whamcloud.com/#/c/5369" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5369</a><br/> <a href="http://review.whamcloud.com/#/c/5411" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5411</a></p> <p>New series ready to merge. They will not conflict with master or each other. Please review if you haven't already.</p> <p><a href="http://review.whamcloud.com/#/c/5340" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5340</a><br/> <a href="http://review.whamcloud.com/#/c/5347" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5347</a><br/> <a href="http://review.whamcloud.com/#/c/5348" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5348</a><br/> <a href="http://review.whamcloud.com/#/c/5360" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5360</a><br/> <a href="http://review.whamcloud.com/#/c/5411" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5411</a></p> <p>Next series is ready. They will not conflict with current master or each other.</p> <p><a href="http://review.whamcloud.com/#/c/5339" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5339</a><br/> <a href="http://review.whamcloud.com/#/c/5347" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5347</a><br/> <a href="http://review.whamcloud.com/#/c/5411" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5411</a><br/> <a href="http://review.whamcloud.com/#/c/5367" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5367</a><br/> <a href="http://review.whamcloud.com/#/c/5403" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5403</a></p> <p>The following patches are dependent on the above and have to be applied in the specific order below.</p> <p><a href="http://review.whamcloud.com/#/c/5370" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5370</a><br/> <a href="http://review.whamcloud.com/#/c/5374" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5374</a><br/> <a href="http://review.whamcloud.com/#/c/5406" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5406</a></p> <p>Besides these only a few more patches will be needed after these land. The reason for not posting those patches is that they conflict with multiple patches above.</p> <p>If you have not done so please review the patches below. All of them are ready to be merged. Thank you.</p> <p><a href="http://review.whamcloud.com/#/c/5339" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5339</a><br/> <a href="http://review.whamcloud.com/#/c/5347" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5347</a><br/> <a href="http://review.whamcloud.com/#/c/5411" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5411</a><br/> <a href="http://review.whamcloud.com/#/c/5367" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5367</a><br/> <a href="http://review.whamcloud.com/#/c/5403" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5403</a></p> <p><a href="http://review.whamcloud.com/#/c/5370" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5370</a><br/> <a href="http://review.whamcloud.com/#/c/5374" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5374</a><br/> <a href="http://review.whamcloud.com/#/c/5406" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5406</a></p> <p>The patches ready for inspection are:</p> <p><a href="http://review.whamcloud.com/#/c/5347" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5347</a><br/> <a href="http://review.whamcloud.com/#/c/5374" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5374</a><br/> <a href="http://review.whamcloud.com/#/c/5406" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5406</a></p> <p><a href="http://review.whamcloud.com/#/c/5371" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5371</a><br/> <a href="http://review.whamcloud.com/#/c/5546" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5546</a></p> <p>We are down to the last few patches. They are:</p> <p><a href="http://review.whamcloud.com/#/c/5347" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5347</a><br/> <a href="http://review.whamcloud.com/#/c/5383" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5383</a><br/> <a href="http://review.whamcloud.com/#/c/5546" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5546</a><br/> <a href="http://review.whamcloud.com/#/c/8102" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/8102</a></p> <p><a href="http://review.whamcloud.com/#/c/5380" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5380</a> - depends on patch <a href="http://review.whamcloud.com/#/c/7135" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/7135</a> for <a href="https://jira.whamcloud.com/browse/LU-3319" title="Adapt to 3.10 upstream kernel proc_dir_entry change" class="issue-link" data-issue-key="LU-3319"><del>LU-3319</del></a></p> <p>Only three patches to go. Please review the following patches.</p> <p><a href="http://review.whamcloud.com/#/c/5347" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5347</a><br/> <a href="http://review.whamcloud.com/#/c/8102" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/8102</a></p> <p><a href="http://review.whamcloud.com/#/c/5380" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5380</a> - depends on patch <a href="http://review.whamcloud.com/#/c/7135" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/7135</a> from <a href="https://jira.whamcloud.com/browse/LU-3319" title="Adapt to 3.10 upstream kernel proc_dir_entry change" class="issue-link" data-issue-key="LU-3319"><del>LU-3319</del></a></p> <p>All patches have been landed to master. This ticket can be closed.</p> <p>Fixed in 2.6</p> <p>Patch <a href="http://review.whamcloud.com/8581" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/8581</a> landed on Lustre b2_4 branch for 2.4.2.</p> Related LU-3080 Development Rank 1|hzvj0v: Rank (Obsolete) 6778 Severity