https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-2853 Lustre <p>after landing <br/> Author: jxiong &lt;jxiong&gt; 2009-08-28 06:05:01<br/> Committer: jxiong &lt;jxiong&gt; 2009-08-28 06:05:01<br/> Parent: f907343dc34ac32bde1a56030d9994fa024a2874 (b=19955)<br/> Child: 2b87d9a6d9eefab2209030b167df7998c3d4c1d0 (b=20131)<br/> Precedes: v1_10_0_32, v1_9_251, v1_9_260, v1_9_270, v1_9_280, v1_9_290</p> <p> b=18881<br/> r=wangdi,eric.mei</p> <p>we have an unprotected call for loi_list_maint</p> <p>@@ -2523,7 +2532,7 @@ osc_send_oap_rpc(const struct lu_env *env, struct client_obd *cli,<br/> req = osc_build_req(env, cli, &amp;rpc_list, page_count, cmd);<br/> if (IS_ERR(req)) </p> { LASSERT(list_empty(&amp;rpc_list)); - /* loi_list_maint(cli, loi); */ + loi_list_maint(cli, loi); RETURN(PTR_ERR(req)); } <p>which modify a loi list without holding a cl_loi_list_lock - so open for races.<br/> that race may caused <a href="https://jira.whamcloud.com/browse/LU-2797" title="GPF in osc_send_oap_rpc" class="issue-link" data-issue-key="LU-2797"><del>LU-2797</del></a>.</p> LU-2853

osc send list corruption

Bug Critical Closed Duplicate Bruno Faccini Alexey Lyashkov Fri, 22 Feb 2013 08:29:08 +0000 Fri, 22 Feb 2013 17:33:35 +0000 Fri, 22 Feb 2013 13:14:01 +0000 Lustre 2.0.0 Lustre 2.1.0 Lustre 2.2.0 Lustre 2.3.0 Lustre 2.4.0 0 4 <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> req = osc_build_req(env, cli, &amp;rpc_list, page_count, cmd); <span class="code-keyword">if</span> (IS_ERR(req)) { LASSERT(list_empty(&amp;rpc_list)); - <span class="code-comment">/* loi_list_maint(cli, loi); */</span> + loi_list_maint(cli, loi); RETURN(PTR_ERR(req)); } </pre> </div></div> <p>Since I am in charge of <a href="https://jira.whamcloud.com/browse/LU-2797" title="GPF in osc_send_oap_rpc" class="issue-link" data-issue-key="LU-2797"><del>LU-2797</del></a>, I am taking this one too.<br/> Alexey, thank's already to point this!</p> <p>But in fact looking into the code, I think it is more complex, seems to me that it is assumed we also need to return back to osc_check_rpcs() with cl_loi_list_lock set anyway.<br/> Thus the fix would better look like to add a client_obd_list_lock(&amp;cli-&gt;cl_loi_list_lock) before loi_list_maint() call.</p> <p>Duplicate of <a href="https://jira.whamcloud.com/browse/LU-2797" title="GPF in osc_send_oap_rpc" class="issue-link" data-issue-key="LU-2797"><del>LU-2797</del></a></p> Duplicate LU-2797 Development Rank 1|hzvjnr: Rank (Obsolete) 6904 Severity