https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-2875 Lustre LU-2875

Remove LASSERT()s on return values from req_capsule_client_get() and similar

Task Major Resolved Fixed John Hammond John Hammond Tue, 26 Feb 2013 22:03:03 +0000 Wed, 19 Mar 2014 18:03:45 +0000 Wed, 19 Mar 2014 18:03:45 +0000 Lustre 2.4.0 Lustre 2.5.0 Lustre 2.6.0 0 2 <p>Also ensure that -EPROTO (rather than -EFAULT or other) is returned where req_capsule_client_get() fails.</p> <p>Please see <a href="http://review.whamcloud.com/#/c/7961/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/7961/</a> for a patch to make name (rr_name and rr_tgt) handling safer in the MDT layer.</p> <p>Would be nice to have a short description of the source of this bug (static code analysis, code inspection, defect hit during testing, etc) to be able to determine the urgency of landing the patch.</p> <p>This issue was opened after a read of the MDT code and some discussion with Oleg. Change 7961 was inspired by <a href="https://jira.whamcloud.com/browse/LU-3765" title="2.5.0&lt;-&gt;2.1.5 interop: sanity test 24u: (mdt_handler.c:224:mdt_lock_pdo_init()) ASSERTION( namelen &gt; 0 ) failed" class="issue-link" data-issue-key="LU-3765"><del>LU-3765</del></a>. AFAIK there are no interop situations that LBUG or Oops on bad name handling but I assume there are some corner cases out there.</p> <p>Does Dmitry's <a href="http://review.whamcloud.com/9276" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/9276</a> patch address these issues, and can this bug be closed?</p> Related LU-4629 LU-3765 Development Rank 1|hzvjx3: Rank (Obsolete) 6949