https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-288 Lustre <p>Not sure if this is done by design or not, but when running the single node test from within the lustre source tree the installed binaries are used by default; not the binaries in the lustre tree.</p> <p>For example, running sanity.sh will pick up /usr/bin/lfs and use that binary if it exists (or another lfs found in $PATH I would assume) instead of $LUSTRE/lustre/utils/lfs.</p> <p>Personally, I find this a bit confusing and frustrating at times. Say, I am working on the lfs command. If I make a change, recompile and run sanity.sh; this new patched version will not be used if there is a version that is already installed. It takes manual intervention to get the test to use my patched version (i.e. running 'export LFS=$LUSTRE/lustre/utils/lfs').</p> <p>Is this by design?</p> LU-288

In tree single node testing uses installed lustre binaries by default, not in tree binaries.

Improvement Minor Resolved Fixed Zhenyu Xu Prakash Surya Fri, 6 May 2011 11:28:03 +0000 Sat, 4 Jun 2011 05:44:08 +0000 Sat, 4 Jun 2011 05:44:08 +0000 Lustre 2.1.0 Lustre 2.1.0 0 2 <p>It definitely makes sense to use the binaries from the current build tree, if the tests are being run from there. I prefer to do this by prepending the right path to $PATH, instead of forcing all scripts to explicitly specify the full pathname to each tool. Using PATH means all scripts will be fixed, while forcing a full path for every call means a lot of effort to fix the problem, and ongoing opportunity to break the testing if some new usage of "lfs" is in place of a fully-qualified "$LFS" or similar.</p> <p>Of related interest is fixing bug 18057 (see <a href="https://bugzilla.lustre.org/show_bug.cgi?id=18057#c17" class="external-link" target="_blank" rel="nofollow noopener">https://bugzilla.lustre.org/show_bug.cgi?id=18057#c17</a>), which is related to this. Testing from the build tree will overwrite /sbin/mount.lustre, which is usually not fatal, but is wrong and can cause testing to fail in some cases.</p> <blockquote> <p>I prefer to do this by prepending the right path to $PATH, instead of forcing all scripts to explicitly specify the full pathname to each tool.</p></blockquote> <p>Agreed. So essentially the code in test-framework.sh (and possibly elsewhere) could be changed from:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-keyword">if</span> ! echo $PATH | grep -q $LUSTRE/utils; then export PATH=$PATH:$LUSTRE/utils fi </pre> </div></div> <p>to:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-keyword">if</span> ! echo $PATH | grep -q $LUSTRE/utils; then export PATH=$LUSTRE/utils:$PATH fi </pre> </div></div> <p>Or am I missing something?</p> <p>I think the shell's command lookup hash may have to be updated as well.</p> <p>Bobijam</p> <p>Could you please look into this one?</p> <p>Thanks</p> <p>Peter</p> <blockquote> <p>Of related interest is fixing bug 18057 (see <a href="https://bugzilla.lustre.org/show_bug.cgi?id=18057#c17" class="external-link" target="_blank" rel="nofollow noopener">https://bugzilla.lustre.org/show_bug.cgi?id=18057#c17</a>), which is related to this. Testing from the build tree will overwrite /sbin/mount.lustre, which is usually not fatal, but is wrong and can cause testing to fail in some cases.</p></blockquote> <p>In our environment, we're booting diskless nodes and the rootfs is mounted readonly. So cp'ing mount.lustre acutally fails in that case. Thus, we have to have a version already installed to run the tests.</p> <p>I can't seem to access bugzilla.lustre.org right now, but from what I remember from reading into it on Friday it seems the big hangup has to do with handling the '&#45;o loop' option. Does it make sense to simply use the '--bind' mount option and mount the executable in /sbin? And then umount it after the test completes?</p> <p>i.e.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"># Rather than cp use the following.. mount --bind $LUSTRE/lustre/utils/mount.lustre /sbin/mount.lustre # And unmount after tests are run umount /sbin/mount.lustre </pre> </div></div> <p>Although, I haven't done any real testing to see if this would actually work.</p> <p>tried the bind mount, and it works.</p> <p>patch tracking at <a href="http://review.whamcloud.com/525" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/525</a></p> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el6,ib_stack=inkernel/150/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el6,inkernel #150</a><br/> <a href="https://jira.whamcloud.com/browse/LU-288" title="In tree single node testing uses installed lustre binaries by default, not in tree binaries." class="issue-link" data-issue-key="LU-288"><del>LU-288</del></a> adjust PATH order in test framework</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0" class="external-link" target="_blank" rel="nofollow noopener">1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0</a><br/> Files : </p> <ul> <li>lustre/tests/test-framework.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=sles11,ib_stack=inkernel/150/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,sles11,inkernel #150</a><br/> <a href="https://jira.whamcloud.com/browse/LU-288" title="In tree single node testing uses installed lustre binaries by default, not in tree binaries." class="issue-link" data-issue-key="LU-288"><del>LU-288</del></a> adjust PATH order in test framework</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0" class="external-link" target="_blank" rel="nofollow noopener">1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0</a><br/> Files : </p> <ul> <li>lustre/tests/test-framework.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el5,ib_stack=inkernel/150/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el5,inkernel #150</a><br/> <a href="https://jira.whamcloud.com/browse/LU-288" title="In tree single node testing uses installed lustre binaries by default, not in tree binaries." class="issue-link" data-issue-key="LU-288"><del>LU-288</del></a> adjust PATH order in test framework</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0" class="external-link" target="_blank" rel="nofollow noopener">1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0</a><br/> Files : </p> <ul> <li>lustre/tests/test-framework.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el5,ib_stack=ofa/150/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el5,ofa #150</a><br/> <a href="https://jira.whamcloud.com/browse/LU-288" title="In tree single node testing uses installed lustre binaries by default, not in tree binaries." class="issue-link" data-issue-key="LU-288"><del>LU-288</del></a> adjust PATH order in test framework</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0" class="external-link" target="_blank" rel="nofollow noopener">1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0</a><br/> Files : </p> <ul> <li>lustre/tests/test-framework.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=ubuntu1004,ib_stack=inkernel/150/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,ubuntu1004,inkernel #150</a><br/> <a href="https://jira.whamcloud.com/browse/LU-288" title="In tree single node testing uses installed lustre binaries by default, not in tree binaries." class="issue-link" data-issue-key="LU-288"><del>LU-288</del></a> adjust PATH order in test framework</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0" class="external-link" target="_blank" rel="nofollow noopener">1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0</a><br/> Files : </p> <ul> <li>lustre/tests/test-framework.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el6,ib_stack=inkernel/150/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el6,inkernel #150</a><br/> <a href="https://jira.whamcloud.com/browse/LU-288" title="In tree single node testing uses installed lustre binaries by default, not in tree binaries." class="issue-link" data-issue-key="LU-288"><del>LU-288</del></a> adjust PATH order in test framework</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0" class="external-link" target="_blank" rel="nofollow noopener">1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0</a><br/> Files : </p> <ul> <li>lustre/tests/test-framework.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el6,ib_stack=inkernel/150/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el6,inkernel #150</a><br/> <a href="https://jira.whamcloud.com/browse/LU-288" title="In tree single node testing uses installed lustre binaries by default, not in tree binaries." class="issue-link" data-issue-key="LU-288"><del>LU-288</del></a> adjust PATH order in test framework</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0" class="external-link" target="_blank" rel="nofollow noopener">1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0</a><br/> Files : </p> <ul> <li>lustre/tests/test-framework.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=ubuntu1004,ib_stack=ofa/150/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,ubuntu1004,ofa #150</a><br/> <a href="https://jira.whamcloud.com/browse/LU-288" title="In tree single node testing uses installed lustre binaries by default, not in tree binaries." class="issue-link" data-issue-key="LU-288"><del>LU-288</del></a> adjust PATH order in test framework</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0" class="external-link" target="_blank" rel="nofollow noopener">1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0</a><br/> Files : </p> <ul> <li>lustre/tests/test-framework.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el5,ib_stack=inkernel/150/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el5,inkernel #150</a><br/> <a href="https://jira.whamcloud.com/browse/LU-288" title="In tree single node testing uses installed lustre binaries by default, not in tree binaries." class="issue-link" data-issue-key="LU-288"><del>LU-288</del></a> adjust PATH order in test framework</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0" class="external-link" target="_blank" rel="nofollow noopener">1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0</a><br/> Files : </p> <ul> <li>lustre/tests/test-framework.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el5,ib_stack=ofa/150/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el5,ofa #150</a><br/> <a href="https://jira.whamcloud.com/browse/LU-288" title="In tree single node testing uses installed lustre binaries by default, not in tree binaries." class="issue-link" data-issue-key="LU-288"><del>LU-288</del></a> adjust PATH order in test framework</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0" class="external-link" target="_blank" rel="nofollow noopener">1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0</a><br/> Files : </p> <ul> <li>lustre/tests/test-framework.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el5,ib_stack=inkernel/150/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el5,inkernel #150</a><br/> <a href="https://jira.whamcloud.com/browse/LU-288" title="In tree single node testing uses installed lustre binaries by default, not in tree binaries." class="issue-link" data-issue-key="LU-288"><del>LU-288</del></a> adjust PATH order in test framework</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0" class="external-link" target="_blank" rel="nofollow noopener">1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0</a><br/> Files : </p> <ul> <li>lustre/tests/test-framework.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el6,ib_stack=inkernel/150/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el6,inkernel #150</a><br/> <a href="https://jira.whamcloud.com/browse/LU-288" title="In tree single node testing uses installed lustre binaries by default, not in tree binaries." class="issue-link" data-issue-key="LU-288"><del>LU-288</del></a> adjust PATH order in test framework</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0" class="external-link" target="_blank" rel="nofollow noopener">1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0</a><br/> Files : </p> <ul> <li>lustre/tests/test-framework.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el5,ib_stack=inkernel/150/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el5,inkernel #150</a><br/> <a href="https://jira.whamcloud.com/browse/LU-288" title="In tree single node testing uses installed lustre binaries by default, not in tree binaries." class="issue-link" data-issue-key="LU-288"><del>LU-288</del></a> adjust PATH order in test framework</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0" class="external-link" target="_blank" rel="nofollow noopener">1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0</a><br/> Files : </p> <ul> <li>lustre/tests/test-framework.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el5,ib_stack=ofa/150/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el5,ofa #150</a><br/> <a href="https://jira.whamcloud.com/browse/LU-288" title="In tree single node testing uses installed lustre binaries by default, not in tree binaries." class="issue-link" data-issue-key="LU-288"><del>LU-288</del></a> adjust PATH order in test framework</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0" class="external-link" target="_blank" rel="nofollow noopener">1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0</a><br/> Files : </p> <ul> <li>lustre/tests/test-framework.sh</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://newbuild.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://newbuild.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el5,ib_stack=ofa/150/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el5,ofa #150</a><br/> <a href="https://jira.whamcloud.com/browse/LU-288" title="In tree single node testing uses installed lustre binaries by default, not in tree binaries." class="issue-link" data-issue-key="LU-288"><del>LU-288</del></a> adjust PATH order in test framework</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&amp;a=commit&amp;h=1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0" class="external-link" target="_blank" rel="nofollow noopener">1eaf5c9a838b75faca8c3f61bffb1ff51192a2d0</a><br/> Files : </p> <ul> <li>lustre/tests/test-framework.sh</li> </ul> <p>has been landed on master</p> Development Rank 1|hzv92f: Rank (Obsolete) 5003