https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-2880 Lustre <p>Note this is not a bug in lustre but in ldisks as a top level filesystem. The d_types returned have an extra bit set (perhaps from putting FIDs in dirents). The most annoying symptom of this is that it breaks find.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># llmount.sh ... # mkdir -p /mnt/lustre/D/D/D/D/D/D # touch /mnt/lustre/D/D/D/D/D/D/XXX # find /mnt/lustre /mnt/lustre /mnt/lustre/.lustre /mnt/lustre/D /mnt/lustre/D/D /mnt/lustre/D/D/D /mnt/lustre/D/D/D/D /mnt/lustre/D/D/D/D/D /mnt/lustre/D/D/D/D/D/D /mnt/lustre/D/D/D/D/D/D/XXX # umount /mnt/lustre /mnt/mds1 # # mount /tmp/lustre-mdt1 /mnt/mds1 -t ldiskfs -o loop,ro # find /mnt/mds1/ROOT -name XXX # stat /mnt/mds1/ROOT/D/D/D/D/D/D/XXX File: `/mnt/mds1/ROOT/D/D/D/D/D/D/XXX' Size: 0 Blocks: 0 IO Block: 4096 regular empty file Device: 700h/1792d Inode: 111 Links: 1 Access: (0644/-rw-r--r--) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2013-02-26 21:37:51.000000000 -0600 Modify: 2013-02-26 21:37:51.000000000 -0600 Change: 2013-02-26 21:37:51.000000000 -0600 # find /mnt/mds1/ROOT /mnt/mds1/ROOT /mnt/mds1/ROOT/.lustre /mnt/mds1/ROOT/D # sys_getdents --verbose /mnt/mds1/ROOT d_type = 4 (d), d_ino = 2, d_off = 2085404527983360875, d_reclen = 24, d_name = '..' d_type = 4 (d), d_ino = 50013, d_off = 3188331865672730665, d_reclen = 24, d_name = '.' dirent '.lustre' has unknown d_type 20 d_type = 20 (!), d_ino = 50014, d_off = 8374721202256512604, d_reclen = 32, d_name = '.lustre' dirent 'D' has unknown d_type 20 d_type = 20 (!), d_ino = 50015, d_off = 9223372036854775807, d_reclen = 24, d_name = 'D' # # sys_getdents --verbose /mnt/mds1/ROOT/D/D/D/D/D/D/ dirent '..' has unknown d_type 20 d_type = 20 (!), d_ino = 50019, d_off = 2085404527983360875, d_reclen = 24, d_name = '..' d_type = 4 (d), d_ino = 50020, d_off = 6678178485617948048, d_reclen = 24, d_name = '.' dirent 'XXX' has unknown d_type 24 d_type = 24 (!), d_ino = 111, d_off = 9223372036854775807, d_reclen = 24, d_name = 'XXX' </pre> </div></div> LU-2880

ldiskfs getdents() returns invalid d_types

Bug Minor Resolved Fixed Bob Glossman John Hammond patch Tue, 26 Feb 2013 23:21:23 +0000 Thu, 14 Aug 2014 16:55:55 +0000 Mon, 2 Jun 2014 15:46:56 +0000 Lustre 2.4.0 Lustre 2.6.0 0 11 <p>ldiskfs just does not return the file type bits but also the dirdata info bits (get_dtype()).<br/> The osd-ldiskfs layer calls ldiskfs internally and it needs this dirdata bit information.<br/> From osd-ldiskfs call_filldir() (its used for htree indexing directories) calls get_dtype().<br/> So simply masking the dirdata bits would break the osd-ldiskfs functionality.</p> <p>Other way to fix the issue could be , provide a mount option "nodirdata" for mounting ldiskfs. If this option is set we will not return dirdata bits information.</p> <p>It makes more sense to add a mount option to <em>enable</em> the dirdata options in the ext4_data_in_dirent, and then set this mount option to osd_ldiskfs/osd_handler.c::osd_mount(). This will make the dirdata only available for Lustre, and will not require non-Lustre mounts to specify an option in order to work properly.</p> <p>Instead of passing a text mount option in osd_mount() (which adds complexity and is prone to errors if ldiskfs is packaged separately and wasn't patched for this option) it is also possible to set this option directly in the superblock:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> #define EXT4_MOUNT_ERRORS_MASK 0x00070 #define EXT4_MOUNT_MINIX_DF 0x00080 <span class="code-comment">/* Mimics the Minix statfs */</span> #define EXT4_MOUNT_NOLOAD 0x00100 <span class="code-comment">/* Don't use existing journal*/</span> +#define EXT4_MOUNT_DIRDATA 0x00200 <span class="code-comment">/* Data in directory entries */</span> #define EXT4_MOUNT_DATA_FLAGS 0x00C00 <span class="code-comment">/* Mode <span class="code-keyword">for</span> data writes: */</span> #define EXT4_MOUNT_JOURNAL_DATA 0x00400 <span class="code-comment">/* Write data to journal */</span> #define EXT4_MOUNT_ORDERED_DATA 0x00800 <span class="code-comment">/* Flush data before commit */</span> <span class="code-keyword">static</span> <span class="code-object">int</span> osd_mount(...) { <span class="code-keyword">if</span> (lmd_flags &amp; LMD_FLG_NOSCRUB) o-&gt;od_noscrub = 1; +#ifdef EXT4_MOUNT_OPT_DIRDATA + <span class="code-keyword">if</span> (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_DIRDATA)) + set_opt(o-&gt;od_mnt-&gt;mnt_sb, DIRDATA); +#endif out: <span class="code-keyword">if</span> (__page) OBD_PAGE_FREE(__page); </pre> </div></div> <p>This value for EXT4_MOUNT_DIRDATA appears to be unused for all of the relevant kernels. In <tt>get_dtype()</tt> it can just check for this mount option instead of checking the feature flag each time:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">if</span> (!test_opt(sb, DIRDATA)) <span class="code-keyword">return</span> ext4_filetype_table[fl_index]; <span class="code-keyword">return</span> (ext4_filetype_table[fl_index]) | (filetype &amp; EXT4_DIRENT_LUFID); </pre> </div></div> <p>Thanks Andreas, I have raised the code review request for it: <br/> <a href="http://review.whamcloud.com/#change,6495" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,6495</a><br/> Similar changes need to be done for sles11sp2.</p> <p>We ran into this with our purge utility. Do you mind if I update the patch and try it out on our SuSE boxes.</p> <p>Sure.</p> <p>Patch <a href="http://review.whamcloud.com/#/c/6411/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/6411/</a> is related to this ticket. </p> <p>Bob will take over this one</p> <p>Patch landed to Master. </p> Duplicate LU-2881 Development Rank 1|hzvjyf: Rank (Obsolete) 6955 Severity