<!-- 
RSS generated by JIRA (9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c) at Sat Feb 10 01:29:09 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Whamcloud Community JIRA</title>
    <link>https://jira.whamcloud.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.4.14</version>
        <build-number>940014</build-number>
        <build-date>05-12-2023</build-date>
    </build-info>


<item>
            <title>[LU-2896] IR enabled MGS don&apos;t able to register old OST</title>
                <link>https://jira.whamcloud.com/browse/LU-2896</link>
                <project id="10000" key="LU">Lustre</project>
                    <description>&lt;p&gt;Xyratex port IR patch from upstream to own code and see MGS don&apos;t able to register old OST in new MGS, with EINVAL.&lt;/p&gt;

&lt;p&gt;collecting logs point to &lt;br/&gt;
mgs_handle_target_reg function and code&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;        &lt;span class=&quot;code-comment&quot;&gt;/* Do not support unregistering right now. */&lt;/span&gt;
        &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (opc != LDD_F_OPC_REG)
                GOTO(out_nolock, rc = -EINVAL);
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;in case 2.1 OST (or any pre IR target) don&apos;t set any flag from list&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;#define LDD_F_OPC_REG   0x10000000
#define LDD_F_OPC_UNREG 0x20000000
#define LDD_F_OPC_READY 0x40000000
#define LDD_F_OPC_MASK  0xf0000000
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;at own side and opc is zero. that broke target to be register.&lt;/p&gt;


&lt;p&gt;PS. did you have interoperability testing for IR ?&lt;/p&gt;</description>
                <environment>OST 2.1, MGS 2.1+ported IR patch.</environment>
        <key id="17746">LU-2896</key>
            <summary>IR enabled MGS don&apos;t able to register old OST</summary>
                <type id="1" iconUrl="https://jira.whamcloud.com/secure/viewavatar?size=xsmall&amp;avatarId=11303&amp;avatarType=issuetype">Bug</type>
                                            <priority id="1" iconUrl="https://jira.whamcloud.com/images/icons/priorities/blocker.svg">Blocker</priority>
                        <status id="5" iconUrl="https://jira.whamcloud.com/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="jamesanunez">James Nunez</assignee>
                                    <reporter username="shadow">Alexey Lyashkov</reporter>
                        <labels>
                            <label>LB</label>
                            <label>patch</label>
                    </labels>
                <created>Fri, 1 Mar 2013 14:19:38 +0000</created>
                <updated>Thu, 7 Mar 2013 00:08:49 +0000</updated>
                            <resolved>Thu, 7 Mar 2013 00:08:49 +0000</resolved>
                                    <version>Lustre 2.3.0</version>
                    <version>Lustre 2.4.0</version>
                                    <fixVersion>Lustre 2.4.0</fixVersion>
                                        <due></due>
                            <votes>0</votes>
                                    <watches>6</watches>
                                                                            <comments>
                            <comment id="53229" author="shadow" created="Sat, 2 Mar 2013 00:39:00 +0000"  >&lt;p&gt;Fix looks simple, if target isn&apos;t IR capable, we must don&apos;t search may operations from submited info and assume operation is LDD_F_OPC_REG.&lt;/p&gt;

&lt;p&gt;that code was don&apos;t need if IR author mark LDD_F_OPC_REG to zero, but now it&apos;s protocol change. &lt;/p&gt;</comment>
                            <comment id="53240" author="shadow" created="Sun, 3 Mar 2013 14:02:56 +0000"  >&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;diff --git a/lustre/mgs/mgs_handler.c b/lustre/mgs/mgs_handler.c
index 83fcdb6..f17f81a 100644
--- a/lustre/mgs/mgs_handler.c
+++ b/lustre/mgs/mgs_handler.c
@@ -494,7 +494,12 @@ &lt;span class=&quot;code-keyword&quot;&gt;static&lt;/span&gt; &lt;span class=&quot;code-object&quot;&gt;int&lt;/span&gt; mgs_handle_target_reg(struct ptlrpc_request *req)
 
         mti = req_capsule_client_get(&amp;amp;req-&amp;gt;rq_pill, &amp;amp;RMF_MGS_TARGET_INFO);
 
+       &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; ((req-&amp;gt;rq_export-&amp;gt;exp_connect_data.ocd_connect_flags 
+               &amp;amp; OBD_CONNECT_IMP_RECOV) == 0)
+               opc = LDD_F_OPC_REG;
+       &lt;span class=&quot;code-keyword&quot;&gt;else&lt;/span&gt;
         opc = mti-&amp;gt;mti_flags &amp;amp; LDD_F_OPC_MASK;
+
         &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (opc == LDD_F_OPC_READY) {
                 CDEBUG(D_MGS, &lt;span class=&quot;code-quote&quot;&gt;&quot;fs: %s index: %d is ready to reconnect.\n&quot;&lt;/span&gt;,
                        mti-&amp;gt;mti_fsname, mti-&amp;gt;mti_stripe_index);
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;fixes bug for me.&lt;/p&gt;</comment>
                            <comment id="53253" author="shadow" created="Mon, 4 Mar 2013 06:46:00 +0000"  >&lt;p&gt;remote: New Changes:&lt;br/&gt;
remote:   &lt;a href=&quot;http://review.whamcloud.com/5574&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/5574&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;Xyratex bug: MRP-880&lt;/p&gt;</comment>
                            <comment id="53284" author="jlevi" created="Mon, 4 Mar 2013 14:39:48 +0000"  >&lt;p&gt;James,&lt;br/&gt;
Could you please see this one to completion?&lt;/p&gt;</comment>
                            <comment id="53290" author="jamesanunez" created="Mon, 4 Mar 2013 15:24:41 +0000"  >&lt;p&gt;Sure. I&apos;ve got it.&lt;/p&gt;</comment>
                            <comment id="53498" author="pjones" created="Thu, 7 Mar 2013 00:08:49 +0000"  >&lt;p&gt;Landed for 2.4&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                            <customfield id="customfield_10890" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10390" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hzvk3z:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>6982</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10060" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Severity</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10022"><![CDATA[3]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>